-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
Status: TriageThis is being looked at and prioritizedThis is being looked at and prioritizedType: FeatureNew feature or requestNew feature or request
Description
Describe the need
The position parameter is closing down, line should be used instead with the side and subject_type parameters.
Notes:
- the
sideparameters must be UPPER CASE or left blank for files - the
subject_typeparameter must be lower case and can (must?) be removed iflinebut is required forfilewhich does not have thelineparameter set start_linemuss be LESS thanline, it cannot have the same value. Remove parameter if single line comment.
I am not sure, but I think the start_side, is defined because of a range comment, must also be equal to side.
As reference, I am using this bit of code, posted via HttpClient, in my migration project.
int? startLine = null;
if (position.OldLine.HasValue)
{
startLine = position.LineRange?.Start?.OldLine;
payload.line = position.OldLine;
payload.side = "LEFT";
}
else if (position.NewLine.HasValue)
{
startLine = position.LineRange?.Start?.NewLine;
payload.line = position.NewLine;
payload.side = "RIGHT";
}
else
{
payload.subject_type = "file";
}
if (payload.line > startLine)
{
payload.start_line = startLine;
payload.start_side = payload.side;
}
with the JSON serializer set to "remove propertiers with default vaules"
SDK Version
No response
API Version
No response
Relevant log output
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Status: TriageThis is being looked at and prioritizedThis is being looked at and prioritizedType: FeatureNew feature or requestNew feature or request
Type
Projects
Status
π Triage