Skip to content

Commit 18f0be5

Browse files
authored
fix: createLogger should not recreate the logger object if it already exists (#1162)
1 parent 6965d70 commit 18f0be5

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

src/create-logger.ts

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,18 @@ export interface Logger {
55
error: (...data: any[]) => void;
66
}
77

8-
export const createLogger = (logger?: Partial<Logger>): Logger => ({
9-
debug: () => {},
10-
info: () => {},
11-
warn: console.warn.bind(console),
12-
error: console.error.bind(console),
13-
...logger,
14-
});
8+
export const createLogger = (logger = {} as Partial<Logger>): Logger => {
9+
if (typeof logger.debug !== "function") {
10+
logger.debug = () => {};
11+
}
12+
if (typeof logger.info !== "function") {
13+
logger.info = () => {};
14+
}
15+
if (typeof logger.warn !== "function") {
16+
logger.warn = console.warn.bind(console);
17+
}
18+
if (typeof logger.error !== "function") {
19+
logger.error = console.error.bind(console);
20+
}
21+
return logger as Logger;
22+
};

0 commit comments

Comments
 (0)