fix critical bug related to affecting base url

Author: kamilsk

pkg/service/internal_test.go

@@ -10,12 +10,12 @@ import (
 func Test_extend(t *testing.T) {
 	tests := []struct {
 		name     string
-		url      *url.URL
+		url      url.URL
 		paths    []string
 		expected string
 	}{
-		{"without paths", &url.URL{Path: "/"}, nil, "/"},
-		{"with some paths", &url.URL{Path: "/with"}, []string{"some", "paths"}, "/with/some/paths"},
+		{"without paths", url.URL{Path: "/"}, nil, "/"},
+		{"with some paths", url.URL{Path: "/with"}, []string{"some", "paths"}, "/with/some/paths"},
 	}
 
 	for _, test := range tests {

pkg/service/service.go

@@ -11,6 +11,8 @@ import (
 	"strings"
 	"time"
 
+	repository "github.com/kamilsk/form-api/pkg/storage/types"
+
 	"github.com/kamilsk/form-api/pkg/config"
 	"github.com/kamilsk/form-api/pkg/domain"
 	"github.com/kamilsk/form-api/pkg/errors"
@@ -87,14 +89,30 @@ func (service *Forma) HandleInput(ctx context.Context, req v1.PostRequest) (resp
 		return
 	}
 
-	input, storeErr := service.storage.StoreInput(ctx, req.ID, verified)
+	var input *repository.Input
+	input, resp.Error = service.storage.StoreInput(ctx, req.ID, verified)
+
+	if resp.Error == nil && !req.Context.Option().NoLog && !ignore(req.Context) {
+		// if option.Anonymously {}
+		event := domain.InputEvent{
+			SchemaID:   req.ID,
+			InputID:    input.ID,
+			TemplateID: req.InputData.Template(),
+			Identifier: nil, // TODO issue#171
+			Context:    req.Context,
+			Code:       http.StatusFound, // TODO issue#design
+			URL:        resp.URL,
+		}
+		resp.Error = service.tracker.LogInput(ctx, event) // TODO issue#109
+	}
+
 	if u, err := url.Parse(resp.URL); err == nil {
 		type feedback struct {
 			ID       domain.ID `json:"input"`
 			SchemaID domain.ID `json:"id"`
 			Result   string    `json:"result"`
 		}
-		if storeErr != nil {
+		if resp.Error != nil {
 			u.Fragment = base64.StdEncoding.EncodeToString(func() []byte {
 				raw, _ := json.Marshal(feedback{SchemaID: req.ID, Result: "failure"})
 				return raw
@@ -108,20 +126,6 @@ func (service *Forma) HandleInput(ctx context.Context, req v1.PostRequest) (resp
 		resp.URL = u.String()
 	}
 
-	if storeErr == nil && !req.Context.Option().NoLog && !ignore(req.Context) {
-		// if option.Anonymously {}
-		event := domain.InputEvent{
-			SchemaID:   req.ID,
-			InputID:    input.ID,
-			TemplateID: req.InputData.Template(),
-			Identifier: nil, // TODO issue#171
-			Context:    req.Context,
-			Code:       http.StatusFound, // TODO issue#design
-			URL:        resp.URL,
-		}
-		resp.Error = service.tracker.LogInput(ctx, event) // TODO issue#109
-	}
-
 	return resp
 }
 
@@ -130,12 +134,12 @@ func enrich(base *url.URL, schema *domain.Schema) {
 		schema.Inputs[i].ID = schema.ID + "_" + schema.Inputs[i].Name
 	}
 	// replace fallback by current API call
-	schema.Action = extend(base, "api/v1", schema.ID)
+	schema.Action = extend(*base, "api/v1", schema.ID)
 	schema.Method = http.MethodPost
 	schema.EncodingType = "application/x-www-form-urlencoded"
 }
 
-func extend(base *url.URL, paths ...string) string {
+func extend(base url.URL, paths ...string) string {
 	if len(paths) == 0 {
 		return base.String()
 	}