Merge pull request #137 from odefun/feat/discord-settings-markdown-177194

LIU9293 · web-flow · commit 23f7e9163482 · 2026-02-25T11:14:32.000+08:00
fix: unify markdown messaging and simplify Discord settings UX
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ode",
-  "version": "0.0.90",
+  "version": "0.0.91",
   "description": "Coding anywhere with your coding agents connected",
   "module": "packages/core/index.ts",
   "type": "module",
diff --git a/packages/core/runtime.ts b/packages/core/runtime.ts
@@ -152,7 +152,7 @@ export function createCoreRuntime(deps: RuntimeDeps) {
 
     if (finalChunks.length > 1) {
       if (statusFormat !== "aggressive" && !statusRateLimited) {
-        await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below in multiple messages.", false);
+        await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below in multiple messages.");
       } else if (statusRateLimited) {
         log.warn("Skipping final status update due to prior 429; posting final chunks as new messages", {
           channelId,
@@ -163,13 +163,13 @@ export function createCoreRuntime(deps: RuntimeDeps) {
       }
 
       for (const chunk of finalChunks) {
-        await runtimeDeps.im.sendMessage(channelId, threadId, chunk, true);
+        await runtimeDeps.im.sendMessage(channelId, threadId, chunk);
       }
       return;
     }
 
     if (statusFormat === "aggressive") {
-      await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk, true);
+      await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk);
       return;
     }
 
@@ -180,18 +180,18 @@ export function createCoreRuntime(deps: RuntimeDeps) {
         statusTs,
         ...(statusRateLimitError ? { error: statusRateLimitError } : {}),
       });
-      await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk, true);
+      await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk);
       return;
     }
 
     const maxEditableMessageChars = runtimeDeps.im.maxEditableMessageChars;
     if (typeof maxEditableMessageChars === "number" && singleChunk.length > maxEditableMessageChars) {
-      await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below.", false);
-      await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk, true);
+      await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below.");
+      await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk);
       return;
     }
 
-    await runtimeDeps.im.updateMessage(channelId, statusTs, singleChunk, true);
+    await runtimeDeps.im.updateMessage(channelId, statusTs, singleChunk);
   }
 
   async function handleUserMessageInternal(context: CoreMessageContext, text: string): Promise<void> {
diff --git a/packages/core/runtime/event-stream.ts b/packages/core/runtime/event-stream.ts
@@ -169,8 +169,7 @@ export async function startEventStreamWatcher(
             workingPath,
             state: liveParsedState.get(messageKey),
             statusMessageFormat: resolveStatusMessageFormat(),
-          }),
-          false
+          })
         );
         if (typeof updatedStatusTs === "string" && updatedStatusTs !== request.statusMessageTs) {
           request.statusMessageTs = updatedStatusTs;
diff --git a/packages/core/runtime/message-updates.ts b/packages/core/runtime/message-updates.ts
@@ -6,7 +6,6 @@ type QueuedUpdate = {
   channelId: string;
   messageTs: string;
   text: string;
-  asMarkdown: boolean;
   resolve: (messageTs?: string) => void;
 };
 
@@ -44,7 +43,7 @@ export function createRateLimitedImAdapter(
 
       globalLastUpdateAt = Date.now();
       try {
-        const maybeUpdatedTs = await im.updateMessage(item.channelId, item.messageTs, item.text, item.asMarkdown);
+        const maybeUpdatedTs = await im.updateMessage(item.channelId, item.messageTs, item.text);
         item.resolve(typeof maybeUpdatedTs === "string" ? maybeUpdatedTs : undefined);
       } catch (error) {
         if (isRateLimitError(error)) {
@@ -87,8 +86,7 @@ export function createRateLimitedImAdapter(
     updateMessage: async (
       channelId: string,
       messageTs: string,
-      text: string,
-      asMarkdown = true
+      text: string
     ): Promise<string | undefined> => {
       for (let i = queue.length - 1; i >= 0; i--) {
         const queued = queue[i];
@@ -99,7 +97,7 @@ export function createRateLimitedImAdapter(
       }
 
       return new Promise<string | undefined>((resolve) => {
-        queue.push({ channelId, messageTs, text, asMarkdown, resolve });
+        queue.push({ channelId, messageTs, text, resolve });
         void processQueue();
       });
     },
diff --git a/packages/core/runtime/open-request.ts b/packages/core/runtime/open-request.ts
@@ -60,8 +60,7 @@ export async function runOpenRequest(params: {
   const initialStatusTs = await deps.im.sendMessage(
     context.channelId,
     context.replyThreadId,
-    `${providerLabel} is running...`,
-    false
+    `${providerLabel} is running...`
   );
 
   if (!initialStatusTs) {
@@ -126,7 +125,7 @@ export async function runOpenRequest(params: {
         statusMessageFormat: resolveStatusMessageFormat(),
       });
       if (!request.statusFrozen) {
-        const updatedStatusTs = await deps.im.updateMessage(context.channelId, statusTs, statusText, false);
+        const updatedStatusTs = await deps.im.updateMessage(context.channelId, statusTs, statusText);
         if (typeof updatedStatusTs === "string" && updatedStatusTs !== statusTs) {
           statusTs = updatedStatusTs;
           request.statusMessageTs = updatedStatusTs;
diff --git a/packages/core/runtime/pending-question.ts b/packages/core/runtime/pending-question.ts
@@ -33,7 +33,7 @@ export async function handlePendingQuestionReply(params: {
 
   const trimmed = text.trim();
   if (!trimmed) {
-    await deps.im.sendMessage(context.channelId, context.replyThreadId, "Please reply with an answer.", false);
+    await deps.im.sendMessage(context.channelId, context.replyThreadId, "Please reply with an answer.");
     return true;
   }
 
@@ -54,8 +54,7 @@ export async function handlePendingQuestionReply(params: {
     await deps.im.sendMessage(
       context.channelId,
       context.replyThreadId,
-      "Failed to submit your answer. Please try again.",
-      false
+      "Failed to submit your answer. Please try again."
     );
     return true;
   }
diff --git a/packages/core/runtime/recovery.ts b/packages/core/runtime/recovery.ts
@@ -33,8 +33,7 @@ export async function recoverPendingRequests(
     await im.updateMessage(
       request.channelId,
       request.statusMessageTs,
-      "_Bot restarted - please resend your message_",
-      false
+      "_Bot restarted - please resend your message_"
     );
 
     clearActiveRequest(session.channelId, session.threadId);
diff --git a/packages/core/runtime/request-runner.ts b/packages/core/runtime/request-runner.ts
@@ -159,7 +159,7 @@ export async function runTrackedRequest(
     liveParsedState.delete(getStatusMessageKey(request));
 
     const errorStatus = `Error: ${message}\n_${suggestion}_`;
-    await deps.im.updateMessage(request.channelId, request.statusMessageTs, errorStatus, false);
+    await deps.im.updateMessage(request.channelId, request.statusMessageTs, errorStatus);
     onFail(message);
     return { responses: null };
   }
diff --git a/packages/core/runtime/selection-reply.ts b/packages/core/runtime/selection-reply.ts
@@ -73,7 +73,7 @@ export async function handleSelectionReply(params: HandleSelectionReplyParams):
   const providerId = deps.agent.getProviderForSession(sessionId);
   const providerLabel = deps.agent.getDisplayNameForSession(sessionId);
 
-  const initialStatusTs = await deps.im.sendMessage(channelId, threadId, `${providerLabel} is running...`, false);
+  const initialStatusTs = await deps.im.sendMessage(channelId, threadId, `${providerLabel} is running...`);
   if (!initialStatusTs) {
     log.error("Failed to send status message for button selection");
     return;
@@ -142,7 +142,7 @@ export async function handleSelectionReply(params: HandleSelectionReplyParams):
         state: state.liveParsedState.get(statusMessageKey),
         statusMessageFormat: resolveStatusMessageFormat(),
       });
-      const updatedStatusTs = await deps.im.updateMessage(channelId, statusTs, statusText, false);
+      const updatedStatusTs = await deps.im.updateMessage(channelId, statusTs, statusText);
       if (typeof updatedStatusTs === "string" && updatedStatusTs !== statusTs) {
         statusTs = updatedStatusTs;
         request.statusMessageTs = updatedStatusTs;
diff --git a/packages/core/runtime/session-bootstrap.ts b/packages/core/runtime/session-bootstrap.ts
@@ -32,7 +32,7 @@ export async function prepareRuntimeSession(params: {
   try {
     cwd = resolveChannelCwd(channelId).cwd;
   } catch (err) {
-    await deps.im.sendMessage(channelId, replyThreadId, `Error: ${String(err)}`, false);
+    await deps.im.sendMessage(channelId, replyThreadId, `Error: ${String(err)}`);
     return null;
   }
 
@@ -55,7 +55,7 @@ export async function prepareRuntimeSession(params: {
       threadId,
       error: String(err),
     });
-    await deps.im.sendMessage(channelId, replyThreadId, `Error: ${message}\n_${suggestion}_`, false);
+    await deps.im.sendMessage(channelId, replyThreadId, `Error: ${message}\n_${suggestion}_`);
     return null;
   }
 
@@ -74,7 +74,7 @@ export async function prepareRuntimeSession(params: {
         gitIdentity,
       });
       if (worktree.skipped && worktree.message) {
-        await deps.im.sendMessage(channelId, replyThreadId, worktree.message, false);
+        await deps.im.sendMessage(channelId, replyThreadId, worktree.message);
       }
       cwd = resolvedCwd;
     } catch (err) {
@@ -85,7 +85,7 @@ export async function prepareRuntimeSession(params: {
         sessionId,
         error: message,
       });
-      await deps.im.sendMessage(channelId, replyThreadId, `Error: Failed to prepare worktree. ${message}`, false);
+      await deps.im.sendMessage(channelId, replyThreadId, `Error: Failed to prepare worktree. ${message}`);
       return null;
     }
   }
diff --git a/packages/core/types.ts b/packages/core/types.ts
@@ -52,12 +52,11 @@ export type AgentStatusMessageParams = {
 
 export interface IMAdapter {
   maxEditableMessageChars?: number;
-  sendMessage(channelId: string, threadId: string, text: string, asMarkdown?: boolean): Promise<string | undefined>;
+  sendMessage(channelId: string, threadId: string, text: string): Promise<string | undefined>;
   updateMessage(
     channelId: string,
     messageTs: string,
-    text: string,
-    asMarkdown?: boolean
+    text: string
   ): Promise<string | undefined | void>;
   wasRateLimited?(channelId: string, messageTs: string): boolean;
   getRateLimitError?(channelId: string, messageTs: string): string | undefined;
diff --git a/packages/ims/discord/client.ts b/packages/ims/discord/client.ts
@@ -89,8 +89,7 @@ async function buildDiscordContext(
 async function sendMessage(
   _channelId: string,
   threadId: string,
-  text: string,
-  _asMarkdown = true
+  text: string
 ): Promise<string | undefined> {
   const channel = await resolveTextChannel(threadId);
   const chunks = splitForDiscord(text);
@@ -106,8 +105,7 @@ async function sendMessage(
 async function updateMessage(
   channelId: string,
   messageId: string,
-  text: string,
-  _asMarkdown = true
+  text: string
 ): Promise<void> {
   try {
     const mappedThreadId = statusMessageThreadMap.get(messageId);
diff --git a/packages/ims/discord/settings.ts b/packages/ims/discord/settings.ts
diff --git a/packages/ims/lark/client.ts b/packages/ims/lark/client.ts
diff --git a/packages/ims/slack/client.ts b/packages/ims/slack/client.ts

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ode",`
`3`		`- "version": "0.0.90",`
	`3`	`+ "version": "0.0.91",`
`4`	`4`	`"description": "Coding anywhere with your coding agents connected",`
`5`	`5`	`"module": "packages/core/index.ts",`
`6`	`6`	`"type": "module",`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ export function createCoreRuntime(deps: RuntimeDeps) {`
`152`	`152`
`153`	`153`	`if (finalChunks.length > 1) {`
`154`	`154`	`if (statusFormat !== "aggressive" && !statusRateLimited) {`
`155`		`- await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below in multiple messages.", false);`
	`155`	`+ await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below in multiple messages.");`
`156`	`156`	`} else if (statusRateLimited) {`
`157`	`157`	`log.warn("Skipping final status update due to prior 429; posting final chunks as new messages", {`
`158`	`158`	`channelId,`
`@@ -163,13 +163,13 @@ export function createCoreRuntime(deps: RuntimeDeps) {`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`for (const chunk of finalChunks) {`
`166`		`- await runtimeDeps.im.sendMessage(channelId, threadId, chunk, true);`
	`166`	`+ await runtimeDeps.im.sendMessage(channelId, threadId, chunk);`
`167`	`167`	`}`
`168`	`168`	`return;`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`if (statusFormat === "aggressive") {`
`172`		`- await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk, true);`
	`172`	`+ await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk);`
`173`	`173`	`return;`
`174`	`174`	`}`
`175`	`175`
`@@ -180,18 +180,18 @@ export function createCoreRuntime(deps: RuntimeDeps) {`
`180`	`180`	`statusTs,`
`181`	`181`	`...(statusRateLimitError ? { error: statusRateLimitError } : {}),`
`182`	`182`	`});`
`183`		`- await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk, true);`
	`183`	`+ await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk);`
`184`	`184`	`return;`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`const maxEditableMessageChars = runtimeDeps.im.maxEditableMessageChars;`
`188`	`188`	`if (typeof maxEditableMessageChars === "number" && singleChunk.length > maxEditableMessageChars) {`
`189`		`- await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below.", false);`
`190`		`- await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk, true);`
	`189`	`+ await runtimeDeps.im.updateMessage(channelId, statusTs, "Final result posted below.");`
	`190`	`+ await runtimeDeps.im.sendMessage(channelId, threadId, singleChunk);`
`191`	`191`	`return;`
`192`	`192`	`}`
`193`	`193`
`194`		`- await runtimeDeps.im.updateMessage(channelId, statusTs, singleChunk, true);`
	`194`	`+ await runtimeDeps.im.updateMessage(channelId, statusTs, singleChunk);`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`async function handleUserMessageInternal(context: CoreMessageContext, text: string): Promise<void> {`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ export async function runTrackedRequest(`
`159`	`159`	`liveParsedState.delete(getStatusMessageKey(request));`
`160`	`160`
`161`	`161`	const errorStatus = `Error: ${message}\n_${suggestion}_`;
`162`		`- await deps.im.updateMessage(request.channelId, request.statusMessageTs, errorStatus, false);`
	`162`	`+ await deps.im.updateMessage(request.channelId, request.statusMessageTs, errorStatus);`
`163`	`163`	`onFail(message);`
`164`	`164`	`return { responses: null };`
`165`	`165`	`}`