Merge pull request #71 from odefun/feat/optional-github-token-1770588

Make GitHub token optional in Slack modal

Author: LIU9293

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ode",
-  "version": "0.0.43",
+  "version": "0.0.44",
   "description": "Ode - OpenCode chat controller for Slack",
   "module": "packages/core/index.ts",
   "type": "module",

packages/config/local/ode.ts

@@ -441,7 +441,7 @@ export function getChannelDetails(channelId: string): ChannelDetail | null {
 }
 
 export type GitHubInfo = {
-  token: string;
+  token?: string;
   gitName?: string;
   gitEmail?: string;
 };
@@ -454,11 +454,15 @@ export type UserGeneralSettings = {
 export function getGitHubInfoForUser(userId: string): GitHubInfo | null {
   const info = loadOdeConfig().githubInfos?.[userId];
   if (!info) return null;
-  const token = info.token?.trim();
-  if (!token) return null;
-  const gitName = info.gitName?.trim() || undefined;
-  const gitEmail = info.gitEmail?.trim() || undefined;
-  return { token, gitName, gitEmail };
+  const token = info.token?.trim() || "";
+  const gitName = info.gitName?.trim() || "";
+  const gitEmail = info.gitEmail?.trim() || "";
+  if (!token && !gitName && !gitEmail) return null;
+  return {
+    token: token || undefined,
+    gitName: gitName || undefined,
+    gitEmail: gitEmail || undefined,
+  };
 }
 
 export function getUserGeneralSettings(): UserGeneralSettings {
@@ -487,14 +491,16 @@ export function setUserGeneralSettings(settings: UserGeneralSettings): void {
 export function setGitHubInfoForUser(userId: string, info: GitHubInfo): void {
   const config = loadOdeConfig();
   const githubInfos = { ...(config.githubInfos ?? {}) };
-  const token = info.token.trim();
-  if (token.length === 0) {
+  const token = info.token?.trim() || "";
+  const gitName = info.gitName?.trim() || "";
+  const gitEmail = info.gitEmail?.trim() || "";
+  if (!token && !gitName && !gitEmail) {
     delete githubInfos[userId];
   } else {
     githubInfos[userId] = {
       token,
-      gitName: info.gitName?.trim() || "",
-      gitEmail: info.gitEmail?.trim() || "",
+      gitName,
+      gitEmail,
     };
   }
   saveOdeConfig({ ...config, githubInfos });

packages/ims/slack/commands.ts

@@ -257,8 +257,8 @@ function buildGitHubTokenModal(params: {
 }) {
   const { channelId, hasToken, token, gitName, gitEmail } = params;
   const statusText = hasToken
-    ? "A GitHub token is already set for your account. Submit a new value to update it."
-    : "Set a GitHub token to enable GitHub CLI actions and git identity.";
+    ? "A GitHub token is already set for your account. Update it if needed; git name/email are used for commits."
+    : "GitHub token is optional and only needed for GitHub CLI actions. Git name/email are used for commits.";
 
   return {
     type: "modal" as const,
@@ -276,6 +276,7 @@ function buildGitHubTokenModal(params: {
         type: "input" as const,
         block_id: GITHUB_TOKEN_BLOCK,
         label: { type: "plain_text" as const, text: "GitHub Token" },
+        optional: true,
         element: {
           type: "plain_text_input" as const,
           action_id: GITHUB_TOKEN_ACTION,
@@ -638,16 +639,6 @@ export function setupInteractiveHandlers(): void {
     const gitName = values?.[GITHUB_NAME_BLOCK]?.[GITHUB_NAME_ACTION]?.value || "";
     const gitEmail = values?.[GITHUB_EMAIL_BLOCK]?.[GITHUB_EMAIL_ACTION]?.value || "";
     const trimmed = token.trim();
-    const errors: Record<string, string> = {};
-
-    if (!trimmed) {
-      errors[GITHUB_TOKEN_BLOCK] = "Enter a GitHub token.";
-    }
-
-    if (Object.keys(errors).length > 0) {
-      await ack({ response_action: "errors", errors });
-      return;
-    }
 
     await ack();