refactor: extract Slack and Lark settings launchers

Joshua Chittick · Joshua Chittick · commit 636a2d290dea · 2026-02-24T12:12:49.000Z
diff --git a/packages/ims/lark/client.ts b/packages/ims/lark/client.ts
@@ -6,8 +6,6 @@ import {
   getGitHubInfoForUser,
   getLarkAppCredentials,
   getLarkTargetChannels,
-  getWebHost,
-  getWebPort,
   getWorkspaces,
 } from "@/config";
 import { isThreadActive, markThreadActive } from "@/config/local/settings";
@@ -24,6 +22,7 @@ import { executeIncomingFlow } from "@/ims/shared/incoming-executor";
 import { buildIncomingContext } from "@/ims/shared/incoming-normalizer";
 import { parseIncomingCommand } from "@/ims/shared/command-router";
 import { createRuntimeController } from "@/ims/shared/runtime-controller";
+import { sendLarkSettingsCard } from "./settings";
 
 let larkRuntimeStarted = false;
 
@@ -223,10 +222,6 @@ function parseLarkText(content: string | undefined): string {
   }
 }
 
-function getLocalSettingsUrl(): string {
-  return `http://${getWebHost()}:${getWebPort()}/`;
-}
-
 async function buildLarkContext(
   channelId: string,
   threadId: string,
@@ -263,71 +258,19 @@ async function sendMessage(
 }
 
 async function sendSettingsCard(channelId: string, threadId: string): Promise<string | undefined> {
-  const settingsUrl = getLocalSettingsUrl();
-  logLarkEvent("Lark settings UI launcher triggered", {
+  return sendLarkSettingsCard({
     channelId,
     threadId,
-    settingsUrl,
+    sendInteractive: (card) =>
+      sendLarkMessage({
+        channelId,
+        threadId,
+        msgType: "interactive",
+        content: card,
+      }),
+    sendText: (text) => sendMessage(channelId, threadId, text, true),
+    logEvent: logLarkEvent,
   });
-  const card = {
-    config: {
-      wide_screen_mode: true,
-    },
-    header: {
-      template: "blue",
-      title: {
-        tag: "plain_text",
-        content: "Ode Settings",
-      },
-    },
-    elements: [
-      {
-        tag: "markdown",
-        content: `Configure this chat in the local settings UI.\\n\\nChannel: \`${channelId}\``,
-      },
-      {
-        tag: "action",
-        actions: [
-          {
-            tag: "button",
-            text: {
-              tag: "plain_text",
-              content: "Open Local Setting",
-            },
-            type: "primary",
-            url: settingsUrl,
-          },
-        ],
-      },
-    ],
-  };
-
-  try {
-    const messageId = await sendLarkMessage({
-      channelId,
-      threadId,
-      msgType: "interactive",
-      content: card as unknown as Record<string, unknown>,
-    });
-    logLarkEvent("Lark settings card sent", {
-      channelId,
-      threadId,
-      messageId: messageId ?? "",
-    });
-    return messageId;
-  } catch {
-    logLarkEvent("Lark settings card failed, sending fallback text", {
-      channelId,
-      threadId,
-    });
-    const fallbackText = [
-      "Ode settings",
-      `Open: ${settingsUrl}`,
-      `Channel: ${channelId}`,
-      "Use this channel in Local Setting to configure provider/model/directory.",
-    ].join("\n");
-    return sendMessage(channelId, threadId, fallbackText, true);
-  }
 }
 
 async function updateMessage(
diff --git a/packages/ims/lark/settings.ts b/packages/ims/lark/settings.ts
@@ -0,0 +1,76 @@
+import { getWebHost, getWebPort } from "@/config";
+
+function getLocalSettingsUrl(): string {
+  return `http://${getWebHost()}:${getWebPort()}/`;
+}
+
+export async function sendLarkSettingsCard(params: {
+  channelId: string;
+  threadId: string;
+  sendInteractive: (card: Record<string, unknown>) => Promise<string | undefined>;
+  sendText: (text: string) => Promise<string | undefined>;
+  logEvent: (message: string, payload: Record<string, unknown>) => void;
+}): Promise<string | undefined> {
+  const { channelId, threadId, sendInteractive, sendText, logEvent } = params;
+  const settingsUrl = getLocalSettingsUrl();
+  logEvent("Lark settings UI launcher triggered", {
+    channelId,
+    threadId,
+    settingsUrl,
+  });
+
+  const card = {
+    config: {
+      wide_screen_mode: true,
+    },
+    header: {
+      template: "blue",
+      title: {
+        tag: "plain_text",
+        content: "Ode Settings",
+      },
+    },
+    elements: [
+      {
+        tag: "markdown",
+        content: `Configure this chat in the local settings UI.\n\nChannel: \`${channelId}\``,
+      },
+      {
+        tag: "action",
+        actions: [
+          {
+            tag: "button",
+            text: {
+              tag: "plain_text",
+              content: "Open Local Setting",
+            },
+            type: "primary",
+            url: settingsUrl,
+          },
+        ],
+      },
+    ],
+  };
+
+  try {
+    const messageId = await sendInteractive(card as unknown as Record<string, unknown>);
+    logEvent("Lark settings card sent", {
+      channelId,
+      threadId,
+      messageId: messageId ?? "",
+    });
+    return messageId;
+  } catch {
+    logEvent("Lark settings card failed, sending fallback text", {
+      channelId,
+      threadId,
+    });
+    const fallbackText = [
+      "Ode settings",
+      `Open: ${settingsUrl}`,
+      `Channel: ${channelId}`,
+      "Use this channel in Local Setting to configure provider/model/directory.",
+    ].join("\n");
+    return sendText(fallbackText);
+  }
+}
diff --git a/packages/ims/slack/client.ts b/packages/ims/slack/client.ts
@@ -1,19 +1,13 @@
 import { App } from "@slack/bolt";
 import { WebClient } from "@slack/web-api";
-import { existsSync } from "fs";
 import { join } from "path";
 import {
   getSlackTargetChannels,
   getSlackBotTokens,
   invalidateOdeConfigCache,
   getChannelAgentProvider,
-  getChannelModel,
-  getOpenCodeModels,
-  getKiloModels,
-  isAgentEnabled,
   getGitHubInfoForUser,
   getChannelSystemMessage,
-  resolveChannelCwd,
 } from "@/config";
 import { markdownToSlack, splitForSlack, truncateForSlack } from "./formatter";
 import {
@@ -31,6 +25,7 @@ import { getSlackActionApiUrl } from "./config";
 import { fetchThreadHistoryByClient } from "./message-history";
 import { registerSlackMessageRouter } from "./message-router";
 import { syncSlackWorkspace } from "@/core/web/local-settings";
+import { describeSlackSettingsIssues, postSlackGeneralSettingsLauncher } from "./settings";
 
 export interface MessageContext {
   channelId: string;
@@ -200,95 +195,6 @@ function truncateToken(token: string): string {
   return `${token.slice(0, 6)}...${token.slice(-4)}`;
 }
 
-function describeSettingsIssues(channelId: string): string[] {
-  const issues: string[] = [];
-  const provider = getChannelAgentProvider(channelId);
-  const model = getChannelModel(channelId);
-  const { workingDirectory } = resolveChannelCwd(channelId);
-  const normalizeModel = (value: string) => value.trim().toLowerCase();
-
-  if (!isAgentEnabled(provider)) {
-    issues.push(`Agent not enabled: ${provider}`);
-  }
-
-  if (provider === "opencode") {
-    const models = getOpenCodeModels();
-    const modelSet = new Set(models.map(normalizeModel));
-    if (!model) {
-      issues.push("Model not configured.");
-    } else if (!modelSet.has(normalizeModel(model))) {
-      issues.push("Model not available in configured OpenCode models.");
-    }
-  } else if (provider === "kilo") {
-    const models = getKiloModels();
-    const modelSet = new Set(models.map(normalizeModel));
-    if (!model) {
-      issues.push("Model not configured.");
-    } else if (!modelSet.has(normalizeModel(model))) {
-      issues.push("Model not available in configured Kilo models.");
-    }
-  }
-
-  if (!workingDirectory) {
-    issues.push("Working directory not configured.");
-  } else if (!existsSync(workingDirectory)) {
-    issues.push(`Working directory not found: ${workingDirectory}`);
-  }
-
-  return issues;
-}
-
-type SettingsLauncherButton = {
-  actionId: string;
-  label: string;
-};
-
-function buildSettingsLauncherBlocks(
-  channelId: string,
-  description: string,
-  buttons: SettingsLauncherButton[]
-): any[] {
-  return [
-    {
-      type: "section",
-      text: {
-        type: "mrkdwn",
-        text: description,
-      },
-    },
-    {
-      type: "actions",
-      elements: buttons.map((button) => ({
-        type: "button",
-        action_id: button.actionId,
-        text: { type: "plain_text", text: button.label },
-        value: channelId,
-      })),
-    },
-  ];
-}
-
-async function postGeneralSettingsLauncher(
-  channelId: string,
-  userId: string,
-  client: WebClient
-): Promise<void> {
-  await client.chat.postEphemeral({
-    channel: channelId,
-    user: userId,
-    text: "Open settings",
-    blocks: buildSettingsLauncherBlocks(
-      channelId,
-      "Choose which settings page to open.",
-      [
-        { actionId: "open_general_settings_modal", label: "general setting" },
-        { actionId: "open_settings_modal", label: "channel setting" },
-        { actionId: "open_github_token_modal", label: "github info" },
-      ]
-    ),
-  });
-}
-
 async function syncWorkspaceAfterMention(
   channelId: string,
   workspace: { workspaceId?: string; workspaceName?: string } | undefined
@@ -577,8 +483,8 @@ export function setupMessageHandlers(): void {
       },
       isThreadActive,
       markThreadActive,
-      postGeneralSettingsLauncher,
-      describeSettingsIssues,
+      postGeneralSettingsLauncher: postSlackGeneralSettingsLauncher,
+      describeSettingsIssues: describeSlackSettingsIssues,
       getChannelAgentProvider,
       handleStopCommand: (channelId, threadId) => coreRuntime.handleStopCommand(channelId, threadId),
       handleIncomingMessage: (context, text) => coreRuntime.handleIncomingMessage(context, text),
diff --git a/packages/ims/slack/settings.ts b/packages/ims/slack/settings.ts
