🐛 bugfix: Wrong password (ITISFoundation#3296)

Author: odeimaiz

services/web/client/source/class/osparc/auth/Manager.js

@@ -152,8 +152,18 @@ qx.Class.define("osparc.auth.Manager", {
               loginCbk.call(context, resp.data);
             })
             .catch(err => failCbk.call(context, err.message));
+        } else {
+          const resp = JSON.parse(xhr.responseText);
+          if ("error" in resp && resp["error"]) {
+            failCbk.call(context, resp["error"]["message"]);
+          } else {
+            failCbk.call(context, this.tr("Login failed"));
+          }
         }
       };
+      xhr.onerror = () => {
+        failCbk.call(context, this.tr("Login failed"));
+      };
       xhr.open("POST", url, true);
       xhr.setRequestHeader("Content-Type", "application/json");
       xhr.send(JSON.stringify(params));

services/web/client/source/class/osparc/component/tutorial/ti/Slides.js

@@ -33,6 +33,9 @@ qx.Class.define("osparc.component.tutorial.ti.Slides", {
       resizable: false
     });
 
+    const closeBtn = this.getChildControl("close-button");
+    osparc.utils.Utils.setIdToWidget(closeBtn, "quickStartWindowCloseBtn");
+
     const arrowsLayout = this.__createArrows();
     this.add(arrowsLayout);
 
@@ -138,6 +141,7 @@ qx.Class.define("osparc.component.tutorial.ti.Slides", {
 
       const text1 = "<a href=https://www.youtube.com/watch?v=dQw4w9WgXcQ style='color: white' target='_blank'>Youtube video</a>";
       const link1 = new qx.ui.basic.Label(text1).set({
+        visibility: "excluded", // remove this when the video is available
         allowGrowX: true,
         textAlign: "center",
         rich : true
@@ -164,7 +168,7 @@ qx.Class.define("osparc.component.tutorial.ti.Slides", {
         flex: 1
       });
 
-      const text3 = "<a href=https://itis.swiss/meta-navigation/privacy-policy/ style='color: white' target='_blank'>License</a>";
+      const text3 = "<a href=https://itis.swiss/meta-navigation/privacy-policy/ style='color: white' target='_blank'>Privacy Policy</a>";
       const link3 = new qx.ui.basic.Label(text3).set({
         allowGrowX: true,
         textAlign: "center",

services/web/client/source/class/osparc/dashboard/ResourceBrowserBase.js

@@ -209,7 +209,10 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
 
           if (osparc.utils.Utils.isProduct("tis")) {
             const dontShow = osparc.utils.Utils.localCache.getLocalStorageItem("tiDontShowQuickStart");
-            if (dontShow !== "true" && templates === false && resources.length === 0 && this._resourcesContainer.nextRequest === null) {
+            if (dontShow === "true") {
+              return;
+            }
+            if (templates === false && resources.length === 0 && this._resourcesContainer.nextRequest === null) {
               // there are no studies
               const tutorialWindow = new osparc.component.tutorial.ti.Slides();
               tutorialWindow.center();

services/web/client/source/resource/osparc/ti_splitimage.png

@@ -21,6 +21,9 @@ async function runTutorial() {
   try {
     await tutorial.start();
 
+    await utils.sleep(2000, "Wait for Quick Start dialog");
+    await tutorial.closeQuickStart();
+
     // check that the "New Study" is "New Plan"
     await tutorial.checkFirstStudyId("newPlanButton");
 

tests/e2e/tutorials/ti-plan.js

@@ -117,6 +117,12 @@ class TutorialBase {
     }
   }
 
+  async closeQuickStart() {
+    await this.takeScreenshot("preCloseQuickStart");
+    await auto.closeQuickStart(this.__page);
+    await this.takeScreenshot("postCloseQuickStart");
+  }
+
   async registerIfNeeded() {
     if (this.__newUser) {
       await auto.register(this.__page, this.__user, this.__pass);

tests/e2e/tutorials/tutorialBase.js

@@ -11,6 +11,15 @@ async function acceptCookies(page) {
     .catch(() => console.log("Accept Cookies button not found"));
 }
 
+async function closeQuickStart(page) {
+  const id = '[osparc-test-id=quickStartWindowCloseBtn]';
+  await page.waitForSelector(id, {
+    timeout: 5000
+  })
+    .then(() => page.click(id))
+    .catch(() => console.log("Quick Start window not found"));
+}
+
 async function register(page, user, pass) {
   await utils.waitAndClick(page, '[osparc-test-id="loginCreateAccountBtn"]');
 
@@ -357,6 +366,7 @@ async function downloadSelectedFile(page) {
 
 module.exports = {
   acceptCookies,
+  closeQuickStart,
   register,
   logIn,
   logOut,