Skip to content

Commit 3b58ce7

Browse files
authored
πŸ› fixing push to docker hub (ITISFoundation#2469)
1 parent 0a4fc0f commit 3b58ce7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

β€ŽMakefileβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,6 @@ push-latest: tag-latest
309309
@export DOCKER_IMAGE_TAG=latest; \
310310
$(MAKE) push-version
311311

312-
# NOTE: docker-compose only pushes images with a 'build' section.
313-
# TODO: change to docker-compose push when make config-version available
314312
push-version: tag-version
315313
# pushing '${DOCKER_REGISTRY}/{service}:${DOCKER_IMAGE_TAG}'
316314
@docker-compose --file services/docker-compose-build.yml --file services/docker-compose-deploy.yml push

β€Žci/deploy/dockerhub-deploy.bashβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ make info-images
2929

3030
# re-tag build
3131
DOCKER_IMAGE_TAG="$TAG_PREFIX-latest"
32+
BUILD_TARGET="undefined" # this gets overwritten but is required when merging yaml files
3233
export DOCKER_IMAGE_TAG
34+
export BUILD_TARGET
3335
log_info "pushing images ${DOCKER_IMAGE_TAG} to ${DOCKER_REGISTRY}"
3436
make push-version
3537

0 commit comments

Comments
Β (0)