fix possible issues

Author: sanderegg

packages/simcore-sdk/src/simcore_sdk/node_ports_common/data_items_utils.py

@@ -16,8 +16,8 @@ def create_simcore_file_id(
     s3_file_name = file_path.name
     if file_base_path:
         s3_file_name = f"{file_base_path / file_path.name}"
-
-    return SimcoreS3FileID(f"{project_id}/{node_id}/{s3_file_name}")
+    clean_path = Path(f"{project_id}/{node_id}/{s3_file_name}")
+    return SimcoreS3FileID(f"{clean_path}")
 
 
 _INTERNAL_DIR = Path(tempfile.gettempdir(), "simcorefiles")

packages/simcore-sdk/tests/unit/test_node_ports_common_data_items_utils.py

@@ -37,7 +37,7 @@ class _SimcoreFileIDParam:
             node_id="cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e",
             file_base_path=Path("/another/path"),
             expected_simcore_file_id=SimcoreS3FileID(
-                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/path.ext"
+                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/another/path/path.ext"
             ),
         ),
         _SimcoreFileIDParam(
@@ -46,7 +46,7 @@ class _SimcoreFileIDParam:
             node_id="cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e",
             file_base_path=Path("/some/random"),
             expected_simcore_file_id=SimcoreS3FileID(
-                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/file/path.ext"
+                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/some/random/path.ext"
             ),
         ),
         _SimcoreFileIDParam(
@@ -55,7 +55,7 @@ class _SimcoreFileIDParam:
             node_id="cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e",
             file_base_path=Path("/some/random/"),
             expected_simcore_file_id=SimcoreS3FileID(
-                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/file/path.ext"
+                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/some/random/path.ext"
             ),
         ),
         _SimcoreFileIDParam(
@@ -64,7 +64,7 @@ class _SimcoreFileIDParam:
             node_id="cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e",
             file_base_path=Path("/some"),
             expected_simcore_file_id=SimcoreS3FileID(
-                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/random/file/path.ext"
+                "2c471fb7-af17-408b-bcf4-91d419d0d20e/cd38bee6-9d4d-48e5-a8d5-98d7e049aa5e/some/path.ext"
             ),
         ),
     ],