Skip to content

Commit 45ae7a5

Browse files
GitHKAndrei Neagumergify[bot]
authored
šŸ› Permission changes in dynamic-sidecar are always executed when closing a service (ITISFoundation#7372)
Co-authored-by: Andrei Neagu <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 5aed474 commit 45ae7a5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ā€Žservices/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks.pyā€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,8 +315,9 @@ async def _send_resource_tracking_stop(platform_status: SimcorePlatformStatus):
315315
# NOTE: https://github.com/ITISFoundation/osparc-simcore/issues/4952
316316
await _send_resource_tracking_stop(SimcorePlatformStatus.OK)
317317
raise
318-
319-
await ensure_read_permissions_on_user_service_data(mounted_volumes)
318+
finally:
319+
with log_context(_logger, logging.INFO, "ensure read permissions"):
320+
await ensure_read_permissions_on_user_service_data(mounted_volumes)
320321

321322
await _send_resource_tracking_stop(SimcorePlatformStatus.OK)
322323

0 commit comments

Comments
Ā (0)