🐛 Fixes dask-sidecar in devel-mode and test teardown (ITISFoundation#2401)

* fixes Dockerfile healtcheck in devel mode

* Ignores docker stack remove failure

* removes health-checks

Author: pcrespov

packages/pytest-simcore/src/pytest_simcore/docker_swarm.py

@@ -165,9 +165,23 @@ def docker_stack(
     # make down
     # NOTE: remove them in reverse order since stacks share common networks
     WAIT_BEFORE_RETRY_SECS = 1
+
+    HEADER = "{:-^20}"
     stacks.reverse()
     for _, stack, _ in stacks:
-        subprocess.run(f"docker stack remove {stack}", shell=True, check=True)
+
+        try:
+            subprocess.run(f"docker stack remove {stack}", shell=True, check=True)
+        except subprocess.CalledProcessError as err:
+            log.warning(
+                "Ignoring failure while executing '%s' (returned code %d):\n%s\n%s\n%s\n%s\n",
+                err.cmd,
+                err.returncode,
+                HEADER.format("stdout"),
+                err.stdout,
+                HEADER.format("stderr"),
+                err.stderr,
+            )
 
         while docker_client.services.list(
             filters={"label": f"com.docker.stack.namespace={stack}"}

services/dask-sidecar/Dockerfile

@@ -151,13 +151,7 @@ ENV SC_BUILD_TARGET=development
 WORKDIR /devel
 RUN chown -R scu:scu "${VIRTUAL_ENV}"
 
-
-HEALTHCHECK \
-  --interval=60s \
-  --timeout=60s \
-  --start-period=10s \
-  --retries=3 \
-  CMD ["echo", , "Fake healthcheck because it takes very long to boot in devel mode"]
+# NOTE: devel mode does NOT have HEALTHCHECK
 
 ENTRYPOINT [ "/bin/sh", "services/dask-sidecar/docker/entrypoint.sh" ]
 CMD ["/bin/sh", "services/dask-sidecar/docker/boot.sh"]

services/sidecar/Dockerfile

@@ -140,12 +140,7 @@ ENV SC_BUILD_TARGET=development
 WORKDIR /devel
 RUN chown -R scu:scu "${VIRTUAL_ENV}"
 
-# we use the celery API
-HEALTHCHECK --interval=60s \
-  --timeout=60s \
-  --start-period=120s \
-  --retries=3 \
-  CMD celery inspect ping -b amqp://${RABBIT_USER}:${RABBIT_PASSWORD}@${RABBIT_HOST}:${RABBIT_PORT} -d sidecar."$(cat ${SIDECAR_HOST_HOSTNAME_PATH})"@${HOSTNAME}
+# NOTE: devel mode does NOT have HEALTHCHECK
 
 ENTRYPOINT [ "/bin/sh", "services/sidecar/docker/entrypoint.sh" ]
 CMD ["/bin/sh", "services/sidecar/docker/boot.sh"]