✨ is3453/fail boot if invalid product setup (ITISFoundation#3455)

Author: pcrespov

packages/service-library/src/servicelib/exceptions.py

@@ -0,0 +1,4 @@
+class InvalidConfig(ValueError):
+    # NOTE: If your service can’t load the config on startup for any reason, it should just crash
+    # SEE https://www.willett.io/posts/precepts/
+    pass

services/web/server/src/simcore_service_webserver/products_events.py

@@ -5,6 +5,7 @@
 from aiohttp import web
 from aiopg.sa.engine import Engine
 from pydantic import ValidationError
+from servicelib.exceptions import InvalidConfig
 
 from ._constants import APP_DB_ENGINE_KEY, APP_PRODUCTS_KEY
 from .products_db import Product, iter_products
@@ -46,9 +47,9 @@ async def load_products_on_startup(app: web.Application):
                 log.warning("There is not front-end registered for this product")
 
         except ValidationError as err:
-            log.error(
-                "Invalid product in db '%s'. Skipping product info:\n %s", row, err
-            )
+            raise InvalidConfig(
+                f"Invalid product configuration in db '{row}':\n {err}"
+            ) from err
 
     if FRONTEND_APP_DEFAULT not in app_products.keys():
         log.warning("Default front-end app is not in the products table")