Skip to content

Commit 6378de5

Browse files
authored
πŸ› Minor bug fixes (ITISFoundation#3163)
1 parent fad2dbe commit 6378de5

File tree

5 files changed

+33
-16
lines changed

5 files changed

+33
-16
lines changed

β€Žservices/web/client/source/class/osparc/component/widget/logger/LoggerTable.jsβ€Ž

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*
2727
* <pre class='javascript'>
2828
* let tableModel = this.__logModel = new osparc.component.widget.logger.LoggerTable();
29-
* tableModel.setColumns(["Origin", "Timestamp", "Message"], ["whoRich", "whatRich", "whatRich"]);
29+
* tableModel.setColumns(["Timestamp", "Origin", "Message"], ["timeRich", "whoRich", "whatRich"]);
3030
* let custom = {
3131
* tableColumnModel : function(obj) {
3232
* return new qx.ui.table.columnmodel.Resize(obj);
@@ -49,12 +49,12 @@ qx.Class.define("osparc.component.widget.logger.LoggerTable", {
4949
this.base(arguments);
5050

5151
this.setColumns([
52-
"Origin",
5352
"Time",
53+
"Origin",
5454
"Message"
5555
], [
56-
"whoRich",
5756
"timeRich",
57+
"whoRich",
5858
"msgRich"
5959
]);
6060

@@ -137,8 +137,8 @@ qx.Class.define("osparc.component.widget.logger.LoggerTable", {
137137
newRow["nodeColor"] = this.__getNodesColor(newRow.nodeId);
138138
newRow["msgColor"] = this.self().getLevelColor(newRow.logLevel);
139139

140-
newRow["whoRich"] = this.self().addColorTag(newRow.label, newRow.nodeColor);
141140
newRow["timeRich"] = this.self().addColorTag(osparc.utils.Utils.formatTime(newRow.timeStamp, true), newRow.msgColor);
141+
newRow["whoRich"] = this.self().addColorTag(newRow.label, newRow.nodeColor);
142142
newRow["msgRich"] = this.self().addColorTag(newRow.msg, newRow.msgColor);
143143

144144
this.__rawData.push(newRow);
@@ -161,8 +161,8 @@ qx.Class.define("osparc.component.widget.logger.LoggerTable", {
161161
row["nodeColor"] = this.__getNodesColor(row.nodeId);
162162
row["msgColor"] = this.self().getLevelColor(row.logLevel);
163163

164-
row["whoRich"] = this.self().addColorTag(row.label, row.nodeColor);
165164
row["timeRich"] = this.self().addColorTag(osparc.utils.Utils.formatTime(row.timeStamp, true), row.msgColor);
165+
row["whoRich"] = this.self().addColorTag(row.label, row.nodeColor);
166166
row["msgRich"] = this.self().addColorTag(row.msg, row.msgColor);
167167
});
168168
},

β€Žservices/web/client/source/class/osparc/component/widget/logger/LoggerView.jsβ€Ž

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ qx.Class.define("osparc.component.widget.logger.LoggerView", {
8282

8383
statics: {
8484
POS: {
85-
ORIGIN: 0,
86-
TIMESTAMP: 1,
85+
TIMESTAMP: 0,
86+
ORIGIN: 1,
8787
MESSAGE: 2
8888
},
8989

@@ -92,6 +92,14 @@ qx.Class.define("osparc.component.widget.logger.LoggerView", {
9292
info: 0,
9393
warning: 1,
9494
error: 2
95+
},
96+
97+
logLevel2Str: function(logLevel) {
98+
const pairFound = Object.entries(this.LOG_LEVELS).find(pair => pair[1] === logLevel);
99+
if (pairFound && pairFound.length) {
100+
return pairFound[0].toUpperCase();
101+
}
102+
return undefined;
95103
}
96104
},
97105

@@ -243,16 +251,16 @@ qx.Class.define("osparc.component.widget.logger.LoggerView", {
243251
});
244252
osparc.utils.Utils.setIdToWidget(table, "logsViewer");
245253
const colModel = table.getTableColumnModel();
246-
colModel.setDataCellRenderer(this.self().POS.ORIGIN, new qx.ui.table.cellrenderer.Html());
247254
colModel.setDataCellRenderer(this.self().POS.TIMESTAMP, new osparc.ui.table.cellrenderer.Html().set({
248255
defaultCellStyle: "user-select: text"
249256
}));
257+
colModel.setDataCellRenderer(this.self().POS.ORIGIN, new qx.ui.table.cellrenderer.Html());
250258
colModel.setDataCellRenderer(this.self().POS.MESSAGE, new osparc.ui.table.cellrenderer.Html().set({
251259
defaultCellStyle: "user-select: text"
252260
}));
253261
let resizeBehavior = colModel.getBehavior();
254-
resizeBehavior.setWidth(this.self().POS.ORIGIN, 100);
255262
resizeBehavior.setWidth(this.self().POS.TIMESTAMP, 80);
263+
resizeBehavior.setWidth(this.self().POS.ORIGIN, 100);
256264

257265
this.__applyFilters();
258266

@@ -280,7 +288,7 @@ qx.Class.define("osparc.component.widget.logger.LoggerView", {
280288
__getLogsString: function() {
281289
let logs = "";
282290
this.__loggerModel.getRows().forEach(row => {
283-
logs += `(${row.nodeId}) - [${row.timeStamp}] ${row.label}: ${row.msg} \n`;
291+
logs += `${row.timeStamp} ${this.self().logLevel2Str(row.logLevel)} ${row.nodeId} ${row.label}: ${row.msg} \n`;
284292
});
285293
return logs;
286294
},
@@ -291,7 +299,7 @@ qx.Class.define("osparc.component.widget.logger.LoggerView", {
291299

292300
__downloadLogs: function() {
293301
const logs = this.__getLogsString();
294-
osparc.utils.Utils.downloadContent("data:text/json;charset=utf-8," + logs, "logs.json");
302+
osparc.utils.Utils.downloadContent("data:text/plain;charset=utf-8," + logs, "logs.log");
295303
},
296304

297305
debug: function(nodeId, msg = "") {
@@ -337,9 +345,9 @@ qx.Class.define("osparc.component.widget.logger.LoggerView", {
337345
const msgLogs = [];
338346
msgs.forEach(msg => {
339347
const msgLog = {
348+
timeStamp: new Date(),
340349
nodeId,
341350
label,
342-
timeStamp: new Date(),
343351
msg,
344352
tooltip: msg,
345353
logLevel

β€Žservices/web/client/source/class/osparc/dashboard/ListButtonItem.jsβ€Ž

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,17 @@ qx.Class.define("osparc.dashboard.ListButtonItem", {
122122
column: osparc.dashboard.ListButtonBase.POS.UI_MODE
123123
});
124124
break;
125+
case "hits-service": {
126+
control = new qx.ui.basic.Label().set({
127+
alignY: "middle",
128+
toolTipText: this.tr("Number of times it was instantiated")
129+
});
130+
this._add(control, {
131+
row: 0,
132+
column: osparc.dashboard.ListButtonBase.POS.HITS
133+
});
134+
break;
135+
}
125136
case "update-study":
126137
control = new qx.ui.basic.Image().set({
127138
minWidth: 20,

β€Žservices/web/client/source/resource/osparc/tip_itis-black.svgβ€Ž

Lines changed: 1 addition & 2 deletions
Loading

β€Žservices/web/client/source/resource/osparc/tip_itis-white.svgβ€Ž

Lines changed: 1 addition & 2 deletions
Loading

0 commit comments

Comments
Β (0)