🎨 improve variable name in invoice data (ITISFoundation#5469)

Author: matusdrobuliak66

packages/models-library/src/models_library/payments.py

@@ -45,7 +45,7 @@ class InvoiceDataGet(BaseModel):
     stripe_price_id: StripePriceID
     stripe_tax_rate_id: StripeTaxRateID
     user_invoice_address: UserInvoiceAddress
-    user_name: str
+    user_display_name: str
     user_email: LowerCaseEmailStr
 
     class Config:
@@ -58,7 +58,7 @@ class Config:
                     "user_invoice_address": UserInvoiceAddress.Config.schema_extra[
                         "examples"
                     ][0],
-                    "user_name": "My Name",
+                    "user_display_name": "My Name",
                     "user_email": LowerCaseEmailStr("[email protected]"),
                 },
             ]

services/payments/src/simcore_service_payments/services/auto_recharge_process_message.py

@@ -163,7 +163,7 @@ async def _perform_auto_recharge(
         wallet_id=rabbit_message.wallet_id,
         wallet_name=f"id={rabbit_message.wallet_id}",
         user_id=payment_method_db.user_id,
-        user_name=invoice_data_get.user_name,
+        user_name=invoice_data_get.user_display_name,
         user_email=invoice_data_get.user_email,
         user_address=invoice_data_get.user_invoice_address,
         stripe_price_id=invoice_data_get.stripe_price_id,

services/web/server/src/simcore_service_webserver/payments/_rpc_invoice.py

@@ -39,7 +39,7 @@ async def get_invoice_data(
         stripe_price_id=product_stripe_info_get.stripe_price_id,
         stripe_tax_rate_id=product_stripe_info_get.stripe_tax_rate_id,
         user_invoice_address=user_invoice_address,
-        user_name=user_info.full_name,
+        user_display_name=user_info.full_name,
         user_email=LowerCaseEmailStr(user_info.email),
     )