🚑️ Dask sidecar must have a unique name, also when re-deploying (ITISFoundation#2641)

Author: sanderegg

packages/pytest-simcore/src/pytest_simcore/rabbit_service.py

@@ -5,6 +5,7 @@
 import asyncio
 import json
 import logging
+import os
 import socket
 from dataclasses import dataclass
 from typing import Any, AsyncIterator, Dict, Iterator, Optional
@@ -87,7 +88,7 @@ def _reconnect_callback():
     # NOTE: to show the connection name in the rabbitMQ UI see there
     # https://www.bountysource.com/issues/89342433-setting-custom-connection-name-via-client_properties-doesn-t-work-when-connecting-using-an-amqp-url
     connection = await aio_pika.connect_robust(
-        rabbit_config.dsn + f"?name={__name__}_{id(socket.gethostname())}",
+        rabbit_config.dsn + f"?name={__name__}_{socket.gethostname()}_{os.getpid()}",
         client_properties={"connection_name": "pytest read connection"},
     )
     assert connection

packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py

@@ -1,5 +1,6 @@
 import json
 import logging
+import os
 import socket
 from typing import Optional
 
@@ -66,7 +67,7 @@ def __init__(self, db_engine: Optional[aiopg.sa.Engine] = None):
     @staticmethod
     async def _create_db_engine() -> aiopg.sa.Engine:
         dsn = DataSourceName(
-            application_name=f"{__name__}_{id(socket.gethostname())}",
+            application_name=f"{__name__}_{socket.gethostname()}_{os.getpid()}",
             database=config.POSTGRES_DB,
             user=config.POSTGRES_USER,
             password=config.POSTGRES_PW,

services/dask-sidecar/docker/boot.sh

@@ -116,7 +116,7 @@ else
       --dashboard-address 8787 \
       --memory-limit "$ram" \
       --resources "$resources" \
-      --name "$(hostname)"
+      --name "dask-sidecar_$(hostname)_$$"
   else
     exec dask-worker "${DASK_SCHEDULER_ADDRESS}" \
       --local-directory /tmp/dask-sidecar \
@@ -128,6 +128,6 @@ else
       --dashboard-address 8787 \
       --memory-limit "$ram" \
       --resources "$resources" \
-      --name "$(hostname)"
+      --name "dask-sidecar_$(hostname)_$$"
   fi
 fi

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/rabbitmq.py

@@ -2,6 +2,7 @@
 
 import asyncio
 import logging
+import os
 import socket
 from asyncio import CancelledError, Queue, Task
 from typing import Any, Dict, List, Optional, Union
@@ -84,7 +85,7 @@ async def connect(self) -> None:
         # NOTE: to show the connection name in the rabbitMQ UI see there [https://www.bountysource.com/issues/89342433-setting-custom-connection-name-via-client_properties-doesn-t-work-when-connecting-using-an-amqp-url]
         hostname = socket.gethostname()
         self._connection = await aio_pika.connect(
-            url + f"?name={__name__}_{id(hostname)}",
+            url + f"?name={__name__}_{id(hostname)}_{os.getpid()}",
             client_properties={
                 "connection_name": f"dynamic-sidecar_{self._node_id} {hostname}"
             },

services/sidecar/src/simcore_service_sidecar/db.py

@@ -2,6 +2,7 @@
 
 """
 import logging
+import os
 import socket
 from typing import Optional
 
@@ -40,7 +41,7 @@ def __init__(self):
 
     async def __aenter__(self):
         dsn = DataSourceName(
-            application_name=f"{__name__}_{id(socket.gethostname())}",
+            application_name=f"{__name__}_{socket.gethostname()}_{os.getpid()}",
             database=POSTGRES_DB,
             user=POSTGRES_USER,
             password=POSTGRES_PW,

services/sidecar/src/simcore_service_sidecar/rabbitmq.py

@@ -1,5 +1,6 @@
 import json
 import logging
+import os
 import socket
 from asyncio import CancelledError
 from typing import Any, Dict, List, Optional, Union
@@ -59,7 +60,7 @@ async def connect(self):
 
         # NOTE: to show the connection name in the rabbitMQ UI see there [https://www.bountysource.com/issues/89342433-setting-custom-connection-name-via-client_properties-doesn-t-work-when-connecting-using-an-amqp-url]
         self._connection = await aio_pika.connect(
-            url + f"?name={__name__}_{id(socket.gethostname())}",
+            url + f"?name={__name__}_{socket.gethostname()}_{os.getpid()}",
             client_properties={"connection_name": "sidecar connection"},
         )
         self._connection.add_close_callback(_close_callback)

services/web/server/src/simcore_service_webserver/computation_subscribe.py

@@ -1,6 +1,7 @@
 import asyncio
 import contextlib
 import logging
+import os
 import socket
 from typing import Any, AsyncIterator, Awaitable, Callable, Dict, List
 
@@ -107,7 +108,8 @@ async def setup_rabbitmq_consumer(app: web.Application) -> AsyncIterator[None]:
     # NOTE: to show the connection name in the rabbitMQ UI see there [https://www.bountysource.com/issues/89342433-setting-custom-connection-name-via-client_properties-doesn-t-work-when-connecting-using-an-amqp-url]
     async def get_connection() -> aio_pika.Connection:
         return await aio_pika.connect_robust(
-            f"{rabbit_broker}" + f"?name={__name__}_{socket.gethostname()}_{id(app)}",
+            f"{rabbit_broker}"
+            + f"?name={__name__}_{socket.gethostname()}_{os.getpid()}",
             client_properties={"connection_name": "webserver read connection"},
         )
 
@@ -147,7 +149,7 @@ async def exchange_consumer(
                     )
                     # Declaring queue
                     queue = await channel.declare_queue(
-                        f"webserver_{socket.gethostname()}_{id(app)}_{exchange_name}",
+                        f"webserver_{exchange_name}_{socket.gethostname()}_{os.getpid()}",
                         exclusive=True,
                         arguments={"x-message-ttl": 60000},
                     )