Fix 3D e2e (ITISFoundation#2601)

* [skip ci] minor cosmetics
* fix 3d tutorials
* users can do slides

Author: odeimaiz

services/web/client/source/class/osparc/component/form/Auto.js

@@ -303,7 +303,7 @@ qx.Class.define("osparc.component.form.Auto", {
             if (qx.lang.Type.isNumber(data)) {
               return String(data);
             }
-            return data;
+            return null;
           }
         },
         { // target2model

services/web/client/source/class/osparc/component/form/renderer/PropFormBase.js

@@ -44,7 +44,7 @@ qx.Class.define("osparc.component.form.renderer.PropFormBase", {
     fl.setColumnFlex(this.self().gridPos.info, 0);
     fl.setColumnAlign(this.self().gridPos.info, "left", "middle");
     fl.setColumnFlex(this.self().gridPos.ctrlField, 1);
-    fl.setColumnMinWidth(this.self().gridPos.ctrlField, 100);
+    fl.setColumnMinWidth(this.self().gridPos.ctrlField, 50);
   },
 
   properties: {

services/web/client/source/class/osparc/component/widget/NodeTreeItem.js

@@ -43,6 +43,10 @@ qx.Class.define("osparc.component.widget.NodeTreeItem", {
   construct: function() {
     this.base(arguments);
 
+    this.set({
+      indent: 8
+    });
+
     this.getContentElement().setStyles({
       "border-radius": "6px"
     });
@@ -175,12 +179,11 @@ qx.Class.define("osparc.component.widget.NodeTreeItem", {
       // The label
       this.addLabel();
       const label = this.getChildControl("label");
-      if (label) {
-        label.setMaxWidth(150);
-      }
-
-      // All else should be right justified
-      this.addWidget(new qx.ui.core.Spacer(), {
+      label.set({
+        allowGrowX: true,
+        allowShrinkX: true
+      });
+      label.setLayoutProperties({
         flex: 1
       });
 

services/web/client/source/class/osparc/dashboard/StudyBrowser.js

@@ -575,14 +575,6 @@ qx.Class.define("osparc.dashboard.StudyBrowser", {
         menu.add(saveAsTemplateButton);
       }
 
-      if (osparc.data.model.Study.hasSlideshow(studyData) && osparc.data.Permissions.getInstance().canDo("study.slides")) {
-        const startAsGuidedModeButton = this.__getStartAsGuidedModeButton(studyData);
-        menu.add(startAsGuidedModeButton);
-
-        const startAsAppButton = this.__getStartAsAppButton(studyData);
-        menu.add(startAsAppButton);
-      }
-
       const deleteButton = this.__getDeleteStudyMenuButton(studyData, false);
       if (deleteButton) {
         menu.addSeparator();
@@ -691,22 +683,6 @@ qx.Class.define("osparc.dashboard.StudyBrowser", {
       return saveAsTemplateButton;
     },
 
-    __getStartAsGuidedModeButton: function(studyData) {
-      const startAsGuidedModeButton = new qx.ui.menu.Button(this.tr("Start Guided mode"));
-      startAsGuidedModeButton.addListener("execute", () => {
-        this._startStudy(studyData, "guided");
-      }, this);
-      return startAsGuidedModeButton;
-    },
-
-    __getStartAsAppButton: function(studyData) {
-      const startAsAppButton = new qx.ui.menu.Button(this.tr("Start App mode"));
-      startAsAppButton.addListener("execute", () => {
-        this._startStudy(studyData, "app");
-      }, this);
-      return startAsAppButton;
-    },
-
     __getDeleteStudyMenuButton: function(studyData) {
       const deleteButton = new qx.ui.menu.Button(this.tr("Delete"));
       osparc.utils.Utils.setIdToWidget(deleteButton, "studyItemMenuDelete");

services/web/client/source/class/osparc/data/Permissions.js

@@ -113,7 +113,8 @@ qx.Class.define("osparc.data.Permissions", {
           "study.edge.create",
           "study.edge.delete",
           "study.classifier",
-          "study.tag"
+          "study.tag",
+          "study.slides"
         ],
         "tester": [
           "studies.template.create.all",
@@ -126,7 +127,6 @@ qx.Class.define("osparc.data.Permissions", {
           "study.nodestree.uuid.read",
           "study.filestree.uuid.read",
           "study.logger.debug.read",
-          "study.slides",
           "statics.read"
         ],
         "admin": []

services/web/client/source/class/osparc/desktop/WorkbenchView.js

@@ -251,7 +251,7 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
 
       const tabViewPrimary = this.getChildControl("side-panel-left-tabs");
       this.__removePages(tabViewPrimary);
-      tabViewPrimary.setBackgroundColor("background-main-lighter+");
+      tabViewPrimary.setBackgroundColor(primaryColumnBGColor);
       const collapsibleViewLeft = this.getChildControl("collapsible-view-left");
       collapsibleViewLeft.getChildControl("expand-button").setBackgroundColor(primaryColumnBGColor);
       collapsibleViewLeft.getChildControl("collapse-button").setBackgroundColor(primaryColumnBGColor);
@@ -748,7 +748,6 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
 
     __populateSecondPanelNode: function(node) {
       this.__settingsPage.getChildControl("button").show();
-      this.__outputsPage.getChildControl("button").show();
       this.getChildControl("side-panel-right-tabs").setSelection([this.__settingsPage]);
 
       if (node.isPropertyInitialized("propsForm") && node.getPropsForm()) {
@@ -759,17 +758,21 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
         });
       }
 
-      const portTree = new osparc.component.widget.inputs.NodeOutputTree(node, node.getMetaData().outputs).set({
-        allowGrowY: false
-      });
-      this.__outputsPage.add(portTree);
+      if (node.hasOutputs()) {
+        this.__outputsPage.getChildControl("button").show();
 
-      const outputFilesBtn = new qx.ui.form.Button(this.tr("Artifacts"), "@FontAwesome5Solid/folder-open/14").set({
-        allowGrowX: false
-      });
-      osparc.utils.Utils.setIdToWidget(outputFilesBtn, "nodeOutputFilesBtn");
-      outputFilesBtn.addListener("execute", () => osparc.component.node.BaseNodeView.openNodeDataManager(node));
-      this.__outputsPage.add(outputFilesBtn);
+        const portTree = new osparc.component.widget.inputs.NodeOutputTree(node, node.getMetaData().outputs).set({
+          allowGrowY: false
+        });
+        this.__outputsPage.add(portTree);
+
+        const outputFilesBtn = new qx.ui.form.Button(this.tr("Artifacts"), "@FontAwesome5Solid/folder-open/14").set({
+          allowGrowX: false
+        });
+        osparc.utils.Utils.setIdToWidget(outputFilesBtn, "nodeOutputFilesBtn");
+        outputFilesBtn.addListener("execute", () => osparc.component.node.BaseNodeView.openNodeDataManager(node));
+        this.__outputsPage.add(outputFilesBtn);
+      }
     },
 
     getLogger: function() {

tests/e2e/portal/3D_Anatomical.js

@@ -29,6 +29,9 @@ async function runTutorial () {
     await tutorial.waitFor(10000, 'Some time for starting the service');
     await utils.takeScreenshot(page, screenshotPrefix + 'service_started');
 
+    // This study opens in fullscreen mode
+    await tutorial.restoreIFrame();
+
     const outFiles = [
       "data.zip"
     ];

tests/e2e/portal/3D_EM.js

@@ -29,6 +29,9 @@ async function runTutorial () {
     await tutorial.waitFor(10000, 'Some time for starting the service');
     await utils.takeScreenshot(page, screenshotPrefix + 'service_started');
 
+    // This study opens in fullscreen mode
+    await tutorial.restoreIFrame();
+
     const outFiles = [
       "data.zip"
     ];