[FIX] point_of_sale: update partner self invoice

When doing a self invoice with the QR code on the PoS receipt, if a
partner was linked to the order, the record would not be updated with
the values entered in the self invoice form.

Steps to reproduce:
-------------------
* Enable the self service invoice feature in the PoS settings.
* Open a PoS session.
* Make and order with a partner set on it.
* Finalize the order and scan the QRCode on the receipt.
* Fill the form with some new informations (like a new VAT number)
> Observation: Check the partner on the backend, the values are not
  updated.

Why the fix:
------------
We update all the mandatory and optionnal fields of the partner
record with the values entered in the self invoice form.

opw-4676244

closes odoo#214552

Signed-off-by: David Monnom (moda) <[email protected]>

Author: robinengels

addons/point_of_sale/controllers/main.py

@@ -225,7 +225,7 @@ def _parse_additional_values(fields, prefix, kwargs):
     def _get_invoice(self, partner_values, invoice_values, pos_order, additional_invoice_fields, kwargs):
         # If the user is not connected, then we will simply create a new partner with the form values.
         # Matching with existing partner was tried, but we then can't update the values, and it would force the user to use the ones from the first invoicing.
-        if request.env.user._is_public() and not pos_order.partner_id.id:
+        if kwargs:
             partner_values.update({key: kwargs[key] for key in self._get_mandatory_fields()})
             partner_values.update({key: kwargs[key] for key in self._get_optional_fields() if key in kwargs})
             for field in {'country_id', 'state_id'} & set(partner_values.keys()):
@@ -234,6 +234,7 @@ def _get_invoice(self, partner_values, invoice_values, pos_order, additional_inv
                 except Exception:
                     partner_values[field] = False
             partner_values.update({'zip': partner_values.pop('zipcode', '')})
+        if request.env.user._is_public() and not pos_order.partner_id.id:
             partner = request.env['res.partner'].sudo().create(partner_values)  # In this case, partner_values contains the whole partner info form.
         # If the user is connected, then we can update if needed its fields with the additional localized fields if any, then proceed.
         else:

addons/point_of_sale/tests/test_pos_controller.py

@@ -108,3 +108,56 @@ def test_qr_code_receipt_user_connected(self):
         res = self.url_open(f'/pos/ticket/validate?access_token={self.pos_order.access_token}', timeout=30000)
         self.assertTrue(self.pos_order.is_invoiced, "The pos order should have an invoice")
         self.assertTrue("my/invoices" in res.url)
+
+    def test_qr_code_receipt_user_updated(self):
+        """This test make sure that when the user is already connected he correctly gets redirected to the invoice."""
+        self.authenticate(None, None)
+        self.partner_1 = self.env['res.partner'].create({
+            'name': 'Valid Lelitre',
+            'email': '[email protected]',
+        })
+
+        self.product1 = self.env['product.product'].create({
+            'name': 'Test Product 1',
+            'is_storable': True,
+            'list_price': 10.0,
+            'taxes_id': False,
+        })
+        self.main_pos_config.open_ui()
+        self.pos_order = self.env['pos.order'].create({
+            'session_id': self.main_pos_config.current_session_id.id,
+            'company_id': self.env.company.id,
+            'partner_id': self.partner_1.id,
+            'access_token': '1234567890',
+            'lines': [(0, 0, {
+                'name': "OL/0001",
+                'product_id': self.product1.id,
+                'price_unit': 10,
+                'discount': 0.0,
+                'qty': 1.0,
+                'tax_ids': False,
+                'price_subtotal': 10,
+                'price_subtotal_incl': 10,
+            })],
+            'amount_tax': 10,
+            'amount_total': 10,
+            'amount_paid': 10.0,
+            'amount_return': 10.0,
+        })
+        self.main_pos_config.current_session_id.close_session_from_ui()
+        get_invoice_data = {
+            'access_token': self.pos_order.access_token,
+            'name': 'New Name',
+            'email': "[email protected]",
+            'vat': 'VAT_TEST_NUMBER_123',
+            'street': "Test street",
+            'city': "Test City",
+            'zipcode': '12345',
+            'country_id': self.company.country_id.id,
+            'phone': "123456789",
+            'csrf_token': odoo.http.Request.csrf_token(self)
+        }
+        self.url_open(f'/pos/ticket/validate?access_token={self.pos_order.access_token}', data=get_invoice_data, timeout=30000)
+        self.assertEqual(self.partner_1.vat, 'VAT_TEST_NUMBER_123')
+        self.assertEqual(self.partner_1.name, 'New Name')
+        self.assertEqual(self.partner_1.zip, '12345')