[FIX] hr_holidays: fix time off balance on kanban cards

In hr_leave kanban cards, the time off balance for that time off type is shown. The amount were incorrectly computed.
This commit fixes the issue by filtering out the expired leave allocations.

Done as part of task-4860260

closes odoo#216690

X-original-commit: a49d34b
Signed-off-by: Yannick Tivisse (yti) <[email protected]>

Author: romaincarlier4

addons/hr_holidays/models/hr_leave.py

@@ -659,9 +659,10 @@ def _compute_leaves(self):
         for leave in self:
             virtual_remaining_leaves = 0
             max_leaves = 0
-            for allocation_dict in employee_days_per_allocation[leave.employee_id][leave.holiday_status_id].values():
-                max_leaves += allocation_dict['max_leaves']
-                virtual_remaining_leaves += allocation_dict['virtual_remaining_leaves']
+            for allocation, allocation_dict in employee_days_per_allocation[leave.employee_id][leave.holiday_status_id].items():
+                if allocation and (not allocation.date_to or allocation.date_to >= date_from):
+                    max_leaves += allocation_dict['max_leaves']
+                    virtual_remaining_leaves += allocation_dict['virtual_remaining_leaves']
             leave.virtual_remaining_leaves = virtual_remaining_leaves
             leave.max_leaves = max_leaves
 

addons/hr_holidays/tests/test_allocations.py

@@ -402,3 +402,53 @@ def test_create_allocation_from_company_with_no_employee_for_current_user(self):
         allocation_form.holiday_status_id = self.leave_type
         allocation = allocation_form.save()
         self.assertTrue(allocation)
+
+    def test_hr_leave_allocation_balance(self):
+        """
+            This test makes sure that the time off balance showed on the time off management kanban card is correct
+        """
+        leave_type = self.env.ref('hr_holidays.leave_type_compensatory_days')
+
+        invalid_allocation = self.env['hr.leave.allocation'].sudo().create({
+            'name': 'Alloc',
+            'employee_id': self.employee.id,
+            'holiday_status_id': leave_type.id,
+            'number_of_days': 5,
+            'allocation_type': 'regular',
+            'date_from': date(2024, 1, 1),
+            'date_to': date(2024, 4, 30)
+        })
+        invalid_allocation.action_approve()
+
+        first_valid_allocation = self.env['hr.leave.allocation'].sudo().create({
+            'name': 'Alloc',
+            'employee_id': self.employee.id,
+            'holiday_status_id': leave_type.id,
+            'number_of_days': 10,
+            'allocation_type': 'regular',
+            'date_from': date(2024, 1, 1),
+            'date_to': False
+        })
+        first_valid_allocation.action_approve()
+
+        second_valid_allocation = self.env['hr.leave.allocation'].sudo().create({
+            'name': 'Alloc',
+            'employee_id': self.employee.id,
+            'holiday_status_id': leave_type.id,
+            'number_of_days': 12,
+            'allocation_type': 'regular',
+            'date_from': date(2025, 1, 1),
+            'date_to': date.today()
+        })
+        second_valid_allocation.action_approve()
+
+        leave = self.env['hr.leave'].create({
+            'employee_id': self.employee.id,
+            'holiday_status_id': leave_type.id,
+            'request_date_from': date(2025, 1, 1),
+            'request_date_to': date(2025, 1, 10)
+        })
+        leave._action_validate()
+
+        self.assertEqual(leave.max_leaves, 22)
+        self.assertEqual(leave.virtual_remaining_leaves, 14)