[FIX] l10n_ro_eFactura: Invoice content error detection

--Before--

-When the eFactura status was fetched and there was an invoice content error it was not displayed. This issue was due to both the overlooking of:
	(1)the 'nok' status (sent back by the Romanian authorities regarding the presence of errors in the invoice content) 
	(2)the file provided in the zip that would contain the errors
-The error message shown would also only contain the first error even if many were present.

--Now--

-If the status fetched contains 'nok' and is therefore signaling the presence of invoice content errors, then the apposite error file is chosen instead of the file with the electronic signature. This allows for following logic to account for errors, to retrieve the error message and to provide the error file as the downloadable document. 
-The pop up shows all the errors with an increased width to account for more content.

task-4306506

closes odoo#190618

Signed-off-by: Quentin De Paoli (qdp) <[email protected]>

Author: aizu-odoo

addons/account/static/src/components/document_state/document_state_field.scss

@@ -1,5 +1,5 @@
 .account_document_state_popover {
-    width: 360px;
+    width: 500px;
 }
 
 .account_document_state_popover_clone {

addons/l10n_ro_efactura/models/account_move.py

@@ -250,13 +250,14 @@ def _l10n_ro_edi_fetch_invoice_sending_documents(self):
                     company=invoice.company_id,
                     key_download=result['key_download'],
                     session=session,
+                    status=result['state_status'],
                 )
                 to_delete_documents |= invoice._l10n_ro_edi_get_sending_and_failed_documents()
                 final_result['key_loading'] = active_sending_document.key_loading
-                if 'error' in final_result:
+                if final_result.get('error'):
                     final_result['attachment_raw'] = previous_raw
                     invoice._l10n_ro_edi_create_document_invoice_sending_failed(
-                        message=final_result['error'],
+                        message=final_result['error'].replace('\t', ''),
                         attachment_raw=final_result['attachment_raw'],
                         key_loading=final_result['key_loading'],
                     )

addons/l10n_ro_efactura/models/ciusro_document.py

@@ -134,12 +134,12 @@ def _request_ciusro_fetch_status(self, company, key_loading, session):
 
         state_status = root.get('stare')
         if state_status in ('nok', 'ok'):
-            return {'key_download': root.get('id_descarcare')}
+            return {'key_download': root.get('id_descarcare'), 'state_status': state_status}
         else:
             return {}
 
     @api.model
-    def _request_ciusro_download_answer(self, company, key_download, session):
+    def _request_ciusro_download_answer(self, company, key_download, session, status=None):
         """
         This method makes a "Download Answer" (GET/descarcare) request to the Romanian SPV. It then processes the
         response by opening the received zip file and returns either:
@@ -150,7 +150,7 @@ def _request_ciusro_download_answer(self, company, key_download, session):
         :param company: ``res.company`` object
         :param key_download: Content of `key_download` received from `_request_ciusro_send_invoice`
         :param session: ``requests.Session()`` object
-        :return: {'error': <str>} | {'attachment_raw': <str>, 'key_signature': <str>, 'key_certificate': <str>}
+        :return: {'attachment_raw': <str>, 'key_signature': <str>, 'key_certificate': <str>, 'error': <str>}
         """
         result = make_efactura_request(
             session=session,
@@ -164,19 +164,26 @@ def _request_ciusro_download_answer(self, company, key_download, session):
 
         # E-Factura gives download response in ZIP format
         zip_ref = zipfile.ZipFile(io.BytesIO(result['content']))
-        signature_file = next(file for file in zip_ref.namelist() if 'semnatura' in file)
+        # The ZIP will contain two files, one with the original invoice or with the identified errors (as the case may be)
+        # and the other with the electronic signature (containing 'semnatura').
+        # If there is an error (status == 'nok') we want to provide the file with the errors.
+        if status == 'nok':
+            signature_file = next(file for file in zip_ref.namelist() if 'semnatura' not in file)
+        else:
+            signature_file = next(file for file in zip_ref.namelist() if 'semnatura' in file)
         xml_bytes = zip_ref.open(signature_file)
         root = etree.parse(xml_bytes)
-        error_element = root.find('.//ns:Error', namespaces=NS_HEADER)
-        if error_element is not None:
-            return {'error': error_element.get('errorMessage')}
+        error_elements = root.findall('.//ns:Error', namespaces=NS_HEADER)
+        if error_elements:
+            error_message = ('\n\n').join(error.get('errorMessage') for error in error_elements)
 
         # Pretty-print the XML content of the signature file to be saved as attachment
         attachment_raw = etree.tostring(root, pretty_print=True, xml_declaration=True, encoding='UTF-8')
         return {
             'attachment_raw': attachment_raw,
             'key_signature': root.findtext('.//ns:SignatureValue', namespaces=NS_SIGNATURE),
             'key_certificate': root.findtext('.//ns:X509Certificate', namespaces=NS_SIGNATURE),
+            'error': error_message if error_elements else False,
         }
 
     def action_l10n_ro_edi_fetch_status(self):