Update the write object for server version 8

Author: gpbonillas

src/main/java/com/odoojava/api/ObjectAdapter.java

@@ -95,7 +95,6 @@ public ObjectAdapter(Session session, String modelName) throws XmlRpcException,
      * synchronized to make use of a global (static) list of model names to
      * increase speed
      *
-     * @param command Command object to use
      * @throws OdooApiException If the model could not be validated
      */
     @SuppressWarnings("unchecked")
@@ -848,14 +847,14 @@ public Boolean[] writeObject(final RowCollection rows, final boolean changesOnly
      *
      * @param row Row to be committed
      * @param changesOnly Only changed values will be submitted to the database.
-     * @return If the update was successful
+     * @return true if the update was successful
      * @throws OdooApiException
      * @throws XmlRpcException
      */
     public boolean writeObject(final Row row, boolean changesOnly) throws OdooApiException {
 
         Object idObj = row.get("id");
-
+        boolean success = false;
         if (idObj == null || Integer.parseInt(idObj.toString()) <= 0) {
             throw new OdooApiException("Please set the id field with the database ID of the object");
         }
@@ -869,12 +868,33 @@ public boolean writeObject(final Row row, boolean changesOnly) throws OdooApiExc
         }
 
         try {
+            if (this.serverVersion.getMajor() == 8) {
+                Object result = command.writeObject(modelName, id, valueList);
+                Object[] resultTemp = (Object[]) result;
+                Object[] resultTemp2 = (Object[]) resultTemp[0];
+
+                if (resultTemp2[0] instanceof Boolean) {
+                    success = ((Boolean) resultTemp2[0]).booleanValue();
+
+                    if (success) {
+                        row.changesApplied();
+                    }
+
+                    return success;
+                } else {
+                    return false;
+                }
+
+            } else {
+                success = (Boolean) command.writeObject(modelName, id, valueList);
 
-            boolean success = command.writeObject(modelName, id, valueList);
-            if (success) {
-                row.changesApplied();
+                if (success) {
+                    row.changesApplied();
+                }
+
+                return success;
             }
-            return success;
+
 
         } catch (XmlRpcException e) {
             throw new OdooApiException(e);

src/main/java/com/odoojava/api/OdooCommand.java

@@ -144,17 +144,17 @@ public Object[] readObject(String objectName, Object[] ids, String[] fields) thr
      * @param objectName Name of the object to update
      * @param id Database ID number of the object to update
      * @param valueList Field/Value pairs to update on the object
-     * @return True if the update was successful
+     * @return An Object value with the result of write operation
      * @throws XmlRpcException
      */
-    public boolean writeObject(String objectName, int id, Map<String, Object> valueList) throws XmlRpcException {
+    public Object writeObject(String objectName, int id, Map<String, Object> valueList) throws XmlRpcException {
         if (this.session.getServerVersion().getMajor() < 10) {
             //Prior to the v10, each version have to be adapted if needed
             //Some methods on certains class from v8 to v9 don't respect the syntax
-            return (Boolean) session.executeCommand(objectName, "write", new Object[]{id, valueList});
+            return session.executeCommand(objectName, "write", new Object[]{id, valueList});
         } else {
             //Work perfectly for the v10, please keep this check
-            return (Boolean) session.executeCommandWithContext(objectName, "write", new Object[]{id, valueList});
+            return session.executeCommandWithContext(objectName, "write", new Object[]{id, valueList});
         }
 
     }

src/test/java/com/odoojava/api/OdooCommandTest.java

@@ -136,7 +136,8 @@ public void testWriteObject() throws Exception {
         Map<String, Object> valueList = null;
         OdooCommand instance = null;
         boolean expResult = false;
-        boolean result = instance.writeObject(objectName, id, valueList);
+        boolean result = ((Boolean) ((Object[]) ((Object[])instance.writeObject(objectName, id, valueList))[0])[0]).booleanValue();
+
         assertEquals(expResult, result);
         // TODO review the generated test code and remove the default call to fail.
         fail("The test case is a prototype.");