Skip to content

Commit 0a64c01

Browse files
chgo-odoochgo-odoo
committed
[IMP] theme_*: review s_features_grid snippet
This commit reviews the occurrences of the features_grid snippet across design themes. *: theme_artists, theme_bewise, theme_bookstore, theme_buzzy, theme_loftspace, theme_notes, theme_odoo_experts, theme_paptic, theme_vehicle task-3619705 closes #825 Related: odoo/odoo#172974 Signed-off-by: Arthur Detroux (ard) <[email protected]>
1 parent dece156 commit 0a64c01

File tree

10 files changed

+69
-60
lines changed

10 files changed

+69
-60
lines changed

‎theme_artists/views/new_page_template.xml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,15 @@
4949
</template>
5050

5151
<template id="new_page_template_s_features_grid" inherit_id="website.new_page_template_s_features_grid">
52+
<xpath expr="//i" position="attributes">
53+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-1" separator=" "/>
54+
</xpath>
55+
<xpath expr="(//i)[2]" position="attributes">
56+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-1" separator=" "/>
57+
</xpath>
58+
<xpath expr="(//i)[3]" position="attributes">
59+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-1" separator=" "/>
60+
</xpath>
5261
<xpath expr="(//i)[4]" position="attributes">
5362
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-1" separator=" "/>
5463
</xpath>

‎theme_artists/views/snippets/s_features_grid.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@
88
</xpath>
99
<!-- Icons -->
1010
<xpath expr="//i" position="attributes">
11-
<attribute name="class" add="rounded" remove="rounded-circle" separator=" "/>
11+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
1212
</xpath>
1313
<xpath expr="(//i)[2]" position="attributes">
14-
<attribute name="class" add="rounded" remove="rounded-circle" separator=" "/>
14+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
1515
</xpath>
1616
<xpath expr="(//i)[3]" position="attributes">
17-
<attribute name="class" add="rounded" remove="rounded-circle" separator=" "/>
17+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
1818
</xpath>
1919
<xpath expr="(//i)[4]" position="attributes">
20-
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-2" separator=" "/>
20+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
2121
</xpath>
2222
<xpath expr="(//i)[5]" position="attributes">
23-
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-2" separator=" "/>
23+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
2424
</xpath>
2525
<xpath expr="(//i)[6]" position="attributes">
26-
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-2" separator=" "/>
26+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
2727
</xpath>
2828
</template>
2929

‎theme_bewise/views/customizations.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -395,22 +395,22 @@
395395
<template id="s_features_grid" inherit_id="website.s_features_grid" name="Be Wise s_features_grid">
396396
<!-- Icons -->
397397
<xpath expr="//i" position="attributes">
398-
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-1" separator=" "/>
398+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
399399
</xpath>
400400
<xpath expr="(//i)[2]" position="attributes">
401-
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-1" separator=" "/>
401+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
402402
</xpath>
403403
<xpath expr="(//i)[3]" position="attributes">
404-
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-1" separator=" "/>
404+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
405405
</xpath>
406406
<xpath expr="(//i)[4]" position="attributes">
407-
<attribute name="class" add="rounded-circle" remove="fa-2x rounded" separator=" "/>
407+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
408408
</xpath>
409409
<xpath expr="(//i)[5]" position="attributes">
410-
<attribute name="class" add="rounded-circle" remove="fa-2x rounded" separator=" "/>
410+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
411411
</xpath>
412412
<xpath expr="(//i)[6]" position="attributes">
413-
<attribute name="class" add="rounded-circle" remove="fa-2x rounded" separator=" "/>
413+
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-3" separator=" "/>
414414
</xpath>
415415
</template>
416416

‎theme_bookstore/views/snippets/s_features_grid.xml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,18 @@
22
<odoo>
33

44
<template id="s_features_grid" inherit_id="website.s_features_grid">
5+
<!-- Item #1 -->
6+
<xpath expr="(//i)[1]" position="attributes">
7+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
8+
</xpath>
9+
<!-- Item #2 -->
10+
<xpath expr="(//i)[2]" position="attributes">
11+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
12+
</xpath>
13+
<!-- Item #3 -->
14+
<xpath expr="(//i)[3]" position="attributes">
15+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
16+
</xpath>
517
<!-- Item #4 -->
618
<xpath expr="(//i)[4]" position="attributes">
719
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>

‎theme_buzzy/views/snippets/s_features_grid.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@
88
</xpath>
99
<!-- Icons -->
1010
<xpath expr="//i" position="attributes">
11-
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-1" separator=" "/>
11+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
1212
</xpath>
1313
<xpath expr="(//i)[2]" position="attributes">
14-
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-1" separator=" "/>
14+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
1515
</xpath>
1616
<xpath expr="(//i)[3]" position="attributes">
17-
<attribute name="class" add="bg-o-color-2" remove="fa-2x bg-o-color-1" separator=" "/>
17+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
1818
</xpath>
1919
<xpath expr="(//i)[4]" position="attributes">
20-
<attribute name="class" add="rounded-circle" remove="rounded fa-2x" separator=" "/>
20+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
2121
</xpath>
2222
<xpath expr="(//i)[5]" position="attributes">
23-
<attribute name="class" add="rounded-circle" remove="rounded fa-2x" separator=" "/>
23+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
2424
</xpath>
2525
<xpath expr="(//i)[6]" position="attributes">
26-
<attribute name="class" add="rounded-circle" remove="rounded fa-2x" separator=" "/>
26+
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
2727
</xpath>
2828
</template>
2929

‎theme_loftspace/views/snippets/s_features_grid.xml‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,25 @@
22
<odoo>
33

44
<template id="s_features_grid" inherit_id="website.s_features_grid">
5+
<!-- Item #1 -->
6+
<xpath expr="//i" position="attributes">
7+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
8+
</xpath>
59
<!-- Item #2 -->
610
<xpath expr="(//i)[2]" position="attributes">
7-
<attribute name="class" add="bg-o-color-2" remove="bg-o-color-1" separator=" "/>
11+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
812
</xpath>
913
<!-- Item #4 -->
1014
<xpath expr="(//i)[4]" position="attributes">
11-
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
15+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
1216
</xpath>
1317
<!-- Item #5 -->
1418
<xpath expr="(//i)[5]" position="attributes">
15-
<attribute name="class" add="rounded-circle bg-o-color-1" remove="rounded bg-o-color-2" separator=" "/>
19+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
1620
</xpath>
1721
<!-- Item #6 -->
1822
<xpath expr="(//i)[6]" position="attributes">
19-
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
23+
<attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
2024
</xpath>
2125
</template>
2226

‎theme_notes/views/snippets/s_features_grid.xml‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,7 @@
44
<template id="s_features_grid" inherit_id="website.s_features_grid">
55
<!-- Section -->
66
<xpath expr="//section" position="attributes">
7-
<attribute name="class" add="o_cc o_cc5 pb72 pt96" remove="pt48 pb24" separator=" "/>
8-
</xpath>
9-
<!-- Item #4 -->
10-
<xpath expr="(//i)[4]" position="attributes">
11-
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
12-
</xpath>
13-
<!-- Item #5 -->
14-
<xpath expr="(//i)[5]" position="attributes">
15-
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
16-
</xpath>
17-
<!-- Item #6 -->
18-
<xpath expr="(//i)[6]" position="attributes">
19-
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
7+
<attribute name="class" add="o_cc o_cc5 pb72 pt96" remove="pt64 pb64" separator=" "/>
208
</xpath>
219
</template>
2210

‎theme_odoo_experts/views/snippets/s_features_grid.xml‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,27 @@
44
<template id="s_features_grid" inherit_id="website.s_features_grid">
55
<!-- Item #1 - Icon -->
66
<xpath expr="//i" position="attributes">
7-
<attribute name="class" add="rounded" remove="rounded-circle" separator=" "/>
7+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
88
</xpath>
99
<!-- Item #2 - Icon -->
1010
<xpath expr="(//i)[2]" position="attributes">
11-
<attribute name="class" add="rounded" remove="rounded-circle" separator=" "/>
11+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
1212
</xpath>
1313
<!-- Item #3 - Icon -->
1414
<xpath expr="(//i)[3]" position="attributes">
15-
<attribute name="class" add="rounded" remove="rounded-circle" separator=" "/>
15+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
16+
</xpath>
17+
<!-- Item #4 - Icon -->
18+
<xpath expr="(//i)[4]" position="attributes">
19+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
20+
</xpath>
21+
<!-- Item #5 - Icon -->
22+
<xpath expr="(//i)[5]" position="attributes">
23+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
24+
</xpath>
25+
<!-- Item #6 - Icon -->
26+
<xpath expr="(//i)[6]" position="attributes">
27+
<attribute name="class" add="rounded-circle" remove="rounded" separator=" "/>
1628
</xpath>
1729
</template>
1830

‎theme_paptic/views/customizations.xml‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -411,22 +411,6 @@
411411
</xpath>
412412
</template>
413413

414-
<!-- ==== Features Grid ===== -->
415-
<template id="s_features_grid" inherit_id="website.s_features_grid" name="Paptic s_features_grid">
416-
<!-- Icon #4 -->
417-
<xpath expr="(//i)[4]" position="attributes">
418-
<attribute name="class" add="rounded-circle bg-o-color-3" remove="rounded bg-o-color-2" separator=" "/>
419-
</xpath>
420-
<!-- Icon #5 -->
421-
<xpath expr="(//i)[5]" position="attributes">
422-
<attribute name="class" add="rounded-circle bg-o-color-3" remove="rounded bg-o-color-2" separator=" "/>
423-
</xpath>
424-
<!-- Icon #6 -->
425-
<xpath expr="(//i)[6]" position="attributes">
426-
<attribute name="class" add="rounded-circle bg-o-color-3" remove="rounded bg-o-color-2" separator=" "/>
427-
</xpath>
428-
</template>
429-
430414
<!-- ==== Pricelist ===== -->
431415
<template id="s_product_catalog" inherit_id="website.s_product_catalog" name="Paptic s_product_catalog">
432416
<!-- Filter -->

‎theme_vehicle/views/customizations.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -278,27 +278,27 @@
278278
</xpath>
279279
<!-- Item #1 -->
280280
<xpath expr="//i" position="attributes">
281-
<attribute name="class" add="rounded-0 bg-o-color-3 text-o-color-1" remove="rounded-circle bg-o-color-1" separator=" "/>
281+
<attribute name="class" add="text-o-color-1" separator=" "/>
282282
</xpath>
283283
<!-- Item #2 -->
284284
<xpath expr="(//i)[2]" position="attributes">
285-
<attribute name="class" add="rounded-0 bg-o-color-3 text-o-color-1" remove="rounded-circle bg-o-color-1" separator=" "/>
285+
<attribute name="class" add="text-o-color-1" separator=" "/>
286286
</xpath>
287287
<!-- Item #3 -->
288288
<xpath expr="(//i)[3]" position="attributes">
289-
<attribute name="class" add="rounded-0 bg-o-color-3 text-o-color-1" remove="rounded-circle bg-o-color-1" separator=" "/>
289+
<attribute name="class" add="text-o-color-1" separator=" "/>
290290
</xpath>
291291
<!-- Item #4 -->
292292
<xpath expr="(//i)[4]" position="attributes">
293-
<attribute name="class" add="rounded-0 bg-o-color-3 text-o-color-2" remove="rounded bg-o-color-2" separator=" "/>
293+
<attribute name="class" add="text-o-color-1" separator=" "/>
294294
</xpath>
295295
<!-- Item #5 -->
296296
<xpath expr="(//i)[5]" position="attributes">
297-
<attribute name="class" add="rounded-0 bg-o-color-3 text-o-color-2" remove="rounded bg-o-color-2" separator=" "/>
297+
<attribute name="class" add="text-o-color-1" separator=" "/>
298298
</xpath>
299299
<!-- Item #6 -->
300300
<xpath expr="(//i)[6]" position="attributes">
301-
<attribute name="class" add="rounded-0 bg-o-color-3 text-o-color-2" remove="rounded bg-o-color-2" separator=" "/>
301+
<attribute name="class" add="text-o-color-1" separator=" "/>
302302
</xpath>
303303
</template>
304304

0 commit comments

Comments
 (0)