[IMP] website: review s_features snippet templates

The goal of this commit is to review the occurrences of the
default `s_features` snippet across design themes.

task-3657631

Part-of: #826
Related: odoo/odoo#163577
Signed-off-by: Benoit Socias (bso) <[email protected]>

Author: chgo-odoo

theme_artists/views/snippets/s_features.xml

@@ -13,11 +13,15 @@
     </xpath>
     <!-- Feature #01 - Icon -->
     <xpath expr="//i" position="attributes">
-        <attribute name="class" add="bg-o-color-5" remove="bg-o-color-1" separator=" "/>
+        <attribute name="class" add="bg-o-color-5" remove="bg-o-color-3" separator=" "/>
+    </xpath>
+    <!-- Feature #02 - Icon -->
+    <xpath expr="(//i)[2]" position="attributes">
+        <attribute name="class" add="bg-o-color-5" remove="bg-o-color-3" separator=" "/>
     </xpath>
     <!-- Feature #03 - Icon -->
     <xpath expr="(//i)[3]" position="attributes">
-        <attribute name="class" add="bg-o-color-5" remove="bg-o-color-2" separator=" "/>
+        <attribute name="class" add="bg-o-color-5" remove="bg-o-color-3" separator=" "/>
     </xpath>
 </template>
 

theme_aviato/views/snippets/s_features.xml

@@ -4,27 +4,27 @@
 <template id="s_features" inherit_id="website.s_features">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt48 pb56" remove="pt32 pb32" separator=" "/>
+        <attribute name="class" add="pt48 pb56" remove="pt64 pb64" separator=" "/>
     </xpath>
     <!-- Titles -->
-    <xpath expr="//div[hasclass('row')]/div[1]/h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[1]/div/h3" position="replace" mode="inner">
         Hotel Booking
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[2]/h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/h3" position="replace" mode="inner">
         Flight Booking
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[3]/h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/h3" position="replace" mode="inner">
         Ticket Booking
     </xpath>
     <!-- Icons -->
     <xpath expr="//div[hasclass('row')]/div[1]/i" position="attributes">
-        <attribute name="class" add="shadow fa-hotel" remove="fa-gear" separator=" "/>
+        <attribute name="class" add="fa-hotel" remove="fa-paper-plane-o" separator=" "/>
     </xpath>
     <xpath expr="//div[hasclass('row')]/div[2]/i" position="attributes">
-        <attribute name="class" add="shadow fa-plane" remove="fa-photo" separator=" "/>
+        <attribute name="class" add="fa-plane" remove="fa-credit-card" separator=" "/>
     </xpath>
     <xpath expr="//div[hasclass('row')]/div[3]/i" position="attributes">
-        <attribute name="class" add="shadow fa-ticket" remove="fa-leaf" separator=" "/>
+        <attribute name="class" add="fa-ticket" remove="fa-flag-o" separator=" "/>
     </xpath>
 </template>
 

theme_bewise/views/customizations.xml

@@ -307,13 +307,13 @@
 <template id="s_features" inherit_id="website.s_features" name="Be Wise s_features">
     <!-- Icons -->
     <xpath expr="//i" position="attributes">
-        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-1" separator=" "/>
+        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-3" separator=" "/>
     </xpath>
     <xpath expr="(//i)[2]" position="attributes">
-        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-5" separator=" "/>
+        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-3" separator=" "/>
     </xpath>
     <xpath expr="(//i)[3]" position="attributes">
-        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-2" separator=" "/>
+        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-3" separator=" "/>
     </xpath>
 </template>
 

theme_bistro/views/snippets/s_features.xml

@@ -4,32 +4,32 @@
 <template id="s_features" inherit_id="website.s_features">
     <!-- Column #01 -->
     <xpath expr="//i" position="replace">
-        <i class="fa fa-2x fa-coffee rounded-circle bg-primary m-3"/>
+        <i class="fa fa-coffee rounded bg-primary mb-3" role="img"/>
     </xpath>
-    <xpath expr="//h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[1]/div/h3" position="replace" mode="inner">
         Breakfast
     </xpath>
-    <xpath expr="//p" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]//p" position="replace" mode="inner">
         Help you start your morning right.<br/><small>From <b>7:30 am</b> to <b>10:30 am</b></small>
     </xpath>
     <!-- Column #02 -->
     <xpath expr="(//i)[2]" position="replace">
-        <i class="fa fa-2x fa-cutlery rounded-circle bg-400 m-3"/>
+        <i class="fa fa-cutlery rounded bg-primary mb-3" role="img"/>
     </xpath>
-    <xpath expr="(//h3)[2]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/h3" position="replace" mode="inner">
         Lunch
     </xpath>
-    <xpath expr="(//p)[2]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/p" position="replace" mode="inner">
         Take a break from your busy schedule.<br/><small>From <b>11:30 am</b> to <b>2:30 pm</b></small>
     </xpath>
     <!-- Column #03 -->
     <xpath expr="(//i)[3]" position="replace">
-        <i class="fa fa-2x fa-glass rounded-circle bg-secondary m-3"/>
+        <i class="fa fa-glass rounded bg-primary mb-3" role="img"/>
     </xpath>
-    <xpath expr="(//h3)[3]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/h3" position="replace" mode="inner">
         Dinner
     </xpath>
-    <xpath expr="(//p)[3]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/p" position="replace" mode="inner">
         Enjoy tasty food with friends.<br/><small>From <b>6:30 pm</b> to <b>10:30 pm</b></small>
     </xpath>
 </template>

theme_buzzy/views/new_page_template.xml

@@ -68,7 +68,7 @@
 
 <template id="new_page_template_s_features" inherit_id="website.new_page_template_s_features">
     <xpath expr="//div[hasclass('row')]//div[3]//i" position="attributes">
-        <attribute name="class" add="bg-o-color-2" remove="bg-o-color-1" separator=" "/>
+        <attribute name="class" add="bg-o-color-2" remove="bg-o-color-3" separator=" "/>
     </xpath>
 </template>
 

theme_buzzy/views/snippets/s_features.xml

@@ -11,13 +11,17 @@
     <xpath expr="//div[hasclass('container')]" position="before">
         <div class="o_we_shape o_web_editor_Rainy_09_001"/>
     </xpath>
+    <!-- Feature #1 - Icon -->
+    <xpath expr="//div[hasclass('row')]//div[1]//i" position="attributes">
+        <attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
+    </xpath>
     <!-- Feature #2 - Icon -->
     <xpath expr="//div[hasclass('row')]//div[2]//i" position="attributes">
-        <attribute name="class" add="bg-o-color-1" remove="bg-o-color-5" separator=" "/>
+        <attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
     </xpath>
     <!-- Feature #3 - Icon -->
     <xpath expr="//div[hasclass('row')]//div[3]//i" position="attributes">
-        <attribute name="class" add="bg-o-color-1" remove="bg-o-color-2" separator=" "/>
+        <attribute name="class" add="bg-o-color-1" remove="bg-o-color-3" separator=" "/>
     </xpath>
 </template>
 

theme_clean/views/snippets/s_features.xml

@@ -8,23 +8,23 @@
     </xpath>
     <!-- First column : icon -->
     <xpath expr="//div[hasclass('row')]//div//i" position="attributes">
-        <attribute name="class" add="bg-o-color-4 fa-shield" remove="bg-o-color-1 fa-gear" separator=" "/>
+        <attribute name="class" add="bg-o-color-4 fa-shield" remove="bg-o-color-3 fa-paper-plane-o" separator=" "/>
     </xpath>
     <!-- First column : title -->
     <xpath expr="//div[hasclass('row')]//div//h3" position="replace" mode="inner">
         Secured
     </xpath>
     <!-- Second column : icon -->
     <xpath expr="//div[hasclass('row')]//div[2]//i" position="attributes">
-        <attribute name="class" add="bg-o-color-1 fa-laptop" remove="bg-o-color-5 fa-photo" separator=" "/>
+        <attribute name="class" add="bg-o-color-4 fa-laptop" remove="bg-o-color-3 fa-credit-card" separator=" "/>
     </xpath>
     <!-- Second column : title -->
     <xpath expr="//div[hasclass('row')]//div[2]//h3" position="replace" mode="inner">
         All in one
     </xpath>
     <!-- Third column : icon -->
     <xpath expr="//div[hasclass('row')]//div[3]//i" position="attributes">
-        <attribute name="class" add="fa-star" remove="fa-leaf" separator=" "/>
+        <attribute name="class" add="bg-o-color-4 fa-star" remove="bg-o-color-3 fa-flag-o" separator=" "/>
     </xpath>
     <!-- Third column : title -->
     <xpath expr="//div[hasclass('row')]//div[3]//h3" position="replace" mode="inner">

theme_kea/views/snippets/s_features.xml

@@ -4,45 +4,36 @@
 <template id="s_features" inherit_id="website.s_features">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="o_cc2 pt48 pb64" remove="pt32 pb32" separator=" "/>
+        <attribute name="class" add="o_cc2 pt48" remove="pt64" separator=" "/>
     </xpath>
     <!-- Column #01 -->
-    <xpath expr="//div[hasclass('row')]/div[1]" position="attributes">
-        <attribute name="class" add="o_cc o_cc1 pt48 pb48" remove="pt32 pb32" separator=" "/>
-    </xpath>
     <xpath expr="//div[hasclass('row')]/div[1]/i" position="replace">
-        <i class="fa fa-2x fa-image bg-o-color-1 m-3 rounded-circle"/>
+        <i class="s_features_icon fa fa-image mb-3 rounded fs-5" role="img"/>
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[1]/h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[1]/div/h3" position="replace" mode="inner">
         <b>Stunning visuals</b>
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[1]/p" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[1]/div/p" position="replace" mode="inner">
         Tell what's the value for the customer for this feature.
     </xpath>
     <!-- Column #02 -->
-    <xpath expr="//div[hasclass('row')]/div[2]" position="attributes">
-        <attribute name="class" add="o_cc o_cc1 pt48 pb48" remove="pt32 pb32" separator=" "/>
-    </xpath>
     <xpath expr="//div[hasclass('row')]/div[2]/i" position="replace">
-        <i class="fa fa-2x fa-eye bg-o-color-5 m-3 rounded-circle"/>
+        <i class="s_features_icon fa fa-eye mb-3 rounded fs-5" role="img"/>
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[2]/h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/h3" position="replace" mode="inner">
         <b>360-degree vision</b>
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[2]/p" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/p" position="replace" mode="inner">
         Write what the customer would like to know, not what you want to show.
     </xpath>
     <!-- Column #03 -->
-    <xpath expr="//div[hasclass('row')]/div[3]" position="attributes">
-        <attribute name="class" add="o_cc o_cc1 pt48 pb48" remove="pt32 pb32" separator=" "/>
-    </xpath>
     <xpath expr="//div[hasclass('row')]/div[3]/i" position="attributes">
-        <attribute name="class" add="fa-2x fa-microphone rounded-circle" remove="fa-3x fa-leaf rounded" separator=" "/>
+        <attribute name="class" add="fa-microphone" remove="fa-flag-o" separator=" "/>
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[3]/h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/h3" position="replace" mode="inner">
         <b>Built in mic</b>
     </xpath>
-    <xpath expr="//div[hasclass('row')]/div[3]/p" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/p" position="replace" mode="inner">
         A small explanation of this great feature, in clear words.
     </xpath>
 </template>

theme_nano/views/snippets/s_features.xml

@@ -4,34 +4,31 @@
 <template id="s_features" inherit_id="website.s_features">
     <!-- Section -->
     <xpath expr="//section" position="attributes">
-        <attribute name="class" add="pt40 pb48 o_cc o_cc5" remove="pt32 pb32" separator=" "/>
+        <attribute name="class" add="pt40 pb48 o_cc o_cc5" remove="pt64 pb64" separator=" "/>
         <attribute name="data-oe-shape-data">{"shape":"web_editor/Floats/12"}</attribute>
     </xpath>
     <xpath expr="//*[hasclass('container')]" position="before">
         <div class="o_we_shape o_web_editor_Floats_12"/>
     </xpath>
     <!-- Column #01 -->
-    <xpath expr="//h3" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[1]/div/h3" position="replace" mode="inner">
         Intuitive
     </xpath>
-    <xpath expr="//p" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[1]/div/p" position="replace" mode="inner">
         We create easy-to-use products.
     </xpath>
     <!-- Column #02 -->
-    <xpath expr="(//i)[2]" position="attributes">
-        <attribute name="class" add="bg-o-color-4" remove="bg-o-color-5" separator=" "/>
-    </xpath>
-    <xpath expr="(//h3)[2]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/h3" position="replace" mode="inner">
         Adaptable
     </xpath>
-    <xpath expr="(//p)[2]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[2]/div/p" position="replace" mode="inner">
         We build modular solutions.
     </xpath>
     <!-- Column #03 -->
-    <xpath expr="(//h3)[3]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/h3" position="replace" mode="inner">
         Durable
     </xpath>
-    <xpath expr="(//p)[3]" position="replace" mode="inner">
+    <xpath expr="//div[hasclass('row')]/div[3]/div/p" position="replace" mode="inner">
         We craft long-lasting goods.
     </xpath>
 </template>

theme_paptic/views/customizations.xml

@@ -377,22 +377,16 @@
     </xpath>
     <!-- Column #1 -->
     <xpath expr="//div[hasclass('col-lg-4')]" position="attributes">
-        <attribute name="class" add="o_cc o_cc4" separator=" "/>
+        <attribute name="class" add="o_cc o_cc2" separator=" "/>
     </xpath>
     <!-- Column #2 -->
     <xpath expr="//div[hasclass('col-lg-4')][2]" position="attributes">
-        <attribute name="class" add="o_cc o_cc3" separator=" "/>
-    </xpath>
-    <xpath expr="//div[hasclass('col-lg-4')][2]/i" position="attributes">
-        <attribute name="class" add="bg-o-color-2" remove="bg-o-color-5" separator=" "/>
+        <attribute name="class" add="o_cc o_cc2" separator=" "/>
     </xpath>
     <!-- Column #3 -->
     <xpath expr="//div[hasclass('col-lg-4')][3]" position="attributes">
         <attribute name="class" add="o_cc o_cc2" separator=" "/>
     </xpath>
-    <xpath expr="//div[hasclass('col-lg-4')][3]/i" position="attributes">
-        <attribute name="class" add="bg-o-color-3" remove="bg-o-color-2" separator=" "/>
-    </xpath>
 </template>
 
 <!-- ==== Media List ===== -->