Skip to content

Commit c0d3a66

Browse files
committed
[FIX] theme_test_custo: fix nightly theme preview tour
The theme preview feature before selection was disabled in [1]. This commit disables the related tour steps that were testing it a nightly tour... that was red since then. [1]: odoo/odoo@7cb71e9 Related to task-3454790 closes #1082 X-original-commit: b4dfb01 Related: odoo/odoo#210890 Signed-off-by: Quentin Smetz (qsm) <[email protected]>
1 parent cdc0150 commit c0d3a66

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

theme_test_custo/static/tests/tours/website_theme_preview.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/** @odoo-module */
2-
31
import { registry } from "@web/core/registry";
42

53
registry.category("web_tour.tours").add("website_theme_preview", {
@@ -22,6 +20,11 @@ registry.category("web_tour.tours").add("website_theme_preview", {
2220
{
2321
content: "Click Skip and start from scratch",
2422
trigger: "button:contains('Skip and start from scratch')",
23+
/*
24+
TODO The feature that the following steps are testing is currently disabled.
25+
It will either be restored or entirely removed at some point. See task-3454790.
26+
Also, we simply do not go through theme choice when using "Skip and start from
27+
scratch" in the configurator: the tour flow would have to be adapted.
2528
run: "click",
2629
}, {
2730
content: "Click on the Live preview of a theme",
@@ -43,4 +46,5 @@ registry.category("web_tour.tours").add("website_theme_preview", {
4346
content: "Check that the desktop view is active",
4447
trigger: ".o_view_form_theme_preview_controller .o_field_iframe > div:not(.is_mobile):visible",
4548
run: () => null, // it's a check
49+
*/
4650
}]});

theme_test_custo/tests/test_theme_creation.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from odoo.tests import HttpCase, tagged
44
from odoo.addons.website.tests.test_configurator import TestConfiguratorCommon
55

6+
67
# TODO: `test_themes` tag should not be there, runbot config should be adapted
78
# to test this module too. There is a special config for the theme repo.
89
@tagged('post_install', '-at_install', 'test_themes')
@@ -14,6 +15,7 @@ def test_01_menu_hierarchies(self):
1415
theme_custo.with_context(load_all_views=True, apply_new_theme=True)._theme_load(website)
1516
self.start_tour('/@/example', "theme_menu_hierarchies", login='admin')
1617

18+
1719
@tagged('post_install', '-at_install')
1820
class TestThemeConfigurator(TestConfiguratorCommon):
1921
def test_website_theme_preview(self):

0 commit comments

Comments
 (0)