Skip to content

Commit c3bee92

Browse files
committed
[IMP] theme_*: adapt s_image_text templates
This commit aims to review all the occurrences of the `s_image_text` snippet across the themes in order to fix broken selectors. task-3665301 closes #830 Related: odoo/odoo#173311 Signed-off-by: Robin Lejeune (role) <[email protected]>
1 parent 24b689a commit c3bee92

File tree

25 files changed

+32
-75
lines changed

25 files changed

+32
-75
lines changed

theme_artists/views/snippets/s_image_text.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@
44
<template id="s_image_text" inherit_id="website.s_image_text">
55
<!-- Section -->
66
<xpath expr="//section" position="attributes">
7-
<attribute name="class" add="o_cc o_cc5 pt128" remove="pt32" separator=" "/>
8-
</xpath>
9-
<!-- Text wrapper -->
10-
<xpath expr="//div[hasclass('col-lg-6')][2]" position="attributes">
11-
<attribute name="class" add="col-lg-5 offset-lg-1" remove="col-lg-6" separator=" "/>
7+
<attribute name="class" add="o_cc o_cc5 pt128" remove="pt80" separator=" "/>
128
</xpath>
139
<!-- Title -->
1410
<xpath expr="//h2" position="replace" mode="inner">

theme_avantgarde/views/customizations.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,11 @@
144144

145145
<!-- ======== IMAGE-TEXT ======== -->
146146
<template id="s_image_text" inherit_id="website.s_image_text" name="Avantgarde s_image_text">
147-
<xpath expr="//div[hasclass('col-lg-6')][1]" position="attributes">
147+
<xpath expr="//div[hasclass('col-lg-6')]" position="attributes">
148148
<attribute name="class" add="col-lg-5 offset-lg-1" remove="col-lg-6" separator=" "/>
149149
</xpath>
150-
<xpath expr="//div[hasclass('col-lg-6')][1]" position="attributes">
151-
<attribute name="class" add="col-lg-4 offset-lg-1" remove="col-lg-6" separator=" "/>
150+
<xpath expr="//div[hasclass('col-lg-5')]" position="attributes">
151+
<attribute name="class" add="col-lg-4" remove="col-lg-5" separator=" "/>
152152
</xpath>
153153
<xpath expr="//a[hasclass('btn')]" position="attributes">
154154
<attribute name="class" add="btn-lg" separator=" "/>

theme_aviato/views/snippets/s_image_text.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<attribute name="class" add="container-fluid" remove="container" separator=" "/>
88
</xpath>
99
<xpath expr="//section" position="attributes">
10-
<attribute name="class" add="pb72" remove="pb32" separator=" "/>
10+
<attribute name="class" add="pb72" remove="pb80" separator=" "/>
1111
</xpath>
1212
<!-- Image -->
1313
<xpath expr="//img" position="attributes">
@@ -16,7 +16,7 @@
1616
</xpath>
1717
<!-- layout -->
1818
<xpath expr="//div[hasclass('row')]/div[2]" position="attributes">
19-
<attribute name="class" add="col-lg-4" remove="col-lg-6" separator=" "/>
19+
<attribute name="class" add="col-lg-4" remove="col-lg-5 offset-lg-1" separator=" "/>
2020
</xpath>
2121
<!-- Title -->
2222
<xpath expr="//h2" position="replace" mode="inner">

theme_bewise/views/customizations.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@
6060

6161
<!-- ======== IMAGE-TEXT ======== -->
6262
<template id="s_image_text" inherit_id="website.s_image_text" name="Be Wise s_image_text">
63-
<xpath expr="//div[hasclass('col-lg-6')][1]" position="attributes">
63+
<xpath expr="//div[hasclass('col-lg-6')]" position="attributes">
6464
<attribute name="class" add="col-lg-5 offset-lg-1" remove="col-lg-6" separator=" "/>
6565
</xpath>
66-
<xpath expr="//div[hasclass('col-lg-6')][1]" position="attributes">
67-
<attribute name="class" add="col-lg-4 offset-lg-1" remove="col-lg-6" separator=" "/>
66+
<xpath expr="//div[hasclass('col-lg-5')]" position="attributes">
67+
<attribute name="class" add="col-lg-4" remove="col-lg-5" separator=" "/>
6868
</xpath>
6969
<xpath expr="//h2" position="replace" mode="inner">
7070
What makes us different?

theme_bistro/views/snippets/s_image_text.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<template id="s_image_text" inherit_id="website.s_image_text">
55
<!-- Section -->
66
<xpath expr="//section" position="attributes">
7-
<attribute name="class" add="pt64 pb64" remove="pt32 pb32" separator=" "/>
7+
<attribute name="class" add="pt64 pb64" remove="pt80 pb80" separator=" "/>
88
</xpath>
99
<!-- Image -->
1010
<xpath expr="//img" position="attributes">

theme_bookstore/views/snippets/s_image_text.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<template id="s_image_text" inherit_id="website.s_image_text">
55
<!-- Section -->
66
<xpath expr="//section" position="attributes">
7-
<attribute name="class" add="o_cc o_cc2 pt112 pb112" remove="pt32 pb32" separator=" "/>
7+
<attribute name="class" add="o_cc o_cc2 pt112 pb112" remove="pt80 pb80" separator=" "/>
88
</xpath>
99
<!-- Image -->
1010
<xpath expr="//img" position="attributes">

theme_buzzy/views/snippets/s_image_text.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<template id="s_image_text" inherit_id="website.s_image_text">
55
<!-- Section -->
66
<xpath expr="//section" position="attributes">
7-
<attribute name="class" add="o_cc o_cc2 pt72 pb72" remove="pt32 pb32" separator=" "/>
7+
<attribute name="class" add="o_cc o_cc2 pt72 pb72" remove="pt80 pb80" separator=" "/>
88
</xpath>
99
<!-- Title -->
1010
<xpath expr="//h2" position="replace" mode="inner">

theme_clean/views/snippets/s_image_text.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<template id="s_image_text" inherit_id="website.s_image_text">
55
<!-- Section -->
66
<xpath expr="//section" position="attributes">
7-
<attribute name="class" add="o_cc o_cc4 pt72 pb72" remove="pt32 pb32" separator=" "/>
7+
<attribute name="class" add="o_cc o_cc4 pt72 pb72" remove="pt80 pb80" separator=" "/>
88
</xpath>
99
<!-- Add space after title -->
1010
<xpath expr="//h2" position="after">

theme_cobalt/views/customizations.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,7 @@
5959
<template id="s_image_text" inherit_id="website.s_image_text" name="Cobalt s_image_text">
6060
<!-- Section -->
6161
<xpath expr="//section" position="attributes">
62-
<attribute name="class" add="pt152 pb128" remove="pt32 pb32" separator=" "/>
63-
</xpath>
64-
<!-- Layout -->
65-
<xpath expr="//div[hasclass('col-lg-6')][2]" position="attributes">
66-
<attribute name="class" add="col-lg-5 offset-lg-1" remove="col-lg-6" separator=" "/>
62+
<attribute name="class" add="pt152 pb128" remove="pt80 pb80" separator=" "/>
6763
</xpath>
6864
<!-- Image -->
6965
<xpath expr="//img" position="replace">

theme_graphene/views/customizations.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@
7777

7878
<!-- ======== IMAGE-TEXT ======== -->
7979
<template id="s_image_text" inherit_id="website.s_image_text" name="Graphene s_image_text">
80-
<xpath expr="//div[hasclass('col-lg-6')][1]" position="attributes">
80+
<xpath expr="//div[hasclass('col-lg-6')]" position="attributes">
8181
<attribute name="class" add="col-lg-5 offset-lg-1" remove="col-lg-6" separator=" "/>
8282
</xpath>
83-
<xpath expr="//div[hasclass('col-lg-6')][1]" position="attributes">
84-
<attribute name="class" add="col-lg-4 offset-lg-1" remove="col-lg-6" separator=" "/>
83+
<xpath expr="//div[hasclass('col-lg-5')]" position="attributes">
84+
<attribute name="class" add="col-lg-4" remove="col-lg-5" separator=" "/>
8585
</xpath>
8686
<xpath expr="//h2" position="after">
8787
<div class="s_hr pt16 pb0" data-snippet="s_hr" data-name="Separator">

0 commit comments

Comments
 (0)