[IMP] theme_anelusia: adapt to new img indicators for gallery #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the gallery indicators are `img` tags instead of using background images. This is done to allow the translation of the indicator images. task-3626918
|
|
*: theme_enark, theme_kiddo, theme_loftspace, theme_monglia PR [229750] introduces a way to translate `src` and `href` attributes, to be able to replace an image or a document in other languages. As those attributes are now translatable, they can't be used in xpath expressions anymore: their values are not reliable given that they can change. [229750]: odoo/odoo#229750 task-3626918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the gallery indicators are
imgtags instead of using background images. This is done to allow the translation of the indicator images.task-3626918