[ADD] test_manifest: adding a alphabetical test

jaeschwa · vava-odoo · commit c33d0f674e84 · 2024-10-07T21:49:54.000+02:00
In the manifest we would like to have the dependencies classified by
alphabetical order. So we improved the test so this is directly tested
diff --git a/agriculture_shop/__manifest__.py b/agriculture_shop/__manifest__.py
@@ -12,8 +12,8 @@
         'pos_sale',
         'product_expiry',
         'purchase_requisition',
-        'survey',
         'sale_purchase',
+        'survey',
         'web_studio',
         'website_sale_loyalty',
         'theme_enark',
diff --git a/art_craft/__manifest__.py b/art_craft/__manifest__.py
@@ -9,8 +9,8 @@
     'depends': [
         'hr_hourly_cost',
         'knowledge',
-        'pos_sale',
         'pos_discount',
+        'pos_sale',
         'product_email_template',
         'purchase_stock',
         'sale_service',
diff --git a/automobile/__manifest__.py b/automobile/__manifest__.py
@@ -8,9 +8,9 @@
 Maintenance and accessorises etc.
     """,
     'depends': [
-        'base_automation',
         'account_check_printing',
         'account_followup',
+        'base_automation',
         'calendar',
         'knowledge',
         'pos_sale',
diff --git a/bike_leasing/__manifest__.py b/bike_leasing/__manifest__.py
@@ -9,6 +9,7 @@
         'base_automation',
         'calendar',
         'knowledge',
+        'payment_custom',
         'purchase_stock',
         'sale_management',
         'sale_planning',
@@ -19,7 +20,6 @@
         'website_helpdesk',
         'website_payment',
         'website_sale',
-        'payment_custom',
         'theme_vehicle',
     ],
     'data': [
diff --git a/bookstore/__manifest__.py b/bookstore/__manifest__.py
@@ -15,8 +15,8 @@
         'purchase_stock',
         'sale_management',
         'sale_purchase',
-        'stock_barcode_barcodelookup',
         'stock_account',
+        'stock_barcode_barcodelookup',
         'web_studio',
     ],
     'data': [
diff --git a/certification_organism/__manifest__.py b/certification_organism/__manifest__.py
@@ -6,16 +6,16 @@
 This module setup your database to easily use odoo in a Audit & Certification company.
 """,
     'depends': [
-        'web_studio',
-        'knowledge',
+        'crm',
+        'hr_holidays',
+        'hr_timesheet',
         'industry_fsm_sale_report',
+        'knowledge',
+        'product_margin',
         'project',
-        'hr_timesheet',
-        'hr_holidays',
-        'crm',
         'sale_timesheet',
-        'product_margin',
-        'website_appointment'
+        'web_studio',
+        'website_appointment',
     ],
     'data': [
         'data/res_config_setting.xml',
diff --git a/condominium/__manifest__.py b/condominium/__manifest__.py
@@ -11,8 +11,8 @@
         'account_followup',
         'account_payment',
         'accountant',
-        'contacts',
         'calendar',
+        'contacts',
         'documents_product',
         'documents_project_sale',
         'documents_spreadsheet',
diff --git a/electronic_store/__manifest__.py b/electronic_store/__manifest__.py
@@ -17,9 +17,9 @@
         'knowledge',
         'point_of_sale',
         'purchase_stock',
-        'stock_barcode',
         'sale_management',
         'sale_purchase',
+        'stock_barcode',
         'web_studio',
         'website_sale',
         'theme_buzzy',
diff --git a/eyewear_shop/__manifest__.py b/eyewear_shop/__manifest__.py
@@ -9,8 +9,8 @@
     'depends': [
         'appointment_crm',
         'knowledge',
-        'purchase_stock',
         'point_of_sale',
+        'purchase_stock',
         'sale_management',
         'web_studio',
         'website_appointment',
diff --git a/fitness/__manifest__.py b/fitness/__manifest__.py
@@ -14,9 +14,9 @@
         'purchase',
         'sale_project',
         'sale_subscription',
+        'web_studio',
         'website_appointment',
         'website_sale',
-        'web_studio',
     ],
     'data': [
         'data/res_config_settings.xml',
diff --git a/fmcg_store/__manifest__.py b/fmcg_store/__manifest__.py
@@ -9,8 +9,8 @@
         'account_followup',
         'knowledge',
         'loyalty',
-        'pos_sale',
         'pos_discount',
+        'pos_sale',
         'product_expiry',
         'purchase_stock',
         'sale_purchase',
diff --git a/hardware_shop/__manifest__.py b/hardware_shop/__manifest__.py
@@ -7,8 +7,8 @@
 Using Point of Sale, Inventory, Sales, Purchase, Accounting, Contact, Employee, Dashboard, Barcode, and Documents to grow their business.
     """,
     'depends': [
-        'base_geolocalize',
         'barcodes',
+        'base_geolocalize',
         'contacts',
         'knowledge',
         'pos_sale',
diff --git a/headhunter/__manifest__.py b/headhunter/__manifest__.py
@@ -15,8 +15,8 @@
         'documents_hr_recruitment',
         'documents_product',
         'knowledge',
-        'sign',
         'sale_crm',
+        'sign',
         'web_studio',
         'website_appointment',
         'website_crm',
diff --git a/it_hardware/__manifest__.py b/it_hardware/__manifest__.py
@@ -8,9 +8,9 @@
     'depends': [
         'account_followup',
         'helpdesk_stock',
+        'industry_fsm_sale',
         'knowledge',
         'purchase_stock',
-        'industry_fsm_sale',
         'repair',
         'sale_crm',
         'sale_purchase',
diff --git a/photography/__manifest__.py b/photography/__manifest__.py
@@ -13,11 +13,11 @@
     """,
     'depends': [
         'crm',
-        'sale_management',
         'knowledge',
         'project_enterprise',
-        'website_appointment',
+        'sale_management',
         'sale_project',
+        'website_appointment',
         'theme_nano',
     ],
     'data': [
diff --git a/software_reseller/__manifest__.py b/software_reseller/__manifest__.py
@@ -7,12 +7,12 @@
 The typical sale is a 1 year Oracle Database license that is purchased to Oracle, and resold to client at a margin, with extra services to setup the database.
 """,
     'depends': [
-        'project',
         'knowledge',
-        'sale_purchase',
-        'sale_timesheet',
+        'project',
         'sale_planning',
+        'sale_purchase',
         'sale_subscription',
+        'sale_timesheet',
         'web_studio',
     ],
     'data': [
diff --git a/solar_installation/__manifest__.py b/solar_installation/__manifest__.py
@@ -8,21 +8,21 @@
 ensuring the efficient installation of solar panels and associated equipment.
 """,
     'depends': [
-        'account_followup', 
-        'helpdesk_fsm',
+        'account_followup',
         'helpdesk_account',
+        'helpdesk_fsm',
         'helpdesk_repair',
-        'industry_fsm_sale_report', 
-        'industry_fsm_stock', 
-        'mrp_account', 
-        'product_expiry', 
-        'project_sms', 
-        'sale_crm', 
-        'sale_purchase', 
-        'stock_landed_costs', 
+        'industry_fsm_sale_report',
+        'industry_fsm_stock',
+        'mrp_account',
+        'product_expiry',
+        'project_sms',
+        'sale_crm',
+        'sale_purchase',
+        'stock_landed_costs',
         'web_studio',
-        'website_crm', 
-        'website_helpdesk_knowledge', 
+        'website_crm',
+        'website_helpdesk_knowledge',
         'website_livechat',
     ],
     'data': [
diff --git a/tests/test_generic/tests/test_manifest.py b/tests/test_generic/tests/test_manifest.py
@@ -137,3 +137,13 @@ def _test_dependencies(self, module, manifest_data):
             unknown_dependencies,
             "Unknown dependencies for %s: %s" % (module, ", ".join(unknown_dependencies))
         )
+        theme_is_not_last = any(dependency.startswith("theme_") for dependency in dependencies) and not dependencies[-1].startswith("theme_")
+        self.assertFalse(
+            theme_is_not_last,
+            "The theme should be the last dependency in manifest for module %s." % (module),
+        )
+        dependencies = [dep for dep in dependencies if not dep.startswith("theme_")]
+        self.assertTrue(
+            dependencies == sorted(dependencies),
+            "Dependencies in manifest for module %s are not in alphabetical order." % (module)
+        )
