[IMP] server: xml - menuitem - check that parent is valid

Author: fda-odoo

server/error_code.md

@@ -1,2 +1,2 @@
 # OdooLS Error codes
-OdooLS errors are now defined in their own modules, with the codes being available in [the diagnostics codes list file](src\core\diagnostic_codes_list.rs)
+OdooLS errors are now defined in their own modules, with the codes being available in [the diagnostics codes list file](src\core\diagnostic_codes_list.rs)

server/src/core/diagnostic_codes_list.rs

@@ -400,4 +400,8 @@ OLS05050, DiagnosticSetting::Error, "Data file {0} is not a valid XML or CSV fil
 * An XML_ID should be in the format 'xml_id' or 'module.xml_id', but can't contains more dots
 */
 OLS05051, DiagnosticSetting::Error, "Invalid XML ID '{0}'. It should not contain more than one dot.",
+/**
+* The given parent_id does not exists in the dependents modules, or is not a menuitem
+*/
+OLS05052, DiagnosticSetting::Error, "Parent menuitem with id '{0}' does not exist",
 }

server/src/core/symbols/module_symbol.rs

@@ -513,4 +513,17 @@ impl ModuleSymbol {
         result
     }
 
+    pub fn this_and_dependencies(&self, session: &mut SessionInfo) -> PtrWeakHashSet<Weak<RefCell<Symbol>>> {
+        let mut result = PtrWeakHashSet::new();
+        result.insert(self.weak_self.as_ref().unwrap().upgrade().unwrap());
+        for dep in self.depends.iter() {
+            if let Some(module) = session.sync_odoo.modules.get(&dep.0) {
+                if let Some(module) = module.upgrade() {
+                    result.insert(module);
+                }
+            }
+        }
+        result
+    }
+
 }

server/src/core/xml_arch_builder.rs

@@ -1,8 +1,9 @@
-use std::{cell::RefCell, rc::Rc};
+use std::{cell::RefCell, collections::HashMap, fmt, fs, path::PathBuf, rc::{Rc, Weak}};
 
-use lsp_types::{Diagnostic};
-use roxmltree::Node;
-use tracing::{warn};
+use lsp_types::{Diagnostic, DiagnosticSeverity, Position, Range};
+use regex::Regex;
+use roxmltree::{Attribute, Node};
+use tracing::{error, warn};
 use weak_table::PtrWeakHashSet;
 
 use crate::{constants::{BuildStatus, BuildSteps, OYarn}, core::{diagnostics::{create_diagnostic, DiagnosticCode}, entry_point::EntryPointType}, threads::SessionInfo, Sy};
@@ -97,4 +98,47 @@ impl XmlArchBuilder {
             xml_module.borrow_mut().as_module_package_mut().xml_ids.get_mut(&Sy!(id)).unwrap().insert(self.xml_symbol.clone());
         }
     }
+
+    pub fn get_xml_ids(&self, session: &mut SessionInfo, xml_id: &str, attr: &Attribute, diagnostics: &mut Vec<Diagnostic>) -> Vec<Rc<RefCell<Symbol>>> {
+        let mut res = vec![];
+        if !self.is_in_main_ep {
+            return res;
+        }
+        let id_split = xml_id.split(".").collect::<Vec<&str>>();
+        let mut module = None;
+        if id_split.len() == 1 {
+            // If no module name, we are in the current module
+            module = self.xml_symbol.borrow().find_module();
+        } else if id_split.len() == 2 {
+            // Try to find the module by name
+            if let Some(m) = session.sync_odoo.modules.get(&Sy!(id_split.first().unwrap().to_string())) {
+                module = m.upgrade();
+            }
+        } else if id_split.len() > 2 {
+            diagnostics.push(Diagnostic::new(
+                Range {
+                    start: Position::new(attr.range().start as u32, 0),
+                    end: Position::new(attr.range().end as u32, 0),
+                },
+                Some(DiagnosticSeverity::ERROR),
+                Some(lsp_types::NumberOrString::String(S!("OLS30446"))),
+                Some(EXTENSION_NAME.to_string()),
+                format!("Invalid XML ID '{}'. It should not contain more than one dot", xml_id),
+                None,
+                None
+            ));
+            return res;
+        }
+        if module.is_none() {
+            warn!("Module not found for id: {}", xml_id);
+            return res;
+        }
+        let module = module.unwrap();
+        for module in module.borrow().as_module_package().this_and_dependencies(session).iter() {
+            if let Some(xml) = module.borrow().as_module_package().xml_ids.get(&oyarn!("{}", id_split.last().unwrap())) {
+                res.extend(xml.iter());
+            }
+        }
+        res
+    }
 }

server/src/core/xml_arch_builder_rng_validation.rs

@@ -89,7 +89,7 @@ impl XmlArchBuilder {
                             }
                         }
                     }
-                }
+                },
                 "parent" => {
                     if is_submenu {
                         if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05012, &[]) {
@@ -98,8 +98,18 @@ impl XmlArchBuilder {
                                 ..diagnostic.clone()
                             });
                         }
+                    } else {
+                        //check that parent exists
+                        if self.get_xml_ids(session, attr.value(), &attr, diagnostics).is_empty() {
+                            if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05052, &[]) {
+                                diagnostics.push(Diagnostic {
+                                    range: Range { start: Position::new(attr.range().start as u32, 0), end: Position::new(attr.range().end as u32, 0) },
+                                    ..diagnostic.clone()
+                                });
+                            }
+                        }
                     }
-                }
+                },
                 "web_icon" => {
                     if has_parent || is_submenu {
                         if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05010, &[]) {