[IMP] validate module name in xml module names

Author: mmahrouss

server/src/core/csv_arch_builder.rs

@@ -95,6 +95,7 @@ impl CsvArchBuilder {
                         start: start as usize,
                         end: end as usize,
                     }),
+                    ref_key: None,
                 }
             );
             start = end + 1;

server/src/core/xml_arch_builder_rng_validation.rs

@@ -244,7 +244,8 @@ impl XmlArchBuilder {
         }
 
         let has_type = node.attribute("type").is_some();
-        let has_ref = node.attribute("ref").is_some();
+        let ref_key = node.attribute_node("ref").map(|rk| (rk.value().to_string(), rk.range()));
+        let has_ref = ref_key.is_some();
         let has_eval = node.attribute("eval").is_some();
         let has_search = node.attribute("search").is_some();
         if [has_type, has_ref, has_eval, has_search].iter().filter(|b| **b).count() > 1 {
@@ -377,6 +378,7 @@ impl XmlArchBuilder {
             range: node.attribute_node("name").unwrap().range(),
             text: text,
             text_range: text_range,
+            ref_key,
         })
     }
 

server/src/core/xml_data.rs

@@ -25,6 +25,7 @@ pub struct OdooDataField {
     pub name: OYarn,
     pub range: Range<usize>,
     pub text: Option<String>,
+    pub ref_key: Option<(String, Range<usize>)>,
     pub text_range: Option<Range<usize>>,
 }
 

server/src/core/xml_validation.rs

@@ -3,7 +3,7 @@ use std::{cell::RefCell, cmp::Ordering, collections::{HashMap, HashSet}, rc::Rc}
 use lsp_types::{Diagnostic, Position, Range};
 use tracing::{info, trace};
 
-use crate::{constants::{BuildSteps, OYarn, DEBUG_STEPS}, core::{diagnostics::{create_diagnostic, DiagnosticCode}, entry_point::{EntryPoint, EntryPointType}, evaluation::ContextValue, file_mgr::FileInfo, model::Model, odoo::SyncOdoo, symbols::symbol::Symbol, xml_data::{OdooData, XmlDataDelete, XmlDataMenuItem, OdooDataRecord, XmlDataTemplate}}, oyarn, threads::SessionInfo, utils::compare_semver, Sy};
+use crate::{Sy, constants::{BuildSteps, DEBUG_STEPS, OYarn}, core::{diagnostics::{DiagnosticCode, create_diagnostic}, entry_point::{EntryPoint, EntryPointType}, evaluation::ContextValue, file_mgr::{FileInfo, FileMgr}, model::Model, odoo::SyncOdoo, symbols::symbol::Symbol, xml_data::{OdooData, OdooDataRecord, XmlDataDelete, XmlDataMenuItem, XmlDataTemplate}}, oyarn, threads::SessionInfo, utils::compare_semver};
 
 
 
@@ -128,6 +128,21 @@ impl XmlValidator {
                     //TODO check that the language exists
                 }
             }
+            // Validate field ref_key
+            if let Some((ref_key_val, ref_key_range)) = field.ref_key.as_ref(){
+                let xml_id_split: Vec<_> = ref_key_val.split('.').collect();
+                if xml_id_split.len() > 1 {
+                    let module_name = xml_id_split[0];
+                    if session.sync_odoo.modules.get(module_name).is_none() {
+                        if let Some(diagnostic) = create_diagnostic(session, DiagnosticCode::OLS05003, &[]) {
+                            diagnostics.push(Diagnostic {
+                                range: Range { start: Position::new(ref_key_range.start.try_into().unwrap(), 0), end: Position::new(ref_key_range.end.try_into().unwrap(), 0) },
+                                ..diagnostic
+                            });
+                        }
+                    }
+                }
+            }
             //Check that the field belong to the model
             if all_fields.contains_key(&field_name) {
                 mandatory_fields.retain(|f| f != &field_name.to_string());