[IMP] server: various debug improvements

Author: fda-odoo

server/Cargo.toml

@@ -38,6 +38,7 @@ byteyarn = "0.5.1"
 roxmltree = "0.20.0"
 dirs = "5.0"
 toml = "0.8.22"
+# ittapi = "0.3" # profiling with VTune profiler
 [target.'cfg(any(target_os = "linux", target_os = "macos"))'.dependencies]
 nix = { version = "0.29.0", features = ["process"] }
 

server/src/constants.rs

@@ -10,6 +10,7 @@ pub const DEBUG_ODOO_BUILDER: bool = false;
 pub const DEBUG_MEMORY: bool = false;
 pub const DEBUG_THREADS: bool = false;
 pub const DEBUG_STEPS: bool = false;
+pub const DEBUG_STEPS_ONLY_INTERNAL: bool = true;
 pub const DEBUG_REBUILD_NOW: bool = false;
 
 pub type Tree = (Vec<OYarn>, Vec<OYarn>);

server/src/core/python_arch_builder.rs

@@ -9,7 +9,7 @@ use lsp_types::Diagnostic;
 use tracing::{trace, warn};
 use weak_table::traits::WeakElement;
 
-use crate::constants::{BuildStatus, BuildSteps, OYarn, PackageType, SymType, DEBUG_STEPS};
+use crate::constants::{BuildStatus, BuildSteps, OYarn, PackageType, SymType, DEBUG_STEPS, DEBUG_STEPS_ONLY_INTERNAL};
 use crate::core::python_utils;
 use crate::core::import_resolver::resolve_import_stmt;
 use crate::core::symbols::symbol::Symbol;
@@ -72,7 +72,7 @@ impl PythonArchBuilder {
             self.current_step = if self.file_mode {BuildSteps::ARCH} else {BuildSteps::VALIDATION};
             self.ast_indexes = symbol.borrow().ast_indexes().unwrap_or(&vec![]).clone(); //copy current ast_indexes if we are not evaluating a file
         }
-        if DEBUG_STEPS {
+        if DEBUG_STEPS && (!DEBUG_STEPS_ONLY_INTERNAL || !symbol.borrow().is_external()) {
             trace!("building {} - {}", self.file.borrow().paths().first().unwrap_or(&S!("No path found")), symbol.borrow().name());
         }
         symbol.borrow_mut().set_build_status(BuildSteps::ARCH, BuildStatus::IN_PROGRESS);

server/src/core/python_arch_eval.rs

@@ -72,7 +72,7 @@ impl PythonArchEval {
             self.file_mode = Rc::ptr_eq(&file, &symbol);
             self.current_step = if self.file_mode {BuildSteps::ARCH_EVAL} else {BuildSteps::VALIDATION};
         }
-        if DEBUG_STEPS {
+        if DEBUG_STEPS && (!DEBUG_STEPS_ONLY_INTERNAL || !symbol.borrow().is_external()) {
             trace!("evaluating {} - {}", self.file.borrow().paths().first().unwrap_or(&S!("No path found")), symbol.borrow().name());
         }
         symbol.borrow_mut().set_build_status(BuildSteps::ARCH_EVAL, BuildStatus::IN_PROGRESS);

server/src/core/python_validator.rs

@@ -78,7 +78,7 @@ impl PythonValidator {
                 if self.sym_stack[0].borrow().build_status(BuildSteps::ARCH_EVAL) != BuildStatus::DONE {
                     return;
                 }
-                if DEBUG_STEPS {
+                if DEBUG_STEPS && (!DEBUG_STEPS_ONLY_INTERNAL || !self.sym_stack[0].borrow().is_external()) {
                 trace!("Validating {}", self.sym_stack[0].borrow().paths().first().unwrap_or(&S!("No path found")));
                 }
                 self.sym_stack[0].borrow_mut().set_build_status(BuildSteps::VALIDATION, BuildStatus::IN_PROGRESS);
@@ -103,7 +103,7 @@ impl PythonValidator {
                 file_info.replace_diagnostics(BuildSteps::VALIDATION, self.diagnostics.clone());
             },
             SymType::FUNCTION => {
-                if DEBUG_STEPS {
+                if DEBUG_STEPS && (!DEBUG_STEPS_ONLY_INTERNAL || !self.sym_stack[0].borrow().is_external()) {
                 trace!("Validating function {}", self.sym_stack[0].borrow().name());
                 }
                 self.file_mode = false;

server/src/core/xml_validation.rs

@@ -94,12 +94,12 @@ impl XmlValidator {
             for (fs, deps) in field_sym.iter() {
                 if deps.is_none() {
                     let has_required = fs.borrow().evaluations().unwrap_or(&vec![]).iter()
-                    .any(|eval| 
+                    .any(|eval|
                         eval.symbol.get_symbol_as_weak(session, &mut None, diagnostics, None)
                         .context.get("required").unwrap_or(&ContextValue::BOOLEAN(false)).as_bool()
                     );
                     let has_default = fs.borrow().evaluations().unwrap_or(&vec![]).iter()
-                    .any(|eval| 
+                    .any(|eval|
                         eval.symbol.get_symbol_as_weak(session, &mut None, diagnostics, None)
                         .context.contains_key("default")
                     );