[IMP] server: improve inherit diagnostics

Author: fda-odoo

server/error_code.md

@@ -88,6 +88,12 @@ You should check the dependencies in the \_\_manifest\_\_.py file of your module
 The declared model is specifying an inheritance to a model that is not declared in the visible modules by the current one.
 Consider updating the manifest of your module to include the relevant module.
 
+### OLS30105
+
+"This model is inherited, but never declared."
+
+The extension found some classes inheriting this model, but didn't find any class that declare it first, with only a _name.
+
 ### OLS30201
 
 "A manifest shoul only contains one dictionnary".

server/src/core/python_arch_eval.rs

@@ -419,7 +419,7 @@ impl PythonArchEval {
             }
             let eval_base = &eval_base[0];
             let eval_symbol = eval_base.symbol.get_symbol(session, &mut None, &mut vec![], None);
-            let ref_sym = Symbol::follow_ref(&eval_symbol, session, &mut None, true, false, None, &mut vec![]);
+            let ref_sym = Symbol::follow_ref(&eval_symbol, session, &mut None, false, false, None, &mut vec![]);
             if ref_sym.len() > 1 {
                 self.diagnostics.push(Diagnostic::new(
                     Range::new(Position::new(base.range().start().to_u32(), 0), Position::new(base.range().end().to_u32(), 0)),

server/src/core/python_arch_eval_hooks.rs

@@ -435,36 +435,57 @@ impl PythonArchEvalHooks {
                                 let mut f = file_symbol.borrow_mut();
                                 f.add_model_dependencies(model);
                             }
-                            let symbols = model.clone().borrow().get_main_symbols(session, from_module.clone(), &mut None);
+                            let model = model.clone();
+                            let model = model.borrow();
+                            let symbols = model.get_main_symbols(session, from_module.clone(), &mut None);
                             if !symbols.is_empty() {
                                 for s in symbols.iter() {
                                     if from_module.is_none() || ModuleSymbol::is_in_deps(session, &from_module.as_ref().unwrap(),&s.borrow().find_module().unwrap().borrow().as_module_package().dir_name, &mut None) {
                                         return EvaluationSymbolWeak::new(Rc::downgrade(s), Some(true), false);
                                     }
                                 }
-                                //still here? If from module is set, dependencies are not met
+                            } else {
                                 if from_module.is_some() {
+                                    //retry without from_module to see if model exists elsewhere
+                                    let symbols = model.get_main_symbols(session, None, &mut None);
+                                    if symbols.is_empty() {
+                                        let range = FileMgr::textRange_to_temporary_Range(&context.get(&S!("range")).unwrap().as_text_range());
+                                        diagnostics.push(Diagnostic::new(range,
+                                            Some(DiagnosticSeverity::ERROR),
+                                            Some(NumberOrString::String(S!("OLS30105"))),
+                                            Some(EXTENSION_NAME.to_string()),
+                                            S!("This model is inherited, but never declared."),
+                                            None,
+                                            None
+                                            )
+                                        );
+                                    } else {
+                                        let range = FileMgr::textRange_to_temporary_Range(&context.get(&S!("range")).unwrap().as_text_range());
+                                        let valid_modules: Vec<String> = symbols.iter().map(|s| match s.borrow().find_module() {
+                                            Some(sym) => sym.borrow().name().clone(),
+                                            None => S!("Unknown").clone()
+                                        }).collect();
+                                        diagnostics.push(Diagnostic::new(range,
+                                            Some(DiagnosticSeverity::ERROR),
+                                            Some(NumberOrString::String(S!("OLS30101"))),
+                                            Some(EXTENSION_NAME.to_string()),
+                                            format!("This model is not declared in the dependencies of your module. You should consider adding one of the following dependency: {:?}", valid_modules),
+                                            None,
+                                            None
+                                            )
+                                        );
+                                    }
+                                } else {
                                     let range = FileMgr::textRange_to_temporary_Range(&context.get(&S!("range")).unwrap().as_text_range());
                                     diagnostics.push(Diagnostic::new(range,
                                         Some(DiagnosticSeverity::ERROR),
-                                        Some(NumberOrString::String(S!("OLS30101"))),
+                                        Some(NumberOrString::String(S!("OLS30102"))),
                                         Some(EXTENSION_NAME.to_string()),
-                                        S!("This model is not in the dependencies of your module."),
+                                        S!("Unknown model. Check your addons path"),
                                         None,
                                         None
-                                        )
-                                    );
+                                    ));
                                 }
-                            } else {
-                                let range = FileMgr::textRange_to_temporary_Range(&context.get(&S!("range")).unwrap().as_text_range());
-                                diagnostics.push(Diagnostic::new(range,
-                                    Some(DiagnosticSeverity::ERROR),
-                                    Some(NumberOrString::String(S!("OLS30102"))),
-                                    Some(EXTENSION_NAME.to_string()),
-                                    S!("Unknown model. Check your addons path"),
-                                    None,
-                                    None
-                                ));
                             }
                         } else {
                             let range = FileMgr::textRange_to_temporary_Range(&context.get(&S!("range")).unwrap().as_text_range());