[IMP] estate, awesome_owl: mark property as sold only if accepted offers exist, remove unnecessary comments and fix linting.

- Added logic to check if any offers are present before marking the property as sold.
- Added logic to check if one of the offers is accepted before marking property as sold
- Removed unnecessary comments from files.
- Fixed linting issues from `utils.js`

Author: aarp-odoo

awesome_owl/static/src/utils.js

@@ -5,4 +5,4 @@ export const useAutoFocus = () => {
     onMounted(() => {
         inputRef.el?.focus();
     })
-}
+}

estate/models/estate_property.py

@@ -8,7 +8,6 @@
 
 
 class EstateProperty(models.Model):
-    # === Private attributes ===
     _name = 'estate.property'
     _description = 'Estate Test'
     _order = 'id desc'
@@ -19,9 +18,6 @@ class EstateProperty(models.Model):
         ('check_selling_price_positive', 'CHECK(selling_price > 0)', 'Selling price must be strictly positive.'),
     ]
 
-    # ---------------------
-    # Fields declaration
-    # ---------------------
     name = fields.Char(string='Name', required=True)
     description = fields.Char()
     postcode = fields.Char()
@@ -35,8 +31,6 @@ class EstateProperty(models.Model):
     garden = fields.Boolean()
     garden_area = fields.Integer()
     active = fields.Boolean(default=True)
-
-    # Selection fields
     garden_orientation = fields.Selection(
         [
             ('north', 'North'),
@@ -59,19 +53,11 @@ class EstateProperty(models.Model):
         copy=False,
         default='new'
     )
-
-    # Many2one fields
     property_type_id = fields.Many2one('estate.property.type', string='Property Type')
     salesman_id = fields.Many2one('res.users', string='Salesman', default=lambda self: self.env.user)
     buyer_id = fields.Many2one('res.partner', string='Buyer', copy=False)
-
-    # Many2many fields
     tag_ids = fields.Many2many('estate.property.tag', string='Tags')
-
-    # One2many fields
     offer_ids = fields.One2many('estate.property.offer', 'property_id', string='Offers')
-
-    # Computed fields
     total_area = fields.Integer(string='Total Area', compute='_compute_total_area')
     best_price = fields.Float(string='Best Offer', compute='_compute_best_price')
 
@@ -129,8 +115,15 @@ def _unlink_except_new_or_cancelled(self):
     # ----------------------
     def action_mark_sold(self):
         for record in self:
+            if not record.offer_ids:
+                raise UserError("You can mark this property as sold because there are no offers.")
             if record.state == 'cancelled':
                 raise UserError('Cancelled properties cannot be marked as sold.')
+
+            accepted_offer = record.offer_ids.filtered(lambda o: o.status == 'accepted')
+            if not accepted_offer:
+                raise UserError("You must accept an offer before marking the property as sold.")
+
             record.state = 'sold'
         return True
 

estate/models/estate_property_offer.py

@@ -8,7 +8,6 @@
 
 
 class EstatePropertyOffer(models.Model):
-    # === Private attributes ===
     _name = 'estate.property.offer'
     _description = 'Offers for all the property listings.'
     _order = 'price desc'
@@ -18,13 +17,8 @@ class EstatePropertyOffer(models.Model):
         ('check_price_positive', 'CHECK(price > 0)', 'Offer price must be strictly positive.'),
     ]
 
-    # ------------------------
-    # Fields declaration
-    # -------------------------
     price = fields.Float(string='Price')
     validity = fields.Integer(default=7)
-
-    # Selection fields
     status = fields.Selection(
         [
             ('accepted', 'Accepted'),
@@ -33,11 +27,7 @@ class EstatePropertyOffer(models.Model):
         string='Status',
         copy=False
     )
-
-    # Computed fields
     date_deadline = fields.Date(compute='_compute_date_deadline', inverse='_inverse_date_deadline', store=True)
-
-    # Many2one fields
     partner_id = fields.Many2one('res.partner', required=True)
     property_id = fields.Many2one('estate.property', string='Property Name', required=True)
     property_type_id = fields.Many2one(related='property_id.property_type_id', store=True)

estate/models/estate_property_tag.py

@@ -2,8 +2,7 @@
 from odoo import fields, models
 
 
-class EstatePropertyType(models.Model):
-    # === Private attributes ===
+class EstatePropertyTag(models.Model):
     _name = 'estate.property.tag'
     _description = 'Property tags to represent the property.'
     _order = 'name'
@@ -13,6 +12,5 @@ class EstatePropertyType(models.Model):
         ('unique_tag_name', 'UNIQUE(name)', 'Tag name must be unique.'),
     ]
 
-    # === Fields declaration ===
     name = fields.Char('Property Tag', required=True)
     color = fields.Integer(string="Color")

estate/models/estate_property_type.py

@@ -3,7 +3,6 @@
 
 
 class EstatePropertyType(models.Model):
-    # === Private attributes ===
     _name = 'estate.property.type'
     _description = 'Property types for available in the business.'
     _order = 'sequence, name'
@@ -13,15 +12,10 @@ class EstatePropertyType(models.Model):
         ('unique_type_name', 'UNIQUE(name)', 'Type name must be unique.')
     ]
 
-    # === Fields declaration ===
     name = fields.Char(required=True)
     sequence = fields.Integer('Sequence', default=10)
-
-    # One2many fields
     property_ids = fields.One2many('estate.property', 'property_type_id', string='Properties')
     offer_ids = fields.One2many('estate.property.offer', 'property_type_id', string='Offers')
-
-    # Compute fields
     offer_count = fields.Integer(string='Number of Offers', compute='_compute_offer_count')
 
     # === Compute methods ===