[FIX] util/records: correctly replace values in JSON

The `\y` group cannot be used before a non word character otherwise we
won't math anything.
```
> select REGEXP_MATCH('a <x> b', '\y<x>\y')
+--------------+
| regexp_match |
|--------------|
| <null>       |
+--------------+
> select REGEXP_MATCH('a <x> b', '<x>')
+--------------+
| regexp_match |
|--------------|
| ['<x>']      |
+--------------+
```

Also use `psycopg2.extras.Json` class to escape a string value for the
match. Example result:
```
>>> print(str(Json('\y t-if="True" >')))
'"\\\\y t-if=\\"True\\" >"'
>>> print(str(Json('\y' + re.escape(' t-if="True" >'))))
'"\\\\y\\\\ t\\\\-if=\\"True\\"\\\\ >"'
```
Note that we must remove the surrounding `'`.

opw-3526516

Part of odoo/upgrade#5233

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: aj-fuentes

src/base/tests/test_util.py

@@ -753,7 +753,9 @@ def test_ensure_xmlid_match_record(self):
 
     @unittest.skipUnless(util.version_gte("16.0"), "Only work on Odoo >= 16")
     def test_replace_in_all_jsonb_values(self):
-        test_partner_title = self.env["res.partner.title"].create({"name": "object.number object.numbercombined"})
+        test_partner_title = self.env["res.partner.title"].create(
+            {"name": r"""object.number '<"x">\y object.numbercombined"""}
+        )
 
         pattern_old = re.compile(r"\b\.number\b")
         pattern_new = re.compile(r"\b\.name\b")
@@ -765,11 +767,17 @@ def test_replace_in_all_jsonb_values(self):
 
         extra_filter = self.env.cr.mogrify("t.id = %s", (test_partner_title.id,)).decode()
         util.replace_in_all_jsonb_values(self.env.cr, "res_partner_title", "name", ".number", ".name", extra_filter)
+        util.replace_in_all_jsonb_values(
+            self.env.cr, "res_partner_title", "name", r"""'<"x">\y""", "GONE", extra_filter
+        )
         test_partner_title.invalidate_recordset(["name"])
 
         self.assertRegex(test_partner_title.name, pattern_new)
         self.assertRegex(test_partner_title.name, pattern_notouch)
         self.assertNotRegex(test_partner_title.name, pattern_old)
+        # ensure replacing works for patterns that do not start with a valid word start \w
+        # also ensure the replace works for multiple embedded quotes
+        self.assertEqual(test_partner_title.name, "object.name GONE object.numbercombined")
 
 
 class TestMisc(UnitTestCase):

src/util/records.py

@@ -1147,8 +1147,16 @@ def replace_in_all_jsonb_values(cr, table, column, old, new, extra_filter=None):
     execute the query in parallel.
     `old` can be a simple term (str) or a regexp (util.PGRegexp)
     """
-    re_old = old if isinstance(old, PGRegexp) else r"\y{}\y".format(re.escape(old))
-    match = 'exists($.* ? (@ like_regex "{}"))'.format(re_old.replace("\\", "\\\\").replace('"', r"\""))
+    re_old = (
+        old
+        if isinstance(old, PGRegexp)
+        else "{}{}{}".format(
+            r"\y" if re.match(r"\w", old[0]) else "",
+            re.escape(old),
+            r"\y" if re.match(r"\w", old[-1]) else "",
+        )
+    )
+    match = str(Json(re_old))[1:-1]  # escapes re_old into json string
 
     if extra_filter is None:
         extra_filter = "true"
@@ -1161,7 +1169,7 @@ def replace_in_all_jsonb_values(cr, table, column, old, new, extra_filter=None):
                FROM "{table}" t
                JOIN LATERAL jsonb_each_text(t."{column}") v
                  ON true
-              WHERE jsonb_path_match(t."{column}", %s)
+              WHERE jsonb_path_match(t."{column}", 'exists($.* ? (@ like_regex {match}))')
                 AND {extra_filter}
               GROUP BY t.id
         )
@@ -1172,7 +1180,7 @@ def replace_in_all_jsonb_values(cr, table, column, old, new, extra_filter=None):
         """.format(
             **locals()
         ),
-        [re_old, new, match],
+        [re_old, new],
     ).decode()
 
     if "{parallel_filter}" in query: