[FIX] util/records: fix update from xml of menus

Updating menus that are a child of another menu and that
do not have the field `parent_id`, would result in the loss
of the link between the menu and its parent.

In order to retain this link, we obtain the value for `parent_id`
and then explicitly inject this field to the source xml.

Part of odoo/upgrade#5163

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: diagnoza

src/base/tests/test_util.py

@@ -625,6 +625,23 @@ def test_update_record_from_xml(self):
         for key, value in data_before.items():
             self.assertEqual(record[key], value)
 
+        # reset all fields on a <menuitem>
+        xmlid = "base.menu_security"
+        data_after = {"name": "ATotallyValidSecurityMenu", "sequence": 112, "parent_id": self.env["ir.ui.menu"]}
+        record = self.env.ref(xmlid)
+        data_before = {key: record[key] for key in data_after}
+        for key, value in data_after.items():
+            record.write({key: value})
+            self.assertEqual(record[key], value)
+
+        util.update_record_from_xml(self.env.cr, xmlid, ensure_references=True)
+        if util.version_gte("16.0"):
+            record.invalidate_recordset(["name"])
+        else:
+            record.invalidate_cache(["name"], record.ids)
+        for key, value in data_before.items():
+            self.assertEqual(record[key], value)
+
         # reset all fields on a <template>
         template_xmlid = "base.contact_name"
         record = self.env.ref(template_xmlid)

src/util/records.py

@@ -770,7 +770,18 @@ def add_ref(ref):
         with file_open(os.path.join(from_module, f)) as fp:
             doc = lxml.etree.parse(fp)
             for node in doc.xpath(xpath):
+                parent = node.getparent()
                 new_root[0].append(node)
+
+                if node.tag == "menuitem" and parent.tag == "menuitem" and "parent_id" not in node.attrib:
+                    new_root[0].append(
+                        lxml.builder.E.record(
+                            lxml.builder.E.field(name="parent_id", ref=parent.attrib["id"]),
+                            model="ir.ui.menu",
+                            id=node.attrib["id"],
+                        )
+                    )
+
                 if node.tag == "template":
                     template = True
                 if ensure_references: