[FIX] util.force_upgrade_of_fresh_module

The purpose of this function is to cheat about upgrade status of a
"to install" module.

Before saas~18.2:
As the `MigrationManager` only handle the "to upgrade" modules, we need
a way to tell the ORM that, even it is in "to upgrade", the module
should be loaded in "init" mode (this control the behavior of the
`forcecreate` flag of the records). That was done using the global
`config["init"]` dict.

Since saas~18.2:
Now, this is done the other way around. It's the `MigrationManager`
that is aware of "to install" modules that upgrade scripts should be
executed. This is done via the `_force_upgrade_scripts` set on the
registry. The module state stay in "to install".

In either case, we should set the module version to the version of the
calling script.

Note: this only affect the `init=True` calling mode (default). When
called with `init=False`, we always lie about the module state and don't
tell the ORM about it.

Oversight of #176

closes #291

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: KangOl

src/util/modules.py

@@ -897,26 +897,26 @@ def _force_upgrade_of_fresh_module(cr, module, init, version):
     # Low level implementation
     # Force module state to be in `to upgrade`.
     # Needed for migration script execution. See http://git.io/vnF7f
-    if version_gte("saas~18.2") and init:
-        env_ = env(cr)
-        env_.registry._force_upgrade_scripts.add(module)
-        return
-
+    state = "to install" if init and version_gte("saas~18.2") else "to upgrade"
     cr.execute(
         """
             UPDATE ir_module_module
-               SET state='to upgrade',
+               SET state=%s,
                    latest_version=%s
              WHERE name=%s
                AND state='to install'
          RETURNING id
     """,
-        [version, module],
+        [state, version, module],
     )
     if init and cr.rowcount:
-        # Force module in `init` mode beside its state is forced to `to upgrade`
-        # See http://git.io/vnF7O
-        odoo.tools.config["init"][module] = "oh yeah!"
+        if version_gte("saas~18.2"):
+            env_ = env(cr)
+            env_.registry._force_upgrade_scripts.add(module)
+        else:
+            # Force module in `init` mode beside its state is forced to `to upgrade`
+            # See http://git.io/vnF7O
+            odoo.tools.config["init"][module] = "oh yeah!"
 
 
 # for compatibility