[FIX] util/fields: also convert inherits fields

When converting fields types we need to continue to inherits. Before we
avoided that because the column may be missing but it leads to situations
where custom manual fields are not updated properly.

For example if we add a custom manual field in `product.packaging.x_pdesc`
related to `product_id.description`. Without this patch the upgrade
`x_pdesc` is still of `ttype=text`. With this patch:

```
test_14_15=> select id,model,name,state,related,related_field_id,ttype from ir_model_fields where name like 'x\_%' or (model like 'product.%' and name='description')
+------+-------------------+-------------+--------+-----------------------------+------------------+-------+
| id   | model             | name        | state  | related                     | related_field_id | ttype |
|------+-------------------+-------------+--------+-----------------------------+------------------+-------|
| 3068 | product.packaging | x_pdesc     | manual | product_id.description      | 2635             | html  |
| 2516 | product.template  | description | base   | <null>                      | <null>           | html  |
| 2635 | product.product   | description | base   | product_tmpl_id.description | <null>           | html  |
+------+-------------------+-------------+--------+-----------------------------+------------------+-------+
```

There are many specific fixes to update manual related fields to
`product.product.description`.

Also fix missing function parameter. `convert_field_to_html` expects a
cursor as first parameter.

closes #34

Signed-off-by: Christophe Simonis (chs) <[email protected]>
Co-authored-by: "Christophe Simonis" <[email protected]>

Author: aj-fuentes

src/util/fields.py

@@ -488,23 +488,24 @@ def rename_field(cr, model, old, new, update_references=True, domain_adapter=Non
 def convert_field_to_html(cr, model, field, skip_inherit=()):
     _validate_model(model)
     table = table_of_model(cr, model)
-    jsonb_column = column_type(cr, table, field) == "jsonb"
-    if jsonb_column:
-        query = """
-            WITH html_values AS (
-                SELECT id, jsonb_object_agg(t.key, {2}) AS value
-                  FROM "{0}", jsonb_each_text("{1}") AS t
-                 WHERE {{parallel_filter}}
-              GROUP BY id
-            )
-            UPDATE "{0}"
-               SET "{1}" = h.value
-              FROM html_values AS h
-             WHERE "{0}".id = h.id
-        """.format(table, field, pg_text2html("t.value"))
-    else:
-        query = 'UPDATE "{0}" SET "{1}" = {2} WHERE "{1}" IS NOT NULL'.format(table, field, pg_text2html(field))
-    parallel_execute(cr, explode_query_range(cr, query, table=table))
+    if column_exists(cr, table, field):  # only exists for list-based inherits (not for dict-based)
+        jsonb_column = column_type(cr, table, field) == "jsonb"
+        if jsonb_column:
+            query = """
+                WITH html_values AS (
+                    SELECT id, jsonb_object_agg(t.key, {2}) AS value
+                      FROM "{0}", jsonb_each_text("{1}") AS t
+                     WHERE {{parallel_filter}}
+                  GROUP BY id
+                )
+                UPDATE "{0}"
+                   SET "{1}" = h.value
+                  FROM html_values AS h
+                 WHERE "{0}".id = h.id
+            """.format(table, field, pg_text2html("t.value"))
+        else:
+            query = 'UPDATE "{0}" SET "{1}" = {2} WHERE "{1}" IS NOT NULL'.format(table, field, pg_text2html(field))
+        parallel_execute(cr, explode_query_range(cr, query, table=table))
 
     # Update translations
     if table_exists(cr, "ir_translation"):
@@ -532,8 +533,7 @@ def convert_field_to_html(cr, model, field, skip_inherit=()):
         [field, model],
     )
     for inh in for_each_inherit(cr, model, skip_inherit):
-        if not inh.via:
-            convert_field_to_html(inh.model, field, skip_inherit=skip_inherit)
+        convert_field_to_html(cr, inh.model, field, skip_inherit=skip_inherit)
 
 
 def convert_field_to_property(