[IMP] util/records.py: optimize update_record_from_xml's recursive mode

update_record_from_xml has an optional argument (ensure_references) that
will recursively update all refs referred to by the record.

However, at the moment, its implementation doesn't keep good track of
which refs already have been updated, leading to far more updates than
necessary.

For example, if we have the following tree of references:
```
Record A
    - Record B
    - Record C
        - Record B
        - Record D
        - Record E
    - Record F
        - Record B
        - Record C
        - Record D
        - Record E
```
(which is quite common since lots of records end up referring to some
objects such as `base.main_company`, `base.group_user`,
`base.user_root`, `base.group_system`, etc.)

we will end up calling update_record_from_xml 11 times whereas we only
need to call it 6 times (one for each of Records A-F).

That's a lot of extra SQL queries.

Part of odoo/upgrade#5236

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: antoine162

src/util/records.py

@@ -714,6 +714,28 @@ def update_record_from_xml(
     from_module=None,
     reset_translations=(),
     ensure_references=False,
+):
+    __update_record_from_xml(
+        cr,
+        xmlid,
+        reset_write_metadata=reset_write_metadata,
+        force_create=force_create,
+        from_module=from_module,
+        reset_translations=reset_translations,
+        ensure_references=ensure_references,
+        done_refs=set(),
+    )
+
+
+def __update_record_from_xml(
+    cr,
+    xmlid,
+    reset_write_metadata,
+    force_create,
+    from_module,
+    reset_translations,
+    ensure_references,
+    done_refs,
 ):
     from .modules import get_manifest
 
@@ -798,14 +820,20 @@ def add_ref(ref):
                         for ref_match in re.finditer(r"\bref\((['\"])(.*?)\1\)", eval_node.get("eval")):
                             add_ref(ref_match.group(2))
 
-    done_refs = set()
+    done_refs.add(xmlid)
     for ref in extra_references:
         if ref in done_refs:
             continue
-        done_refs.add(ref)
         _logger.info("Update of %s - ensuring the reference %s exists", xmlid, ref)
-        update_record_from_xml(
-            cr, ref, reset_write_metadata=reset_write_metadata, force_create=True, ensure_references=True
+        __update_record_from_xml(
+            cr,
+            ref,
+            reset_write_metadata=reset_write_metadata,
+            force_create=True,
+            from_module=from_module,
+            reset_translations=reset_translations,
+            ensure_references=True,
+            done_refs=done_refs,
         )
 
     cr_or_env = env(cr) if version_gte("saas~16.2") else cr