[chore] lint all files

closes #232

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: KangOl

src/base/17.0.1.3/attr_domains2expr.py

@@ -111,9 +111,9 @@ def mod2bool_str(s):
     Note that 0 and 1 are left unchanged since they have the same True/False meaning in Python.
     """
     ss = s.lower()
-    if ss in "yes true on".split():
+    if ss in ["yes", "true", "on"]:
         return "True"
-    if ss in "no false off".split():
+    if ss in ["no", "false", "off"]:
         return "False"
     return s
 

src/util/convert_bootstrap.py

@@ -856,11 +856,37 @@ class BootstrapConverter:
             RenameAttribute.op("data-display", "data-bs-display", "[not(@data-snippet='s_countdown')]"),
             *[
                 RenameAttribute.op(f"data-{attr}", f"data-bs-{attr}")
-                for attr in (
-                    "animation attributes autohide backdrop body container content delay dismiss focus"
-                    " interval margin-right no-jquery offset original-title padding-right parent placement"
-                    " ride sanitize show slide slide-to spy target toggle touch trigger whatever"
-                ).split(" ")
+                for attr in [
+                    "animation",
+                    "attributes",
+                    "autohide",
+                    "backdrop",
+                    "body",
+                    "container",
+                    "content",
+                    "delay",
+                    "dismiss",
+                    "focus",
+                    "interval",
+                    "margin-right",
+                    "no-jquery",
+                    "offset",
+                    "original-title",
+                    "padding-right",
+                    "parent",
+                    "placement",
+                    "ride",
+                    "sanitize",
+                    "show",
+                    "slide",
+                    "slide-to",
+                    "spy",
+                    "target",
+                    "toggle",
+                    "touch",
+                    "trigger",
+                    "whatever",
+                ]
             ],
             # popover
             (CSS(".popover .arrow"), [ReplaceClasses("arrow", "popover-arrow")]),

src/util/jinja_to_qweb.py

@@ -491,14 +491,14 @@ def verify_upgraded_jinja_fields(cr):
 def is_converted_template_valid(env, template_before, template_after, model_name, record_id, engine="inline_template"):
     render_before = None
     with contextlib.suppress(Exception):
-        render_before = _render_template_jinja(env, Markup(template_before), model_name, record_id)
+        render_before = _render_template_jinja(env, template_before, model_name, record_id)
 
     render_after = None
     if render_before is not None:
         try:
             with mute_logger("odoo.addons.mail.models.mail_render_mixin"):
                 render_after = env["mail.render.mixin"]._render_template(
-                    Markup(template_after), model_name, [record_id], engine=engine
+                    template_after, model_name, [record_id], engine=engine
                 )[record_id]
         except Exception:
             pass
@@ -604,4 +604,4 @@ def _render_template_jinja(env, template_txt, model, res_id):
     render_result = template.render(variables)
     if render_result == "False":
         render_result = ""
-    return Markup(render_result)
+    return render_result

src/util/misc.py

@@ -55,8 +55,8 @@ def wrapper(*args, **kwargs):
 # copied from odoo as older OpenERP versions doesn't have it
 def str2bool(s, default=None):
     s = unicode(s).lower()
-    y = "y yes 1 true t on".split()
-    n = "n no 0 false f off".split()
+    y = ["y", "yes", "1", "true", "t", "on"]
+    n = ["n", "no", "0", "false", "f", "off"]
     if s not in (y + n):
         if default is None:
             raise ValueError("Use 0/1/yes/no/true/false/on/off")

src/util/models.py

@@ -171,7 +171,7 @@ def remove_model(cr, model, drop_table=True, ignore_m2m=()):
     [mod_id, mod_label] = cr.fetchone() or [None, model]
     if mod_id:
         # some required fk are in "ON DELETE SET NULL/RESTRICT".
-        for tbl in "base_action_rule base_automation google_drive_config".split():
+        for tbl in ["base_action_rule", "base_automation", "google_drive_config"]:
             if column_exists(cr, tbl, "model_id"):
                 cr.execute("DELETE FROM {0} WHERE model_id=%s".format(tbl), [mod_id])
         cr.execute("DELETE FROM ir_model_relation WHERE model=%s", (mod_id,))

src/util/spreadsheet/tokenizer.py

@@ -75,7 +75,7 @@ def replace_special_spaces(text):
 
 
 POSTFIX_UNARY_OPERATORS = ["%"]
-OPERATORS = "+,-,*,/,:,=,<>,>=,>,<=,<,^,&".split(",") + POSTFIX_UNARY_OPERATORS
+OPERATORS = ["+", "-", "*", "/", ":", "=", "<>", ">=", ">", "<=", "<", "^", "&"] + POSTFIX_UNARY_OPERATORS
 
 
 def tokenize(string, locale=DEFAULT_LOCALE):