[FIX] util/modules: remove server acts after crons

During module uninstall we might encounter a fkey constraint
'ir_cron_ir_actions_server_id_fkey' that prevents the removal
of the module's server action records.
Ideally, the cron is removed before the actions thanks to the
select xmlids and order by id, but in older versions there was
no server action and they were created in 10.saas~14 for all
existing crons.

Part of odoo/upgrade#5308

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: jjmaksoud

src/util/modules.py

@@ -108,7 +108,7 @@ def uninstall_module(cr, module):
     )
 
     # delete data
-    model_ids, field_ids, menu_ids = [], [], []
+    model_ids, field_ids, menu_ids, server_action_ids = [], [], [], []
     cr.execute(
         """
             SELECT model, res_id
@@ -133,6 +133,8 @@ def uninstall_module(cr, module):
             field_ids.append(res_id)
         elif model == "ir.ui.menu":
             menu_ids.append(res_id)
+        elif model == "ir.actions.server":
+            server_action_ids.append(res_id)
         else:
             to_group.append((model, res_id))
 
@@ -142,6 +144,8 @@ def uninstall_module(cr, module):
                 remove_view(cr, view_id=res_id, silent=True)
         else:
             remove_records(cr, model, [it[1] for it in group])
+    if server_action_ids:
+        remove_records(cr, "ir.actions.server", server_action_ids)
 
     if menu_ids:
         remove_menus(cr, menu_ids)