[FIX] util/records: ensure no duplicates for m2m when replacing refs

There are two ways an update of references could fail in an m2m table.
If there is a record already in the table matching the currently updated
row. Example:
```
 mapping old new
          1   3
          2   3
 Fails for:
 m2m fk col2
     1   x  -updated-> 3  x !error
     3   x
```
Or, if we have multiple ids mapped to the same new one. Example:
```
 mapping old new
          1   3
          2   3
 Fails for:
 m2m fk col2
     1   x  -updated-> 3  x
     2   x  -updated-> 3  x !error
```

Part-of: #33
Co-authored-by: "Christophe Simonis" <[email protected]>

Author: aj-fuentes

src/base/tests/test_util.py

@@ -1012,3 +1012,26 @@ def test_format_ColumnList(self):
             util.format_query(cr, "SELECT {c} id", c=no_columns.using(trailing_comma=True)),
             "SELECT  id",
         )
+
+
+class TestReplaceRecordReferences(UnitTestCase):
+    def test_m2m_no_conflict(self):
+        cr = self.env.cr
+        g1 = self.env["res.groups"].create({"name": "G1"})
+        g2 = self.env["res.groups"].create({"name": "G2"})
+        g3 = self.env["res.groups"].create({"name": "G3"})
+        mapping = {g1.id: g3.id, g2.id: g3.id}
+
+        u1 = self.env["res.users"].create({"login": "U1", "name": "U1"})
+        u1.groups_id = g1 | g3
+        self.assertEqual(u1.groups_id.ids, [g1.id, g3.id])
+        util.replace_record_references_batch(cr, mapping, "res.groups")
+        util.invalidate(u1)
+        self.assertEqual(u1.groups_id.ids, [g3.id])
+
+        u2 = self.env["res.users"].create({"login": "U2", "name": "U2"})
+        u2.groups_id = g1 | g2
+        self.assertEqual(u2.groups_id.ids, [g1.id, g2.id])
+        util.replace_record_references_batch(cr, mapping, "res.groups")
+        util.invalidate(u2)
+        self.assertEqual(u2.groups_id.ids, [g3.id])

src/util/records.py

@@ -34,6 +34,7 @@
     column_updatable,
     explode_execute,
     explode_query_range,
+    format_query,
     get_columns,
     get_fk,
     get_value_or_en_translation,
@@ -1024,7 +1025,7 @@ def replace_record_references_batch(cr, id_mapping, model_src, model_dst=None, r
         fk_def = []
 
         model_src_table = table_of_model(cr, model_src)
-        for table, fk, _, _ in get_fk(cr, model_src_table):
+        for table, fk, _, _ in get_fk(cr, model_src_table, quote_ident=False):
             if table in ignores:
                 continue
             query = """
@@ -1036,9 +1037,33 @@ def replace_record_references_batch(cr, id_mapping, model_src, model_dst=None, r
 
             if not column_exists(cr, table, "id"):
                 # seems to be a m2m table. Avoid duplicated entries
-                cols = get_columns(cr, table, ignore=(fk,))
-                assert len(cols) == 1  # it's a m2, should have only 2 columns
-                col2 = cols[0]
+                (col2,) = get_columns(cr, table, ignore=(fk,)).iter_unquoted()
+
+                # handle possible duplicates after update of m2m table
+                cr.execute(
+                    format_query(
+                        cr,
+                        """
+                        WITH rr2 AS (
+                            SELECT array_agg(t.{fk} ORDER BY t.{fk}) AS olds,
+                                   r.new AS new,
+                                   t.{col2} AS col2
+                              FROM {table} t
+                              JOIN _upgrade_rrr r
+                                ON r.old = t.{fk}
+                             GROUP BY r.new, t.{col2}
+                        )
+                        DELETE
+                          FROM {table} t
+                         USING rr2 r
+                         WHERE t.{col2} = r.col2
+                           AND t.{fk} = ANY(r.olds[2:])
+                        """,
+                        table=table,
+                        fk=fk,
+                        col2=col2,
+                    )
+                )
                 query += """
                     AND NOT EXISTS(SELECT 1 FROM {table} e WHERE e.{col2} = t.{col2} AND e.{fk} = r.new);
 
@@ -1062,10 +1087,10 @@ def replace_record_references_batch(cr, id_mapping, model_src, model_dst=None, r
                            AND t.{fk} = t.{col2};
                     """
 
-                cr.execute(query.format(table=table, fk=fk, col2=col2))
+                cr.execute(format_query(cr, query, table=table, fk=fk, col2=col2))
 
             else:  # it's a model
-                fmt_query = cr.mogrify(query.format(table=table, fk=fk)).decode()
+                fmt_query = cr.mogrify(format_query(cr, query, table=table, fk=fk)).decode()
                 parallel_execute(cr, explode_query_range(cr, fmt_query, table=table, alias="t"))
 
                 # track default values to update