Skip to content

Commit 6d0e9a8

Browse files
authored
Fix test of threaded simulate (#829)
1 parent c6f3d19 commit 6d0e9a8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

docs/src/changelog.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
- Throw a warning and limit threads when there are fewer nodes than threads
1515
available (#823)
1616
- Fixed [`simulate`](@ref) with [`Threaded`](@ref) to spawn chunked threads
17-
instead of one thread for each replication (#824) (#828)
17+
instead of one thread for each replication (#824) (#828) (#829)
1818

1919
### Other
2020

test/plugins/threaded.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,9 @@ function test_threaded_warning()
9898
(:warn,),
9999
SDDP.simulate(model, 10; parallel_scheme, custom_recorders = recorder),
100100
)
101-
@test all(all(x[:thread_id] == 1 for x in r) for r in ret)
101+
# This might not be true because of thread migration. I'm not sure how to
102+
# test that we've spawned only one thread.
103+
# @test all(all(x[:thread_id] == 1 for x in r) for r in ret)
102104
return
103105
end
104106

0 commit comments

Comments
 (0)