tests: minor cleanup in tests (NOAA-GFDL#181)

* tests: minor cleanup in tests

- add `__init__.py` files where missing
- `List` -> `list` and `Tuple` -> `tuple`
- NDSL has no `Namelist` anymore
- cleanup unused import and code in `test_init_from_geos.py`

* remove stale reference to ndsl.Namelist

Author: romanc

tests/main/__init__.py

@@ -1,6 +1,6 @@
 import unittest.mock
 from datetime import datetime, timedelta
-from typing import Literal, Tuple
+from typing import Literal
 
 import pytest
 
@@ -22,7 +22,7 @@ def get_driver_config(
     hours: int = 0,
     minutes: int = 0,
     seconds: int = 0,
-    layout: Tuple[int, int] = (1, 1),
+    layout: tuple[int, int] = (1, 1),
     frequency: int = 1,
     output_initial_state=False,
     start_time_type: Literal["timedelta", "datetime"] = "timedelta",

tests/main/driver/test_driver.py

@@ -1,6 +1,5 @@
 import os
 from pathlib import Path
-from typing import List
 
 import pytest
 import yaml
@@ -9,7 +8,7 @@
 from tests.paths import EXAMPLE_CONFIGS_DIR, JENKINS_CONFIGS_DIR
 
 
-TESTED_CONFIGS: List[str] = [
+TESTED_CONFIGS: list[str] = [
     "baroclinic_c12.yaml",
     "baroclinic_c12_dp.yaml",
     "baroclinic_c12_explicit_physics.yaml",
@@ -20,7 +19,7 @@
     "baroclinic_c48_6ranks_serialbox_test.yaml",
     "analytic_test.yaml",
 ]
-EXCLUDED_CONFIGS: List[str] = [
+EXCLUDED_CONFIGS: list[str] = [
     # We don't test serialbox example because it loads namelist
     # filepath that are not in git
     "baroclinic_c12_from_serialbox.yaml",
@@ -33,13 +32,13 @@
 ]
 
 
-TESTED_JENKINS_CONFIGS: List[str] = [
+TESTED_JENKINS_CONFIGS: list[str] = [
     "baroclinic_c48_6ranks_dycore_only.yaml",
     "baroclinic_c192_6ranks.yaml",
     "baroclinic_c192_54ranks.yaml",
 ]
 
-EXCLUDED_JENKINS_CONFIGS: List[str] = [
+EXCLUDED_JENKINS_CONFIGS: list[str] = [
     # We don't test serialbox example because it loads namelist
     # filepath that are not in git
     "baroclinic_c48_6ranks_dycore_only_serialbox.yaml",
@@ -61,7 +60,7 @@
     ],
 )
 def test_all_configs_tested_or_excluded(
-    config_dir: Path, tested_configs: List[str], excluded_configs: List[str]
+    config_dir: Path, tested_configs: list[str], excluded_configs: list[str]
 ):
     """
     If any configs are not tested or excluded, add them to TESTED_CONFIGS or
@@ -84,7 +83,7 @@ def test_all_configs_tested_or_excluded(
         pytest.param(JENKINS_CONFIGS_DIR, TESTED_JENKINS_CONFIGS),
     ],
 )
-def test_example_config_can_initialize(path: Path, file_list: List[str]):
+def test_example_config_can_initialize(path: Path, file_list: list[str]):
     for file_name in file_list:
         with open(path / file_name, "r") as f:
             config = DriverConfig.from_dict(yaml.safe_load(f))

tests/main/driver/test_example_configs.py

@@ -2,7 +2,6 @@
 from dataclasses import fields
 from datetime import timedelta
 from pathlib import Path
-from typing import Tuple
 
 import pyfv3.initialization.analytic_init as ai
 from ndsl import (
@@ -27,7 +26,7 @@
 from pyfv3.initialization.analytic_init import AnalyticCase
 
 
-def setup_dycore() -> Tuple[DynamicalCore, DycoreState, Timer]:
+def setup_dycore() -> tuple[DynamicalCore, DycoreState, Timer]:
     backend = Backend("st:numpy:cpu:IJK")
     config = DynamicalCoreConfig(
         layout=(1, 1),

tests/main/fv3core/__init__.py

@@ -1,6 +1,5 @@
 import f90nml
 import numpy as np
-import pytest  # noqa
 
 from ndsl.config import Backend
 from pace import NullComm
@@ -108,11 +107,6 @@ def test_geos_wrapper():
         namelist["nx_tile"] + 2 * nhalo + 1,
         namelist["nz"],
     )
-    shape_z_interface = (
-        namelist["nx_tile"] + 2 * nhalo,
-        namelist["nx_tile"] + 2 * nhalo,
-        namelist["nz"] + 1,
-    )
     shape2d = (
         namelist["nx_tile"] + 2 * nhalo,
         namelist["nx_tile"] + 2 * nhalo,