Commit f912b51
committed
fix: CI failures in combined dependabot PR
This commit fixes multiple CI failures that occurred after merging the dependabot PRs:
1. **Lint job failure**: The workflow was trying to run 'just setup-gha' before
installing the 'just' command itself. Fixed by adding the necessary setup steps
(just, uv, mise) before the setup-gha step, matching the pattern used in main.yml.
2. **SASS build failure - @primer/css v22 breaking change**: The updated @primer/css
package (v21→v22) removed @primer/view-components as a direct dependency, but
navigation/tabnav.scss still imports from it. This caused a 'Can't find stylesheet'
error. Fixed by:
- Keeping @primer/css at ~21 (latest v21.x)
- Adding @primer/view-components as an explicit dependency
- Configuring SASS to silence deprecation warnings from @primer/css's use of
deprecated @import syntax (which we cannot control)
3. **Code formatting**: tasks.py needed reformatting with ruff.
4. **Terraform lint failure**: The lint-terraform recipe needs to run 'tofu init'
before 'tofu validate' to download modules. Added 'tofu init -backend=false'
before validation.
Changes:
- .github/workflows/pr.yml: Add just/uv/mise installation steps before setup-gha
- package.json: Keep @primer/css at ~21, add @primer/view-components dependency
- pelicanconf.py: Add SASS_EXTRA_ARGS to silence import/global-builtin deprecations
- tasks.py: Reformatted with ruff
- justfile: Add 'tofu init -backend=false' before validation in lint-terraform
The build now succeeds both locally and should pass in CI.File tree
8 files changed
+667
-345
lines changed- .github/workflows
8 files changed
+667
-345
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
23 | 30 | | |
24 | 31 | | |
25 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
| 128 | + | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
0 commit comments