Skip to content

Commit f912b51

Browse files
committed
fix: CI failures in combined dependabot PR
This commit fixes multiple CI failures that occurred after merging the dependabot PRs: 1. **Lint job failure**: The workflow was trying to run 'just setup-gha' before installing the 'just' command itself. Fixed by adding the necessary setup steps (just, uv, mise) before the setup-gha step, matching the pattern used in main.yml. 2. **SASS build failure - @primer/css v22 breaking change**: The updated @primer/css package (v21→v22) removed @primer/view-components as a direct dependency, but navigation/tabnav.scss still imports from it. This caused a 'Can't find stylesheet' error. Fixed by: - Keeping @primer/css at ~21 (latest v21.x) - Adding @primer/view-components as an explicit dependency - Configuring SASS to silence deprecation warnings from @primer/css's use of deprecated @import syntax (which we cannot control) 3. **Code formatting**: tasks.py needed reformatting with ruff. 4. **Terraform lint failure**: The lint-terraform recipe needs to run 'tofu init' before 'tofu validate' to download modules. Added 'tofu init -backend=false' before validation. Changes: - .github/workflows/pr.yml: Add just/uv/mise installation steps before setup-gha - package.json: Keep @primer/css at ~21, add @primer/view-components dependency - pelicanconf.py: Add SASS_EXTRA_ARGS to silence import/global-builtin deprecations - tasks.py: Reformatted with ruff - justfile: Add 'tofu init -backend=false' before validation in lint-terraform The build now succeeds both locally and should pass in CI.
3 parents 9137be5 + aa44aed + abbb8a2 commit f912b51

File tree

8 files changed

+667
-345
lines changed

8 files changed

+667
-345
lines changed

.github/workflows/pr.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,19 @@ jobs:
1414
lint:
1515
name: Lint
1616
runs-on: ubuntu-latest
17+
permissions:
18+
contents: read # only needed for private repos
1719
steps:
1820
- name: Checkout repository
1921
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
2022
with:
2123
persist-credentials: false
2224

25+
- name: Install just
26+
uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
27+
- name: Install uv
28+
uses: astral-sh/setup-uv@7edac99f961f18b581bbd960d59d049f04c0002f # v6.4.1
29+
- uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1
2330
- name: Set up dependencies
2431
run: just setup-gha
2532

justfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ lint-terraform:
124124
exit 0
125125
fi
126126
tofu fmt -check -recursive .
127+
# Initialize terraform before validation
128+
tofu init -backend=false
127129
tofu validate
128130

129131
lint-rst:

0 commit comments

Comments
 (0)