Make tuning engine bw512

Author: PikaCat-OuO

.github/workflows/libcxx17.imp

@@ -10,6 +10,7 @@
     { include: [ "<__math/logarithms.h>", private, "<cmath>", public ] },
     { include: [ "<__ostream/basic_ostream.h>", private, "<ostream>", public ] },
     { include: [ "<__system_error/errc.h>", private, "<system_error>", public ] },
+    { include: [ "<__vector/vector.h>", private, "<vector>", public ] },
 
     # Mappings for includes between public headers
     { include: [ "<ios>", public, "<iostream>", public ] },

.github/workflows/tuning.yml

@@ -10,7 +10,7 @@ jobs:
     env:
       COMPCXX: clang++
       COMP: clang
-      ARCH: x86-64-bmi2
+      ARCH: x86-64-bw512
     defaults:
       run:
         working-directory: src
@@ -30,10 +30,12 @@ jobs:
           sudo update-alternatives --set clang++ /usr/bin/clang++-20
 
       - name: make
-        run: make clean && make -j build && make strip
+        run: |
+          make clean && make -j build ARCH=x86-64-bmi2 && make strip && mv pikafish pikafish-bmi2
+          make clean && make -j build && make strip
 
       - name: upload to fishtest
         run: curl https://test.pikafish.org/api/pre_upload -F file=@pikafish -F "file_type=engine" -F "password=${{ secrets.NOTHING }}"
 
       - name: print variables table
-        run: printf 'quit' | ./pikafish
+        run: printf 'quit' | ./pikafish-bmi2

src/position.cpp

@@ -789,8 +789,10 @@ bool Position::see_ge(Move m, int threshold) const {
 }
 
 
-// Like do_move(), but a little lighter
-std::pair<Piece, int> Position::light_do_move(Move m) {
+// A lighter version of do_move(), used in chasing detection
+std::pair<Piece, int> Position::do_move(Move m) {
+
+    assert(capture(m));
 
     Square from     = m.from_sq();
     Square to       = m.to_sq();
@@ -801,10 +803,8 @@ std::pair<Piece, int> Position::light_do_move(Move m) {
     idBoard[to]   = idBoard[from];
     idBoard[from] = 0;
 
-    if (captured)
-        // Update board and piece lists
-        remove_piece(to);
-
+    // Update board and piece lists
+    remove_piece(to);
     move_piece(from, to);
 
     sideToMove = ~sideToMove;
@@ -813,8 +813,8 @@ std::pair<Piece, int> Position::light_do_move(Move m) {
 }
 
 
-// Like undo_move(), but a little lighter
-void Position::light_undo_move(Move m, Piece captured, int id) {
+// A lighter version of undo_move(), used in chasing detection
+void Position::undo_move(Move m, Piece captured, int id) {
 
     sideToMove = ~sideToMove;
 
@@ -828,11 +828,7 @@ void Position::light_undo_move(Move m, Piece captured, int id) {
     move_piece(to, from);  // Put the piece back at the source square
 
     if (captured)
-    {
-        Square capsq = to;
-
-        put_piece(captured, capsq);  // Restore the captured piece
-    }
+        put_piece(captured, to);  // Restore the captured piece
 }
 
 
@@ -899,7 +895,7 @@ uint16_t Position::chased(Color c) {
                 else
                 {
                     bool trueChase             = true;
-                    const auto& [captured, id] = light_do_move(m);
+                    const auto& [captured, id] = do_move(m);
                     Bitboard recaptures        = attackers_to(to) & pieces(sideToMove);
                     while (recaptures)
                     {
@@ -910,7 +906,7 @@ uint16_t Position::chased(Color c) {
                             break;
                         }
                     }
-                    light_undo_move(m, captured, id);
+                    undo_move(m, captured, id);
 
                     if (trueChase)
                     {
@@ -959,13 +955,13 @@ Value Position::detect_chases(int d, int ply) {
         {
             if (!chase[sideToMove])
                 break;
-            light_undo_move(st->move, st->capturedPiece);
+            undo_move(st->move, st->capturedPiece);
             st = st->previous;
         }
         else
         {
             uint16_t after = chased(~sideToMove);
-            light_undo_move(st->move, st->capturedPiece);
+            undo_move(st->move, st->capturedPiece);
             st = st->previous;
             // Take the exact diff to detect the chase
             chase[sideToMove] &= after & ~chased(sideToMove);

src/position.h

@@ -169,8 +169,8 @@ class Position {
 
     // Other helpers
     void                  move_piece(Square from, Square to);
-    std::pair<Piece, int> light_do_move(Move m);
-    void                  light_undo_move(Move m, Piece captured, int id = 0);
+    std::pair<Piece, int> do_move(Move m);
+    void                  undo_move(Move m, Piece captured, int id = 0);
     Value                 detect_chases(int d, int ply = 0);
     bool                  chase_legal(Move m) const;
     template<bool AfterMove>

src/types.h

@@ -187,12 +187,13 @@ enum Piece : std::int8_t {
     B_ROOK = ROOK + 8, B_ADVISOR, B_CANNON, B_PAWN, B_KNIGHT, B_BISHOP, B_KING,
     PIECE_NB
 };
-
-constexpr Value PieceValue[PIECE_NB] = {
-  VALUE_ZERO, RookValue,   AdvisorValue, CannonValue, PawnValue,  KnightValue, BishopValue,  VALUE_ZERO,
-  VALUE_ZERO, RookValue,   AdvisorValue, CannonValue, PawnValue,  KnightValue, BishopValue,  VALUE_ZERO};
 // clang-format on
 
+constexpr Value PieceValue[PIECE_NB] = {VALUE_ZERO, RookValue,   AdvisorValue, CannonValue,
+                                        PawnValue,  KnightValue, BishopValue,  VALUE_ZERO,
+                                        VALUE_ZERO, RookValue,   AdvisorValue, CannonValue,
+                                        PawnValue,  KnightValue, BishopValue,  VALUE_ZERO};
+
 using Depth = int;
 
 // The following DEPTH_ constants are used for transposition table entries