fix: asterisk wildcard generates as invalid key without quotes (#44)

* fix: asterisk wildcard generates as invalid key without quotes

* fix: using json_encode() for both the key (when quoted) and the value, which properly escapes quotes, backslashes, newlines, unicode, and any other special characters

Author: shavonn

src/Commands/TypeScriptCommand.php

@@ -303,6 +303,8 @@ private function collectCapabilities(DefinitionDiscoverer $discoverer): array
      * - "article:view" → ["ArticlePermissions", "VIEW"]
      * - "user.create" → ["UserPermissions", "CREATE"]
      * - "admin" → ["Roles", "ADMIN"]
+     * - "article:*" → ["ArticlePermissions", "*"]
+     * - "*" → ["Permissions", "*"]
      *
      * @return array{0: string, 1: string}
      */
@@ -328,6 +330,14 @@ private function parseNameToGroupAndConst(string $name, string $defaultGroup): a
         return [$defaultGroup, $constName];
     }
 
+    /**
+     * Check if a string is a valid JavaScript/TypeScript identifier.
+     */
+    private function isValidIdentifier(string $name): bool
+    {
+        return (bool) preg_match('/^[a-zA-Z_$][a-zA-Z0-9_$]*$/', $name);
+    }
+
     /**
      * Group definitions by their source class.
      *
@@ -364,7 +374,11 @@ private function generateConstObject(string $groupName, array $items): string
         $lines = ["export const {$groupName} = {"];
 
         foreach ($items as $constName => $value) {
-            $lines[] = "  {$constName}: \"{$value}\",";
+            // Quote keys that aren't valid identifiers (e.g., wildcards like "*")
+            // Use json_encode for proper escaping of special characters
+            $key = $this->isValidIdentifier($constName) ? $constName : json_encode($constName);
+            $escapedValue = json_encode($value);
+            $lines[] = "  {$key}: {$escapedValue},";
         }
 
         $lines[] = '} as const;';

tests/Feature/Commands/TypeScriptCommandTest.php

@@ -83,6 +83,28 @@
         expect($content)->toContain('export type Role');
     });
 
+    it('quotes wildcard permissions as valid TypeScript property keys', function () {
+        config(['mandate.code_first.enabled' => false]);
+
+        // Create wildcard permissions in the database
+        OffloadProject\Mandate\Models\Permission::create(['name' => '*']);
+        OffloadProject\Mandate\Models\Permission::create(['name' => 'article:*']);
+
+        $outputFile = $this->outputPath.'/mandate.ts';
+
+        $this->artisan('mandate:typescript', ['--output' => $outputFile])
+            ->assertSuccessful();
+
+        $content = file_get_contents($outputFile);
+
+        // Wildcard keys should be quoted
+        expect($content)->toContain('"*": "*"');
+        expect($content)->toContain('"*": "article:*"');
+
+        // Should NOT contain unquoted * as a key
+        expect($content)->not->toMatch('/^\s+\*:/m');
+    });
+
     it('uses as const for objects', function () {
         $outputFile = $this->outputPath.'/mandate.ts';