Skip to content

Commit 9e579b1

Browse files
committed
[{c89stringutils/c89stringutils_string_extras.h,README.md}] concat_asprintf -> jasprintf; [{CMakeLists.txt,c89stringutils/CMakeLists.txt}] Reflect newfound CMake knowledge
1 parent 43bd8d9 commit 9e579b1

File tree

6 files changed

+223
-213
lines changed

6 files changed

+223
-213
lines changed

CMakeLists.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
cmake_minimum_required(VERSION 3.0)
1+
cmake_minimum_required(VERSION 3.12)
22
project(c89stringutils VERSION 0.0.1 LANGUAGES C)
33

44
set(CMAKE_C_STANDARD 90)
5-
cmake_policy(SET CMP0063 NEW)
65
set(CMAKE_C_VISIBILITY_PRESET hidden)
76
set(CMAKE_VISIBILITY_INLINES_HIDDEN YES)
87

@@ -41,10 +40,11 @@ include(CTest)
4140
enable_testing()
4241
add_subdirectory("c89stringutils_tests")
4342

44-
install(
45-
FILES "${PROJECT_BINARY_DIR}/${PROJECT_NAME}Config.h"
46-
DESTINATION "include"
47-
)
43+
# header-only so including this will pollute the `find_path` suggestion in vcpkg
44+
#install(
45+
# FILES "${PROJECT_BINARY_DIR}/${PROJECT_NAME}Config.h"
46+
# DESTINATION "include"
47+
#)
4848

4949
include(InstallRequiredSystemLibraries)
5050
set(CPACK_BUNDLE_NAME "${PROJECT_NAME}")
@@ -61,7 +61,7 @@ set(CPACK_PACKAGE_VERSION_MAJOR "${${PROJECT_NAME}_VERSION_MAJOR}")
6161
set(CPACK_PACKAGE_VERSION_MINOR "${${PROJECT_NAME}_VERSION_MINOR}")
6262
set(CPACK_RESOURCE_FILE_README "${CMAKE_CURRENT_SOURCE_DIR}/cmake/README.txt")
6363
set(CPACK_RESOURCE_FILE_WELCOME "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Welcome.txt")
64-
set(CPACK_PACKAGE_CONTACT "https://github.com/offscale/c89stringutils")
64+
set(CPACK_PACKAGE_CONTACT "https://github.com/offscale/${PROJECT_NAME}")
6565

6666
include(CPack)
6767
include(CMakePackageConfigHelpers)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Header only (to simplify including). Just `#define C89STRINGUTILS_IMPLEMENTATION
2525
| [`strerrorlen_s`](https://en.cppreference.com/w/c/string/byte/strerror) | From Safe C Library |
2626
| [`asprintf`](https://www.freebsd.org/cgi/man.cgi?query=asprintf) | From libressl-portable |
2727

28-
Additionally `concat_asprintf`, a version of `asprintf` that can concatenates on successive calls.
28+
Additionally `jasprintf`, a version of `asprintf` that concatenates on successive calls.
2929

3030
### Dependencies
3131

c89stringutils/CMakeLists.txt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
get_filename_component(LIBRARY_NAME "${CMAKE_CURRENT_SOURCE_DIR}" NAME)
2-
string(REPLACE " " "_" LIBRARY_NAME "${LIBRARY_NAME}")
32

43
set(Header_Files "c89stringutils_string_extras.h")
54

65
source_group("Header Files" FILES "${Header_Files}")
76

87
add_library("${LIBRARY_NAME}" INTERFACE "${Header_Files}")
98

9+
include(GNUInstallDirs)
1010
target_include_directories(
1111
"${LIBRARY_NAME}"
1212
INTERFACE
13-
"$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>"
14-
"$<INSTALL_INTERFACE:include>"
13+
"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>"
14+
"$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>"
1515
)
1616

1717
set_target_properties(
@@ -27,6 +27,8 @@ if (TARGET "${DEPENDANT_LIBRARY}")
2727
list(APPEND installable_libs "${DEPENDANT_LIBRARY}")
2828
endif ()
2929
install(TARGETS ${installable_libs}
30-
DESTINATION "${INSTALL_DEST}"
31-
EXPORT "${LIBRARY_NAME}Targets")
32-
install(FILES ${Header_Files} DESTINATION "include")
30+
EXPORT "${LIBRARY_NAME}Targets"
31+
ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}"
32+
LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}"
33+
RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}")
34+
install(FILES ${Header_Files} TYPE "INCLUDE")

0 commit comments

Comments
 (0)