[*.rs] clippy

Author: SamuelMarks

cli/src/sync.rs

@@ -108,8 +108,7 @@ fn process_models_for_openapi(model_dir: &Path) -> AppResult<()> {
 
         // Only process Rust files, skip mod.rs if we want (orphans usually valid, but typically we target struct files)
         // dsync generates mod.rs and table files.
-        if path.extension().map_or(false, |ext| ext == "rs")
-            && path.file_name().unwrap() != "mod.rs"
+        if path.extension().is_some_and(|ext| ext == "rs") && path.file_name().unwrap() != "mod.rs"
         {
             process_file(path)?;
         }

core/src/codegen.rs

@@ -97,7 +97,7 @@ pub fn generate_dtos(dtos: &[ParsedStruct]) -> String {
     imports.insert("use utoipa::ToSchema;".to_string());
 
     for dto in dtos {
-        collect_imports(&dto, &mut imports);
+        collect_imports(dto, &mut imports);
     }
 
     // 2. Write Imports
@@ -122,7 +122,7 @@ pub fn generate_dtos(dtos: &[ParsedStruct]) -> String {
 ///
 /// Useful for generating individual snippets or single-struct files.
 pub fn generate_dto(dto: &ParsedStruct) -> String {
-    generate_dtos(&[dto.clone()])
+    generate_dtos(std::slice::from_ref(dto))
 }
 
 /// Helper to generate the body of a single struct (without file-level imports).

core/src/oas.rs

@@ -248,7 +248,7 @@ fn map_schema_to_rust_type(schema: &RefOr<Schema>, is_required: bool) -> AppResu
     let type_str = match schema {
         RefOr::Ref(r) => {
             let path = &r.ref_location;
-            path.split('/').last().unwrap_or("Unknown").to_string()
+            path.split('/').next_back().unwrap_or("Unknown").to_string()
         }
         RefOr::T(s) => match s {
             Schema::Object(obj) => match obj.schema_type {
@@ -310,7 +310,7 @@ fn to_snake_case(s: &str) -> String {
 
 fn derive_handler_name(method: &str, path: &str) -> String {
     // GET /users/{id} -> get_users_id
-    let clean_path = path.replace('{', "").replace('}', "").replace('/', "_");
+    let clean_path = path.replace(['{', '}'], "").replace('/', "_");
     format!(
         "{}_{}",
         method.to_lowercase(),

core/src/parser.rs

@@ -101,7 +101,7 @@ pub fn extract_struct(code: &str, struct_name: &str) -> AppResult<ParsedStruct>
         .syntax()
         .descendants()
         .find_map(|node| {
-            ast::Struct::cast(node).filter(|s| s.name().map_or(false, |n| n.text() == struct_name))
+            ast::Struct::cast(node).filter(|s| s.name().is_some_and(|n| n.text() == struct_name))
         })
         .ok_or_else(|| AppError::General(format!("Struct '{}' not found", struct_name)))?;
 
@@ -161,14 +161,12 @@ fn extract_doc_comment(node: &SyntaxNode) -> Option<String> {
     for child in node.children_with_tokens() {
         if child.kind() == SyntaxKind::COMMENT {
             let text = child.to_string();
-            if text.starts_with("///") {
-                let content = &text[3..];
-                let content = if content.starts_with(' ') {
-                    &content[1..]
+            if let Some(content) = text.strip_prefix("///") {
+                lines.push(if let Some(stripped) = text.strip_prefix(' ') {
+                    stripped.to_owned()
                 } else {
-                    content
-                };
-                lines.push(content.to_string());
+                    content.to_owned()
+                });
             }
         }
     }

core/src/patcher.rs

@@ -58,11 +58,9 @@ pub fn add_struct_field(
                 insert_pos = prev.text_range().start().into();
             }
         }
-    } else {
-        if let Some(prev) = r_curly.prev_token() {
-            if prev.kind() == SyntaxKind::WHITESPACE && prev.text().ends_with('\n') {
-                prefix_newline = false;
-            }
+    } else if let Some(prev) = r_curly.prev_token() {
+        if prev.kind() == SyntaxKind::WHITESPACE && prev.text().ends_with('\n') {
+            prefix_newline = false;
         }
     }
 
@@ -111,7 +109,7 @@ pub fn modify_struct_field_type(
 
     let field = field_list
         .fields()
-        .find(|f| f.name().map_or(false, |n| n.text() == field_name))
+        .find(|f| f.name().is_some_and(|n| n.text() == field_name))
         .ok_or_else(|| {
             AppError::General(format!(
                 "Field '{}' not found in struct '{}'",
@@ -169,7 +167,7 @@ pub fn add_derive(source: &str, struct_name: &str, derive_trait: &str) -> AppRes
         let patch = if needs_comma {
             format!(", {}", derive_trait)
         } else {
-            format!("{}", derive_trait)
+            derive_trait.to_string()
         };
 
         new_source.insert_str(insert_pos, &patch);
@@ -294,7 +292,7 @@ fn find_struct(file: &SourceFile, name: &str) -> AppResult<ast::Struct> {
     file.syntax()
         .descendants()
         .filter_map(ast::Struct::cast)
-        .find(|s| s.name().map_or(false, |n| n.text() == name))
+        .find(|s| s.name().is_some_and(|n| n.text() == name))
         .ok_or_else(|| AppError::General(format!("Struct '{}' not found in source file", name)))
 }
 

core/src/route_generator.rs

@@ -56,7 +56,7 @@ pub fn register_routes(
         .syntax()
         .descendants()
         .find_map(ast::Fn::cast)
-        .filter(|f| f.name().map_or(false, |n| n.text() == "config"));
+        .filter(|f| f.name().is_some_and(|n| n.text() == "config"));
 
     if let Some(func) = config_fn {
         let body = func