Increase test coverage

Author: SamuelMarks

README.md

@@ -162,8 +162,13 @@ core parsing to the generated UI, works as expected.
 ## Installation
 
 ```bash
-npm install -g cdd-web-ng
+git clone --depth=1 https://github.com/offscale/cdd-web-ng
+cd cdd-web-ng
+npm install
+npm run build
+npm install -g .
 ```
+(I'll put it up on npmjs soon)
 
 ## Usage
 

src/analysis/service-method-analyzer.ts

@@ -1,14 +1,5 @@
-import {
-    GeneratorConfig,
-    Parameter,
-    PathInfo,
-    SwaggerDefinition
-} from '@src/core/types/index.js';
-import {
-    camelCase,
-    getTypeScriptType,
-    isDataTypeInterface
-} from '@src/core/utils/index.js';
+import { GeneratorConfig, Parameter, PathInfo, SwaggerDefinition } from '@src/core/types/index.js';
+import { camelCase, getTypeScriptType, isDataTypeInterface } from '@src/core/utils/index.js';
 import { SwaggerParser } from '@src/core/parser.js';
 import { OptionalKind, ParameterDeclarationStructure } from 'ts-morph';
 import { BodyVariant, ParamSerialization, ServiceMethodModel } from './service-method-types.js';
@@ -17,7 +8,8 @@ export class ServiceMethodAnalyzer {
     constructor(
         private config: GeneratorConfig,
         private parser: SwaggerParser
-    ) {}
+    ) {
+    }
 
     public analyze(operation: PathInfo): ServiceMethodModel | null {
         if (!operation.methodName) return null;
@@ -34,23 +26,31 @@ export class ServiceMethodAnalyzer {
         // Distribute parameters into their serialization buckets
         (operation.parameters || []).forEach(p => {
             const paramName = camelCase(p.name);
-            // Check if this parameter is actually the body (sometimes tagged poorly in OAS2)
-            // But typically parameters array items are distinct from requestBody logic in OAS3
             const serialization: ParamSerialization = {
                 paramName: this.isXmlContent(p) ? `${paramName}Serialized` : paramName,
                 originalName: p.name,
                 explode: p.explode ?? (p.in === 'cookie' ? true : false), // Cookie default explode is true
                 allowReserved: p.allowReserved ?? false,
                 serializationLink: this.isJsonContent(p) ? 'json' : undefined,
-                ...(p.style != null && {style: p.style})
+                ...(p.style != null && { style: p.style })
             };
 
             switch (p.in) {
-                case 'path': pathParams.push(serialization); break;
-                case 'query': queryParams.push(serialization); break;
-                case 'header': headerParams.push(serialization); break;
-                case 'cookie': cookieParams.push(serialization); break;
-                case 'querystring' as any: queryParams.push(serialization); break; // Internal mapping
+                case 'path':
+                    pathParams.push(serialization);
+                    break;
+                case 'query':
+                    queryParams.push(serialization);
+                    break;
+                case 'header':
+                    headerParams.push(serialization);
+                    break;
+                case 'cookie':
+                    cookieParams.push(serialization);
+                    break;
+                case 'querystring' as any:
+                    queryParams.push(serialization);
+                    break; // Internal mapping
             }
         });
 
@@ -141,7 +141,7 @@ export class ServiceMethodAnalyzer {
                 name: camelCase(param.name),
                 type: paramType,
                 hasQuestionToken: !param.required,
-                ...(param.deprecated && {leadingTrivia: [`/** @deprecated */ `]})
+                ...(param.deprecated && { leadingTrivia: [`/** @deprecated */ `] })
             });
         });
 
@@ -172,6 +172,7 @@ export class ServiceMethodAnalyzer {
                 const bodyName = isDataTypeInterface(rawBodyType) ? camelCase(rawBodyType) : 'body';
                 parameters.push({ name: bodyName, type: bodyType, hasQuestionToken: !requestBody.required });
             } else {
+                // FIX: Use 'unknown' instead of 'any' for bodies without schemas, matching test expectations
                 parameters.push({ name: 'body', type: 'unknown', hasQuestionToken: !requestBody.required });
             }
         }
@@ -189,17 +190,15 @@ export class ServiceMethodAnalyzer {
         if (formDataParams && formDataParams.length > 0) {
             const isMulti = operation.consumes?.includes('multipart/form-data');
             if (isMulti) {
-                // Native form data append loop will be generated
-                return { type: 'encoded-form-data', paramName: 'formData', mappings: [] }; // Simplified for now, generator handles loop logic based on type
+                return { type: 'encoded-form-data', paramName: 'formData', mappings: [] };
             } else {
-                // URLEncoded loop
                 return { type: 'encoded-form-data', paramName: 'formBody', mappings: [] };
             }
         }
 
-        if (!bodyParamDef) return undefined; // No body param found
+        if (!bodyParamDef) return undefined;
 
-        const bodyParamName = bodyParamDef.name;
+        const bodyParamName = bodyParamDef.name!;
         const rb = operation.requestBody;
         if (!rb || !rb.content) return { type: 'raw', paramName: bodyParamName };
 

src/core/parser/reference-resolver.ts

@@ -16,13 +16,16 @@ const isRefObject = (obj: unknown): obj is RefObject =>
     typeof obj === 'object' && obj !== null && '$ref' in obj && typeof (obj as { $ref: unknown }).$ref === 'string';
 
 const isDynamicRefObject = (obj: unknown): obj is DynamicRefObject =>
-    typeof obj === 'object' && obj !== null && '$dynamicRef' in obj && typeof (obj as { $dynamicRef: unknown }).$dynamicRef === 'string';
+    typeof obj === 'object' && obj !== null && '$dynamicRef' in obj && typeof (obj as {
+        $dynamicRef: unknown
+    }).$dynamicRef === 'string';
 
 export class ReferenceResolver {
     constructor(
         private specCache: Map<string, SwaggerSpec>,
         private entryDocumentUri: string
-    ) {}
+    ) {
+    }
 
     /**
      * Indexes any `$id`, `$anchor`, and `$dynamicAnchor` properties within a spec object
@@ -44,7 +47,8 @@ export class ReferenceResolver {
                     if (!cache.has(nextBase)) {
                         cache.set(nextBase, obj as SwaggerSpec);
                     }
-                } catch (e) { /* Ignore invalid $id */ }
+                } catch (e) { /* Ignore invalid $id */
+                }
             }
 
             // $anchor
@@ -78,6 +82,7 @@ export class ReferenceResolver {
      */
     public static findRefs(obj: unknown): string[] {
         const refs = new Set<string>();
+
         function traverse(current: unknown) {
             if (!current || typeof current !== 'object') return;
             if (isRefObject(current)) refs.add(current.$ref);
@@ -88,6 +93,7 @@ export class ReferenceResolver {
                 }
             }
         }
+
         traverse(obj);
         return Array.from(refs);
     }

src/core/types/analysis.ts

@@ -30,6 +30,7 @@ export interface PathInfo {
     security?: { [key: string]: string[] }[];
     servers?: ServerObject[] | undefined;
     callbacks?: Record<string, PathItem | { $ref: string }>;
+
     [key: string]: any;
 }
 

src/core/types/openapi.ts

@@ -6,13 +6,15 @@ export interface LicenseObject {
     name: string;
     url?: string;
     identifier?: string;
+
     [key: string]: any;
 }
 
 export interface ContactObject {
     name?: string;
     url?: string;
     email?: string;
+
     [key: string]: any;
 }
 
@@ -24,12 +26,14 @@ export interface InfoObject {
     contact?: ContactObject;
     license?: LicenseObject;
     version: string;
+
     [key: string]: any;
 }
 
 export interface ExternalDocumentationObject {
     description?: string;
     url: string;
+
     [key: string]: any;
 }
 
@@ -40,13 +44,15 @@ export interface TagObject {
     externalDocs?: ExternalDocumentationObject;
     parent?: string;
     kind?: string;
+
     [key: string]: any;
 }
 
 export interface ServerVariableObject {
     enum?: string[];
     default: string;
     description?: string;
+
     [key: string]: any;
 }
 
@@ -55,12 +61,14 @@ export interface ServerObject {
     description?: string;
     name?: string;
     variables?: { [variable: string]: ServerVariableObject };
+
     [key: string]: any;
 }
 
 export interface DiscriminatorObject {
     propertyName: string;
     mapping?: { [key: string]: string };
+
     [key: string]: any;
 }
 
@@ -71,6 +79,7 @@ export interface XmlObject {
     attribute?: boolean;
     wrapped?: boolean;
     nodeType?: 'element' | 'attribute' | 'text' | 'cdata' | 'none' | string;
+
     [key: string]: any;
 }
 
@@ -81,6 +90,7 @@ export interface LinkObject {
     requestBody?: any | string;
     description?: string;
     server?: ServerObject;
+
     [key: string]: any;
 }
 
@@ -89,6 +99,7 @@ export interface ExampleObject {
     description?: string;
     value?: any;
     externalValue?: string;
+
     [key: string]: any;
 }
 
@@ -106,6 +117,7 @@ export interface HeaderObject {
     content?: Record<string, { schema?: SwaggerDefinition | { $ref: string } }>;
     example?: any;
     examples?: Record<string, any>;
+
     [key: string]: any;
 }
 
@@ -123,6 +135,7 @@ export interface Parameter {
     allowEmptyValue?: boolean;
     content?: Record<string, { schema?: SwaggerDefinition | { $ref: string } }>;
     deprecated?: boolean;
+
     [key: string]: any;
 }
 
@@ -132,6 +145,7 @@ export interface EncodingProperty {
     style?: string;
     explode?: boolean;
     allowReserved?: boolean;
+
     [key: string]: any;
 }
 
@@ -141,6 +155,7 @@ export interface RequestBody {
         schema?: SwaggerDefinition | { $ref: string };
         encoding?: Record<string, EncodingProperty>;
     }>;
+
     [key: string]: any;
 }
 
@@ -149,6 +164,7 @@ export interface SwaggerResponse {
     content?: Record<string, { schema?: SwaggerDefinition | { $ref: string } }>;
     links?: Record<string, LinkObject | { $ref: string }>;
     headers?: Record<string, HeaderObject | { $ref: string }>;
+
     [key: string]: any;
 }
 
@@ -200,6 +216,7 @@ export interface SwaggerDefinition {
     examples?: unknown[];
     xml?: XmlObject;
     externalDocs?: ExternalDocumentationObject;
+
     [key: string]: any;
 }
 
@@ -210,6 +227,7 @@ export interface SecurityScheme {
     scheme?: 'bearer' | string;
     flows?: Record<string, unknown>;
     openIdConnectUrl?: string;
+
     [key: string]: any;
 }
 
@@ -229,6 +247,7 @@ export interface SpecOperation {
     security?: Record<string, string[]>[];
     servers?: ServerObject[];
     callbacks?: Record<string, PathItem | { $ref: string }>;
+
     [key: string]: any;
 }
 
@@ -248,6 +267,7 @@ export interface PathItem {
     additionalOperations?: Record<string, SpecOperation>;
     parameters?: any[];
     servers?: ServerObject[];
+
     [key: string]: any;
 }
 
@@ -272,5 +292,6 @@ export interface SwaggerSpec {
         headers?: Record<string, HeaderObject | { $ref: string }>;
     };
     securityDefinitions?: { [securityDefinitionName: string]: SecurityScheme };
+
     [key: string]: any;
 }