chore: align action to node20, ignore lib, update workflows, rebuild dist

Author: kmendell

.github/svelte-check-matcher.json

@@ -10,7 +10,7 @@
           "column": 3
         },
         {
-          "regexp": "^\\s*(Error|Warning|Warn):\\s*(.*?)(?:\\s+\\((?:ts|js|svelte|css)\\))?$",
+          "regexp": "^\\s*(Error|Warning|Warn|Hint):\\s*(.+?)(?:\\s+\\([^)]+\\))?$",
           "severity": 1,
           "message": 2,
           "loop": false

.github/workflows/release.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '24'
+          node-version: '20'
           cache: 'npm'
 
       - name: Install dependencies

.github/workflows/test.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '22'
+          node-version: '20'
           cache: 'npm'
 
       - name: Install dependencies
@@ -74,4 +74,4 @@ jobs:
             echo "❌ Expected action to fail on warnings"
             exit 1
           fi
-          echo "✅ Action correctly failed when fail-on-warnings enabled"
+          echo "✅ Action correctly failed when fail-on-warnings enabled"

.gitignore

@@ -5,4 +5,8 @@ node_modules/
 .vscode/
 
 # Don't ignore dist/ - GitHub Actions need the compiled code
-# dist/
+# dist/
+
+# Ignore build intermediates and coverage
+lib/
+coverage/

action.yml

@@ -32,5 +32,5 @@ outputs:
     description: 'Number of hints found'
 
 runs:
-  using: 'node24'
+  using: 'node20'
   main: 'dist/index.js'

dist/index.js

@@ -45,22 +45,61 @@ const core = __importStar(__nccwpck_require__(7484));
 const exec = __importStar(__nccwpck_require__(5236));
 const path = __importStar(__nccwpck_require__(6928));
 const fs = __importStar(__nccwpck_require__(9896));
+function stripAnsi(input) {
+    return input.replace(/[\u001B\u009B][[()\]#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g, '');
+}
+function parseFindings(output, workingDirectory) {
+    const clean = stripAnsi(output);
+    const lines = clean.split(/\r?\n/);
+    const findings = [];
+    for (let i = 0; i < lines.length; i++) {
+        const loc = lines[i].match(/^(.+?):(\d+):(\d+)$/);
+        if (!loc)
+            continue;
+        const [, relFile, lineStr, colStr] = loc;
+        const next = lines[i + 1] || '';
+        const sevLine = next.match(/^\s*(Error|Warning|Warn|Hint):\s*(.*?)(?:\s+\([^)]+\))?$/);
+        if (!sevLine)
+            continue;
+        let sev = sevLine[1];
+        const message = sevLine[2];
+        if (sev === 'Warn')
+            sev = 'Warning';
+        const filePath = path.normalize(path.join(workingDirectory, relFile));
+        const line = parseInt(lineStr, 10) || 1;
+        const col = parseInt(colStr, 10) || 1;
+        findings.push({ severity: sev, message, file: filePath, line, col });
+    }
+    return findings;
+}
+function annotateFromOutput(output, workingDirectory) {
+    const findings = parseFindings(output, workingDirectory);
+    for (const f of findings) {
+        const props = { file: f.file, startLine: f.line, startColumn: f.col, title: 'svelte-check' };
+        if (f.severity === 'Error')
+            core.error(f.message, props);
+        else if (f.severity === 'Warning')
+            core.warning(f.message, props);
+        else
+            core.notice(f.message, props);
+    }
+    return findings;
+}
 async function run() {
     try {
         const workingDirectory = core.getInput('working-directory') || '.';
         const failOnWarnings = core.getInput('fail-on-warnings') === 'true';
         const failOnHints = core.getInput('fail-on-hints') === 'true';
         const tsconfig = core.getInput('tsconfig');
-        const matcherPath = path.join(__dirname, '..', '.github', 'svelte-check-matcher.json');
+        // When bundled with ncc, the matcher file should be in the same directory as index.js
+        const matcherPath = path.join(__dirname, 'svelte-check-matcher.json');
         core.info(`Adding problem matcher: ${matcherPath}`);
         console.log(`::add-matcher::${matcherPath}`);
-        // Detect SvelteKit and run `svelte-kit sync` to ensure .svelte-kit/tsconfig.json exists
         let looksLikeSvelteKit = false;
         try {
             const pkgJsonPath = path.join(workingDirectory, 'package.json');
             const pkg = JSON.parse(fs.readFileSync(pkgJsonPath, 'utf8'));
-            looksLikeSvelteKit = Boolean((pkg.dependencies && pkg.dependencies['@sveltejs/kit']) ||
-                (pkg.devDependencies && pkg.devDependencies['@sveltejs/kit']));
+            looksLikeSvelteKit = Boolean((pkg.dependencies && pkg.dependencies['@sveltejs/kit']) || (pkg.devDependencies && pkg.devDependencies['@sveltejs/kit']));
         }
         catch {
             // ignore, skip sync
@@ -100,39 +139,39 @@ async function run() {
         };
         const exitCode = await exec.exec(npx, args, options);
         core.info(`svelte-check exit code: ${exitCode}`);
-        const errorCount = (output.match(/Error:/g) || []).length;
-        const warningCount = (output.match(/Warning:/g) || []).length;
-        const hintCount = (output.match(/Hint:/g) || []).length;
+        const findings = annotateFromOutput(output + '\n' + errorOutput, workingDirectory);
+        const errorCount = findings.filter((f) => f.severity === 'Error').length;
+        const warningCount = findings.filter((f) => f.severity === 'Warning').length;
+        const hintCount = findings.filter((f) => f.severity === 'Hint').length;
         core.setOutput('errors', String(errorCount));
         core.setOutput('warnings', String(warningCount));
         core.setOutput('hints', String(hintCount));
         core.info('Svelte Check Results:');
         core.info(`  Errors: ${errorCount}`);
         core.info(`  Warnings: ${warningCount}`);
         core.info(`  Hints: ${hintCount}`);
-        let shouldFail = false;
+        // Always fail if svelte-check itself failed
+        if (exitCode !== 0) {
+            core.error(`svelte-check exited with code ${exitCode}`);
+        }
+        let shouldFail = exitCode !== 0;
         if (errorCount > 0) {
             shouldFail = true;
-            core.error(`Found ${errorCount} errors`);
+            core.error(`Found ${errorCount} error(s) - failing build`);
         }
         if (failOnWarnings && warningCount > 0) {
             shouldFail = true;
-            core.error(`Found ${warningCount} warnings (fail-on-warnings is enabled)`);
+            core.error(`Found ${warningCount} warning(s) (fail-on-warnings is enabled)`);
         }
         if (failOnHints && hintCount > 0) {
             shouldFail = true;
-            core.error(`Found ${hintCount} hints (fail-on-hints is enabled)`);
-        }
-        // If svelte-check failed for other reasons, surface stderr
-        if (!shouldFail && exitCode !== 0 && errorOutput.trim()) {
-            shouldFail = true;
-            core.error(errorOutput);
+            core.error(`Found ${hintCount} hint(s) (fail-on-hints is enabled)`);
         }
         if (shouldFail) {
             core.setFailed('Svelte check found issues');
         }
         else {
-            core.info('Svelte check completed successfully');
+            core.info('✅ Svelte check completed successfully');
         }
     }
     catch (error) {

dist/svelte-check-matcher.json

@@ -0,0 +1,21 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "svelte-check",
+      "pattern": [
+        {
+          "regexp": "^([^\\s].*):(\\d+):(\\d+)$",
+          "file": 1,
+          "line": 2,
+          "column": 3
+        },
+        {
+          "regexp": "^\\s*(Error|Warning|Warn|Hint):\\s*(.+?)(?:\\s+\\([^)]+\\))?$",
+          "severity": 1,
+          "message": 2,
+          "loop": false
+        }
+      ]
+    }
+  ]
+}