Failing JSON::GenericObject test

[fnordfish]

I'm trying to build oj locally and get this failure when running tests.

With REAL_JSON_GEM == true and JSON::VERSION == "2.18.0", this spec is failing on Ruby 3.4.7 and 4.0.1

===============================================================================
Failure: test_parse_json(JSONGenericObjectTest):
  <{"a"=>1, "b"=>2, "json_class"=>"JSON::GenericObject"}> was expected to be kind_of?
  <JSON::GenericObject> but was
  <Hash>.
test/json_gem/json_generic_object_test.rb:39:in 'JSONGenericObjectTest#test_parse_json'
     36:     # JSON after 2.10 no longer allows GenericObject creatable to be turned off or so it appears.
     37:     pp REAL_JSON_GEM, JSON::VERSION # added by me for debugging
     38:     ch = JSON::GenericObject if REAL_JSON_GEM && ([2, 11, 0] <=> JSON::VERSION.split('.').map { |v| v.to_i }) <= 0
  => 39:     assert_kind_of ch,
     40:                    JSON(
     41:                      '{ "json_class": "JSON::GenericObject", "a": 1, "b": 2 }',
     42:                      :create_additions => true
===============================================================================

[ohler55]

I look into what changed in the latest ruby versions.

[ohler55]

The json gem tests were copied many years ago and the json gem has changed since then. Some of the features in the older json gem versions are no longer supported or have changed. What you are seeing is a version of the json gem that no longer supports generic objects. It is not a failing of Oj but rather support for generic objects being dropped in the new json gem.

[fnordfish]

It is not a failing of Oj but rather support for generic objects being dropped in the new json gem

That's what I figured :) But how do we get the test green?

[ohler55]

Piggybacked on the "no-ostruct" branch. See if that works for you.

[fnordfish]

The "no-ostruct" branch works on 3.4, but on 4.0 I initially get those:

Error: test_ostruct(JSONAdditionTest): NameError: uninitialized constant JSONAdditionTest::OpenStruct
test/json_gem/json_addition_test.rb:211:in 'JSONAdditionTest#test_ostruct'
     208:   end
     209:
     210:   def test_ostruct
  => 211:     o = OpenStruct.new
     212:     # XXX this won't work; o.foo = { :bar => true }
     213:     o.foo = { 'bar' => true }
     214:     assert_equal o, JSON.parse(JSON(o), :create_additions => true)

and

bundle exec ruby -Itest test/json_gem/json_parser_test.rb
test/json_gem/json_parser_test.rb:10: warning: ostruct used to be loaded from the standard library, but is not part of the default gems since Ruby 4.0.0.
You can add ostruct to your Gemfile or gemspec to fix this error.
/usr/local/lib/ruby/4.0.0/bundled_gems.rb:60:in 'Kernel.require': cannot load such file -- ostruct (LoadError)
Did you mean?  tsort
        from /usr/local/lib/ruby/4.0.0/bundled_gems.rb:60:in 'block (2 levels) in Kernel#replace_require'
        from test/json_gem/json_parser_test.rb:10:in '<main>'

Manually adding "ostruct" as development dependency to the gemspec fixes them

[ohler55]

Thanks for the suggested fix. Pushed the change.