SHORT_HOST variable appears unused and adds latency during startup

[PinkD]

While profiling my bash startup time, I notice this command takes about 0.05s

time scutil --get ComputerName
<my hostname here>

real	0m0.048s
user	0m0.024s
sys	0m0.020s

And it's used to get SHORT_HOST on macos. I searched the codebase and found it's never used. Maybe we can remove it to improve the startup time?

oh-my-bash/oh-my-bash.sh

Line 125 in 63ebf65

SHORT_HOST=$(scutil --get ComputerName 2>/dev/null) || SHORT_HOST=${HOST/.*}

BTW, another time consuming op is tput which can be disabled by OMB_TERM_USE_TPUT="no"

ref: #668

[akinomyoga]

The upstream Oh My Zsh seems to have the same code in oh-my-zsh.sh, and the variable is used by themes fino, fino-time, and candy-kingdom, and also plugins keychain and ssh-agent. Since it seems we haven't imported those themes and plugins, we can drop the initialization of this variable SHORT_HOST. However, we need to care about the variable when we import any of these themes or plugins in the future.

BTW, another time consuming op is tput which can be disabled by OMB_TERM_USE_TPUT="no"

This is already discussed in #668. Actually, that variable is introduced by #668. The tput command is used by default for terminal compatibility. However, we may mention it in README.

ref: #668

0.05s by SHORT_HOST seems negligible considering the bad case 2s in #668. Note that 2s includes all the time consumed by modules sourced from oh-my-bash.sh but not just the time of oh-my-bash.sh.

[akinomyoga]

Sorry, I didn't mean we should keep the variable SHORT_HOST.

We may drop it, but we need to be careful when we import themes from the upstream Oh My Zsh. Also, we may mention OMB_TERM_USE_TPUT in README.